DESCRIBE CHANGES %{background:yellow}TODO% *General* Information
The following files were detected as changed between branches #622_Merge_NI1588 and develop
Source/Components/DataSources/NI1588/NI1588Timestamp.cpp
Source/Components/DataSources/NI1588/NI1588Timestamp.h
Test/Components/DataSources/NI1588/NI1588TimestampGTest.cpp
Test/Components/DataSources/NI1588/NI1588TimestampTest.cpp
Test/Components/DataSources/NI1588/NI1588TimestampTest.h
%{color:green}OK:% no errors found. h1. Requirements review *Date of the review:* 06/04/2021 *Person who did the review:* TODO *Version of requirements:* %{background:yellow}TODO% *Result of review:* %{background:yellow}TODO% *List of non-conformities:* %{background:yellow}TODO% *Comments:* %{background:yellow}TODO% h1. Architecture & design review *Date of the review:* 06/04/2021 *Person who did the review:* TODO *Version of architecture & design document:* %{background:yellow}TODO% *Result of review:* %{background:yellow}TODO% *List of non-conformities:* %{background:yellow}TODO% *Comments:* %{background:yellow}TODO% h1. Code and documentation review *Date of the review:* 06/04/2021 *Person who did the review:* TODO *Version of source code:* c9cb11171f7d139aa8ec78d8d82a0c40ab5bd9e2 *Result of review:* %{background:yellow}TODO% *List of non-conformities:* %{background:red}Run flexelint and report% %{background:yellow}TODO% *Headers* %{color:green}OK:% All headers are correctly formatted %{color:green}OK:% no errors found. *Lint includes* %{color:green}OK:% All files are being included for linting %{color:green}OK:% no errors found. *Linter* %{color:red}ERR:% /home/codac-dev/MARTe2-dev/MakeDefaults/Lint/marte_flint_exceptions.lnt 15 %{color:red}ERR:% Lint/marte_components_flint_files.lnt:114:1: Error 305: Unable to open module 'EventConditionTrigger.cpp' *Doxygen* %{color:red}ERR:% warning: source ./Docs/Assets/Snippets/Parsing/MathGrammar.ll is not a readable file or directory... skipping. %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:45: warning: Compound OPCUA::NodeProperties is not documented. %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:60: warning: Compound OPCUA::ObjectProperties is not documented. %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:354: warning: Member EPICSPVAStructureDataI::ReadArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value) (function) of namespace MARTe is not documented. %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:417: warning: Member EPICSPVAStructureDataI::WriteArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value, const uint32 &size) (function) of namespace MARTe is not documented. %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:54: warning: Member OPCUANodeSettings (typedef) of namespace OPCUA is not documented. %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:68: warning: Member OPCUAObjectSettings (typedef) of namespace OPCUA is not documented. %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:21: warning: explicit link request to 'include(CheckIPOSupported)' could not be resolved %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:22: warning: explicit link request to 'check_ipo_supported(RESULT CC_HAS_IPO)' could not be resolved %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:23: warning: explicit link request to 'if(CC_HAS_IPO)' could not be resolved %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:25: warning: explicit link request to 'endif()' could not be resolved %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:28: warning: found at different nesting level (5) than expected (2) %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:29: warning: found at different nesting level (5) than expected (2) %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:42: warning: end of comment block while expecting command %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:112: warning: Unsupported xml/html tag found %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:113: warning: Unsupported xml/html tag found %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:114: warning: Unsupported xml/html tag found %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:115: warning: Unsupported xml/html tag found %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:286: warning: Unsupported xml/html tag found %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/LoggerDataSource/LoggerBroker.h:76: warning: Member SetPeriod(const uint32 cyclePeriodIn) (function) of class MARTe::LoggerBroker is not documented. %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/LoggerDataSource/LoggerDataSource.h:68: warning: Member Initialise(StructuredDataI &data) (function) of class MARTe::LoggerDataSource is not documented. %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:90: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath) %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:90: warning: The following parameters of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented: %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:79: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath) %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:79: warning: The following parameters of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented: %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/ProfinetDataSource.h:339: warning: expected
  • tag but found TK_LNKWORD token instead! %{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/ProfinetDataSource.h:622: warning: unexpected end of comment while inside