Requirements review¶

Date of the review: 04/01/2015

Person who did the review: Ivan Herrero

Version of requirements: 0.10

Result of review: N/A

List of non-conformities: N/A

Comments: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal requirements.

Architecture & design review¶

Date of the review: 04/01/2015

Person who did the review: Ivan Herrero

Version of architecture & design document: 0.10

Result of review: N/A

List of non-conformities: N/A

Comments: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal design.

Code and documentation review¶

Date of the review: 04/01/2015

Person who did the review: Ivan Herrero

Version of source code: 0.10

Result of review: PASS

List of non-conformities:

• #287
  Strategy to handle duplication of StringHelper and StringPortable to be discussed in the next Sprint.
  ./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:45:34: Error 14: Symbol 'MARTe::StringHelper::Length(const char *)' previously defined (line 155, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
  ./Source/Core/BareMetal/L1Portability/StringHelper.h:155:1: Info 830: Location cited in prior message
  ./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:62:34: Error 14: Symbol 'MARTe::StringHelper::Compare(const char *, const char *)' previously defined (line 99, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
  ./Source/Core/BareMetal/L1Portability/StringHelper.h:99:1: Info 830: Location cited in prior message
  ./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:96:29: Error 14: Symbol 'MARTe::StringHelper::CompareN(const char *, const char *, unsigned int)' previously defined (line 110, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
  ./Source/Core/BareMetal/L1Portability/StringHelper.h:110:1: Info 830: Location cited in prior message
  ./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:132:37: Error 14: Symbol 'MARTe::StringHelper::Concatenate(char *, const char *)' previously defined (line 67, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
  ./Source/Core/BareMetal/L1Portability/StringHelper.h:67:1: Info 830: Location cited in prior message
  ./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:153:32: Error 14: Symbol 'MARTe::StringHelper::ConcatenateN(char *, const char *, unsigned int)' previously defined (line 80, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
  ./Source/Core/BareMetal/L1Portability/StringHelper.h:80:1: Info 830: Location cited in prior message
  ./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:175:37: Error 14: Symbol 'MARTe::StringHelper::SearchChar(const char *, char)' previously defined (line 90, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
  ./Source/Core/BareMetal/L1Portability/StringHelper.h:90:1: Info 830: Location cited in prior message
  ./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:205:30: Error 14: Symbol 'MARTe::StringHelper::Copy(char *, const char *)' previously defined (line 122, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
  ./Source/Core/BareMetal/L1Portability/StringHelper.h:122:1: Info 830: Location cited in prior message
  ./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:219:25: Error 14: Symbol 'MARTe::StringHelper::CopyN(char *, const char *, unsigned int)' previously defined (line 135, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
  ./Source/Core/BareMetal/L1Portability/StringHelper.h:135:1: Info 830: Location cited in prior message
  ./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:232:38: Error 14: Symbol 'MARTe::StringHelper::SearchIndex(const char *, const char *)' previously defined (line 147, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
  ./Source/Core/BareMetal/L1Portability/StringHelper.h:147:1: Info 830: Location cited in prior message
  ./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:266:45: Error 14: Symbol 'MARTe::StringHelper::SearchChars(const char *, const char *)' previously defined (line 163, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
  ./Source/Core/BareMetal/L1Portability/StringHelper.h:163:1: Info 830: Location cited in prior message
  ./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:310:41: Error 14: Symbol 'MARTe::StringHelper::SearchLastChar(const char *, char)' previously defined (line 172, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
  ./Source/Core/BareMetal/L1Portability/StringHelper.h:172:1: Info 830: Location cited in prior message
  ./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:335:46: Error 14: Symbol 'MARTe::StringHelper::SearchString(const char *, const char *)' previously defined (line 181, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
  ./Source/Core/BareMetal/L1Portability/StringHelper.h:181:1: Info 830: Location cited in prior message
  ./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:363:26: Error 14: Symbol 'MARTe::StringHelper::SetChar(char *, unsigned int, char)' previously defined (line 228, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
  ./Source/Core/BareMetal/L1Portability/StringHelper.h:228:1: Info 830: Location cited in prior message
  Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetDay(unsigned int)
  Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetHour(unsigned int)
  Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetMinutes(unsigned int)
  Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetMonth(unsigned int)
  Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetSeconds(unsigned int)
  Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetYear(unsigned int)

• #288 - The ParserI and LexicalAnalyzer classes receive a stream by reference (StreamI&) on its constructor, but both store internally the address of the stream and use it as an explicit pointer, and accessing it on other functions. From the point of view of the user of the class, passing by reference a parameter in a function means that the object will be only accessed during the execution of the function (constructor in this case), but not during the lifetime of the instance of the class. It should be better declaring it as an explicit pointer on the constructor.

Unit test review¶

Date of the review: 04/01/2015

Person who did the review: Ivan Herrero

Version of unit tests: 0.10

Result of coverage tests review: PASS

Result of functional tests review: PASS

Result of review: PASS

List of non-conformities:

• #289 - Note the usual tests continue to fail in Windows:
  [ FAILED ] 12 tests, listed below:
  [ FAILED ] BasicConsoleGTest.TestRead
  [ FAILED ] BasicFileGTest.TestOpen_FLAG_CREAT_EXCLUSIVE
  [ FAILED ] DirectoryGTest.TestGetLastAccessTime_ReRead
  [ FAILED ] DirectoryGTest.TestGetLastAccessTime_ReRead2
  [ FAILED ] LoadableLibraryGTest.TestOpenCloseLibrary
  [ FAILED ] LoadableLibraryGTest.TestCloseLibrary
  [ FAILED ] LoadableLibraryGTest.TestLoadFunction
  [ FAILED ] LoadableLibraryGTest.TestLoadFunctionSquareBracketsOperator
  [ FAILED ] LoadableLibraryGTest.TestGetModule
  [ FAILED ] MutexSemGTest.TestIsRecursive
  [ FAILED ] MutexSemGTest.TestRecursiveOff
  [ FAILED ] ThreadsGTest.TestBeginThreadStacksize0

Integration test review¶

Date of the review: 04/01/2015

Person who did the review: Ivan Herrero

Version of integration tests: 0.10

Result of review: N/A

List of non-conformities: N/A

Comments: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal integration tests.

Acceptance test review¶

Date of the review: 04/01/2015

Person who did the review: Ivan Herrero

Version of acceptance tests: 0.10

Result of review: N/A

List of non-conformities: N/A

Comments: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal acceptance tests.