The v0.19 solves several minor bug fixes and offers the IntrospectionStructure interface.

Requirements review¶

Date of the review: 18/12/2018

Person who did the review: André Neto

Version of requirements: N/A

Result of review: N/A

List of non-conformities: N/A

Comments: No new requirements were added w.r.t. to v0.19.

Architecture & design review¶

Date of the review: 18/12/2018

Person who did the review: André Neto

Version of architecture & design document: N/A

Result of review: N/A

List of non-conformities: N/A

Comments: No updates related to the architecture.

Code and documentation review¶

Date of the review: 18/12/2018

Person who did the review: André Neto

Version of source code: 0.19

Result of review: PASS

List of non-conformities:

 Note 974: Worst case function for stack usage: 'MARTe::ConfigurationDatabase::Copy' is recursive, loop contains call to 'MARTe::ConfigurationDatabase::Copy'. See +stack for a full report. [MISRA C++ Rule 7-5-4]

List of warnings reported by Doxygen:

documented symbol `DoubleInteger< T > MARTe::DoubleInteger< T >::operator &' was not declared or defined.    Source/Core/BareMetal/L0Types/DoubleInteger.h    
documented symbol `void MARTe::DoubleInteger< T >::operator &=' was not declared or defined.    Core/BareMetal/L0Types/DoubleInteger.h    
documented symbol `ReferenceT< T > * MARTe::ReferenceT< T >::operator &' was not declared or defined.    Source/Core/BareMetal/L2Objects/ReferenceT.h
warning: Member CLASS_REGISTER(IntrospectionStructure, "1.0") (function) of namespace MARTe is not documented.
warning: Member CLASS_REGISTER(IntrospectionStructure, "1.0") (function) of namespace MARTe is not documented.

Remark
The documentation of DataSourceI has to be revisited.

Remark
The SquareRoot template methods for float32 and float64 need to be provided.

template<typename Type>
inline Type SquareRoot(const Type x) {

    Type tmp = x;

    if (tmp < (Type) 0) {
        REPORT_ERROR_STATIC_0(ErrorManagement::Warning, "SquareRoot<Type> of negative number");
        tmp *= -1;
    }

    return sqrt(tmp);
}

It is only valid for Type being float64. In case of float32, there would be an implicit casting to satisfy the sqrt method. Two implementations shall be provided to call sqrt and sqrtf, as appropriate

Remark
The following classes have non-virtual destructors. As long they are not base classes of any derived class, it is safe, but they need to be monitored (flexlint will check and signal this as error code 1509).

Matrix, Vector, GlobalObjectsDatabase, LoadableLibrary, MemoryArea, StaticListHolder, CharBuffer, AnyTypeCreator, LexicalAnalyzer, Token, TokenInfo, Directory, MutexSem, ThreadInformation.

Unit test review¶

Date of the review: 18/12/2018

Person who did the review: André Neto

Version of unit tests: 0.19

Result of coverage tests review: PASS

Result of functional tests review: PASS

Result of review: PASS

List of non-conformities:

LCOV report (files containing functions not executed at all):
Note: execute with

lcov -l  Build/MARTe2.coverage.info

and compare with the latest master release using tkdiff.

Files containing functions with coverage < 90% or which have changed w.r.t. to last master release. Exclamation marks inform of differences w.r.t. to the last master.:_

    1                                                  |Lines      |Functions|Branches        1                                                  |Lines      |Functions|Branches
     2   Filename                                       |Rate    Num|Rate  Num|Rate   Num      2   Filename                                       |Rate    Num|Rate  Num|Rate   Num
     3   ================================================================================      3   ================================================================================
     7 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/]                                !
    38   L1Portability/Environm...Linux/BasicConsole.cpp|79.4%   223|76.2%  42|    -    0     34   L1Portability/Environm...Linux/BasicConsole.cpp|79.4%   223|76.2%  42|    -    0
    54   L1Portability/FastResourceContainer.cpp        |83.5%    97|71.4%   7|    -    0     50   L1Portability/FastResourceContainer.cpp        |83.5%    97|71.4%   7|    -    0
    90   L2Objects/Introspection.cpp                    |73.3%    15|85.7%   7|    -    0     86   L2Objects/Introspection.cpp                    |73.3%    15|85.7%   7|    -    0
    91 ! L2Objects/IntrospectionEntry.cpp               |87.3%   102|93.3%  15|    -    0     87 ! L2Objects/IntrospectionEntry.cpp               |88.3%   111|93.3%  15|    -    0
    94   L2Objects/Object.cpp                           |88.8%   250|96.8%  31|    -    0     90   L2Objects/Object.cpp                           |88.8%   250|96.8%  31|    -    0
   107 ! L2Objects/ReferenceT.h                         |94.2%    86|67.2%  1k|    -    0    103 ! L2Objects/ReferenceT.h                         |94.2%    86|67.8%  1k|    -    0
   117   L3Streams/DoubleBufferedStream.cpp             |82.7%   110|84.0%  25|    -    0    113   L3Streams/DoubleBufferedStream.cpp             |82.7%   110|84.0%  25|    -    0
   119 ! L3Streams/IOBuffer.cpp                         |95.1%   669|96.7%  30|    -    0    115 ! L3Streams/IOBuffer.cpp                         |95.0%   655|96.7%  30|    -    0
   122   L3Streams/IOBufferIntegerPrint.cpp             |85.2%   460|93.5%  93|    -    0    118   L3Streams/IOBufferIntegerPrint.cpp             |85.2%   460|93.5%  93|    -    0
   124   L3Streams/SingleBufferedStream.cpp             |84.1%   176|83.3%  24|    -    0    120   L3Streams/SingleBufferedStream.cpp             |84.1%   176|83.3%  24|    -    0
   148 ! L4Configuration/TypeConversion.cpp             |94.8%   601|95.2%  21|    -    0    142 ! L4Configuration/TypeConversion.cpp             |95.8%   530|95.2%  21|    -    0
   158   L4Messages/ObjectRegistryDatabaseMessageI.cpp  |72.7%    11|88.9%   9|    -    0    152   L4Messages/ObjectRegistryDatabaseMessageI.cpp  |72.7%    11|88.9%   9|    -    0
   166 ! L5GAMs/GAMDataSource.cpp                       |93.9%   197|94.7%  19|    -    0    160 ! L5GAMs/GAMDataSource.cpp                       |94.0%   184|94.7%  19|    -    0

   194 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/FileSystem/L1Portability/Environment/Linux/]   188 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/FileSystem/L1Portability/Environment/Linux/]
   195   BasicFile.cpp                                  |87.8%   278|93.9%  33|    -    0    189   BasicFile.cpp                                  |87.8%   278|93.9%  33|    -    0
   199   BasicUDPSocket.cpp                             |88.1%   118|95.7%  23|    -    0    193   BasicUDPSocket.cpp                             |88.1%   118|95.7%  23|    -    0
   201   DirectoryScanner.cpp                           |88.0%    92|90.0%  10|    -    0    195   DirectoryScanner.cpp                           |88.0%    92|90.0%  10|    -    0

   206 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/FileSystem/L3Streams/]                 200 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/FileSystem/L3Streams/]
   207   File.cpp                                       |71.4%     7|57.1%   7|    -    0    201   File.cpp                                       |71.4%     7|57.1%   7|    -    0

   214 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/FileSystem/L6App/Environment/Linux/]   208 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/FileSystem/L6App/Environment/Linux/]
   215   Bootstrap.cpp                                  |41.9%    31|60.0%   5|    -    0    209   Bootstrap.cpp                                  |41.9%    31|60.0%   5|    -    0

   225 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/Scheduler/L1Portability/]              219 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/Scheduler/L1Portability/]
   226   ExceptionHandler.h                             | 0.0%     2| 0.0%   2|    -    0    220   ExceptionHandler.h                             | 0.0%     2| 0.0%   2|    -    0

   228 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/Scheduler/L3Services/]                 222 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/Scheduler/L3Services/]

   243 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/Scheduler/L4LoggerService/]            237 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/Scheduler/L4LoggerService/]

   248 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/Scheduler/L4Messages/]                 242 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/Scheduler/L4Messages/]
   249 ! QueuedMessageI.cpp                             |95.9%    49|90.0%  10|    -    0    243 ! QueuedMessageI.cpp                             |93.9%    49|90.0%  10|    -    0

   253 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/Scheduler/L4StateMachine/]             247 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/Scheduler/L4StateMachine/]

   257 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/Scheduler/L5GAMs/]                     251 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/Scheduler/L5GAMs/]

   262   ================================================================================    256   ================================================================================
   263 !                                          Total:|94.1% 21054|87.8%  7k|    -    0    257 !                                          Total:|94.5% 20656|87.9%  7k|    -    0

GTest report

 [----------] Global test environment tear-down
 [==========] 4000 tests from 155 test cases ran. (238689 ms total)
 [  PASSED  ] 3999 tests.
 [  FAILED  ] 1 tests, listed below:
 [  FAILED  ] IOBufferGTest.TestPrintStructuredDataInterface

Integration test review¶

Date of the review: 18/12/2018

Person who did the review: André Neto

Version of integration tests: 0.19

Result of review: N/A

List of non-conformities: N/A

Comments: Not performed.

Acceptance test review¶

Date of the review: 18/12/2018

Person who did the review: André Neto

Version of acceptance tests: 0.19

Result of review: N/A

List of non-conformities: N/A

Comments: Not performed.