Meeting #355
MARTe2 QA-audit (v1.0.0)
Start date:
09.04.2019
Due date:
% Done:
0%
Estimated time:
Description
The v1.0.0 is the first release with all the original framework requirements, including the HTTP interface.
Requirements review¶
Date of the review: 09/04/2019
Person who did the review: André Neto
Version of requirements: N/A
Result of review: N/A
List of non-conformities: N/A
Comments: No new requirements were added w.r.t. to v0.19.
Architecture & design review¶
Date of the review: 09/04/2019
Person who did the review: André Neto
Version of architecture & design document: N/A
Result of review: N/A
List of non-conformities: N/A
Comments: No updates related to the architecture.
Code and documentation review¶
Date of the review: 09/04/2019
Person who did the review: André Neto
Version of source code: 1.0.0
Result of review: PASS
List of non-conformities:
Note 974: Worst case function for stack usage: 'MARTe::ConfigurationDatabase::Copy' is recursive, loop contains call to 'MARTe::ConfigurationDatabase::Copy'. See +stack for a full report. [MISRA C++ Rule 7-5-4]
List of warnings reported by Doxygen:
documented symbol `DoubleInteger< T > MARTe::DoubleInteger< T >::operator &' was not declared or defined. Source/Core/BareMetal/L0Types/DoubleInteger.h documented symbol `void MARTe::DoubleInteger< T >::operator &=' was not declared or defined. Core/BareMetal/L0Types/DoubleInteger.h documented symbol `ReferenceT< T > * MARTe::ReferenceT< T >::operator &' was not declared or defined. Source/Core/BareMetal/L2Objects/ReferenceT.h
Note that the undocumented helper functions in the IOBuffer.cpp and Md5Encrypt.cpp files are not considered errors (as they are not a public interface).
Remark
The documentation of DataSourceI has to be revisited.
Remark
The SquareRoot template methods for float32 and float64 need to be provided.
template<typename Type>
inline Type SquareRoot(const Type x) {
Type tmp = x;
if (tmp < (Type) 0) {
REPORT_ERROR_STATIC_0(ErrorManagement::Warning, "SquareRoot<Type> of negative number");
tmp *= -1;
}
return sqrt(tmp);
}
It is only valid for Type being float64. In case of float32, there would be an implicit casting to satisfy the sqrt method. Two implementations shall be provided to call sqrt and sqrtf, as appropriate
Remark
The following classes have non-virtual destructors. As long they are not base classes of any derived class, it is safe, but they need to be monitored (flexlint will check and signal this as error code 1509).
Matrix, Vector, GlobalObjectsDatabase, LoadableLibrary, MemoryArea, StaticListHolder, CharBuffer, AnyTypeCreator, LexicalAnalyzer, Token, TokenInfo, Directory, MutexSem, ThreadInformation.
Unit test review¶
Date of the review: 09/04/2019
Person who did the review: André Neto
Version of unit tests: 1.0.0
Result of coverage tests review: PASS
Result of functional tests review: PASS
Result of review: PASS
List of non-conformities:
LCOV report (files containing functions not executed at all):
Note: execute with
lcov -l Build/MARTe2.coverage.infoand compare with the latest master release using tkdiff.
Files containing functions with coverage < 90% or which have changed w.r.t. to last master release. Exclamation marks inform of differences w.r.t. to the last master.:_
1 |Lines |Functions|Branches 1 |Lines |Functions|Branches
2 Filename |Rate Num|Rate Num|Rate Num 2 Filename |Rate Num|Rate Num|Rate Num
3 ================================================================================ 3 ================================================================================
35 L1Portability/Environm...Linux/BasicConsole.cpp|79.4% 223|76.2% 42| - 0 38 L1Portability/Environm...Linux/BasicConsole.cpp|79.4% 223|76.2% 42| - 0
43 ! L1Portability/Environm...x/StandardHeap_Gen.cpp|91.9% 74|91.7% 12| - 0 46 ! L1Portability/Environm...x/StandardHeap_Gen.cpp|93.2% 74|91.7% 12| - 0
45 ! L1Portability/Environm...ingHelper_CLIB_Gen.cpp| 100% 95| 100% 15| - 0 48 ! L1Portability/Environm...ingHelper_CLIB_Gen.cpp|99.1% 106| 100% 16| - 0
51 L1Portability/FastResourceContainer.cpp |83.5% 97|71.4% 7| - 0 54 L1Portability/FastResourceContainer.cpp |83.5% 97|71.4% 7| - 0
53 ! L1Portability/FormatDescriptor.h | 100% 49| 100% 4| - 0 56 ! L1Portability/FormatDescriptor.h |92.9% 56| 100% 4| - 0
80 ! L2Objects/ClassMethodCallerT.h |95.3% 215|81.4% 715| - 0 84 ! L2Objects/ClassMethodCallerT.h |95.3% 215|81.0% 727| - 0
82 ! L2Objects/ClassMethodInterfaceMapper.h | 100% 78| 100% 448| - 0 86 ! L2Objects/ClassMethodInterfaceMapper.h | 100% 78| 100% 450| - 0
86 ! L2Objects/ClassRegistryItemT.h | 100% 11| 100% 180| - 0 90 ! L2Objects/ClassRegistryItemT.h | 100% 11| 100% 198| - 0
87 L2Objects/Introspection.cpp |73.3% 15|85.7% 7| - 0 91 L2Objects/Introspection.cpp |73.3% 15|85.7% 7| - 0
88 L2Objects/IntrospectionEntry.cpp |87.3% 102|93.3% 15| - 0 92 L2Objects/IntrospectionEntry.cpp |87.3% 102|93.3% 15| - 0
91 ! L2Objects/Object.cpp |88.8% 250|96.8% 31| - 0 95 ! L2Objects/Object.cpp |88.5% 253|96.8% 31| - 0
93 ! L2Objects/ObjectBuilderT.h | 100% 8|68.6% 636| - 0 97 ! L2Objects/ObjectBuilderT.h | 100% 8|68.9% 708| - 0
97 ! L2Objects/ReferenceContainer.cpp |94.1% 305| 100% 38| - 0 101 ! L2Objects/ReferenceContainer.cpp |93.9% 280| 100% 37| - 0
100 L2Objects/ReferenceCon...erFilterReferences.cpp|84.6% 13| 100% 5| - 0 105 L2Objects/ReferenceCon...erFilterReferences.cpp|84.6% 13| 100% 5| - 0
104 ! L2Objects/ReferenceT.h |94.2% 86|67.8% 1k| - 0 109 ! L2Objects/ReferenceT.h |94.2% 86|67.4% 1k| - 0
107 ! L3Streams/BufferedStreamGenerator.h | 100% 43|84.1% 69| - 0 113 ! L3Streams/BufferedStreamGenerator.h | 100% 43|88.4% 69| - 0
108 ! L3Streams/BufferedStreamI.cpp |96.9% 64|80.0% 15| - 0 114 ! L3Streams/BufferedStreamI.cpp |97.4% 78|82.4% 17| - 0
109 ! L3Streams/BufferedStreamI.h | 100% 19| 100% 6| - 0 115 ! L3Streams/BufferedStreamI.h |83.8% 37| 100% 10| - 0
110 ! L3Streams/BufferedStreamIOBuffer.cpp |86.0% 50| 100% 8| - 0 116 ! L3Streams/BufferedStreamIOBuffer.cpp |90.6% 64| 100% 10| - 0
111 ! L3Streams/BufferedStreamIOBuffer.h | 100% 12|85.7% 7| - 0 117 ! L3Streams/BufferedStreamIOBuffer.h | 100% 8|80.0% 5| - 0
114 ! L3Streams/DoubleBufferedStream.cpp |82.7% 110|84.0% 25| - 0 120 ! L3Streams/DoubleBufferedStream.cpp |84.9% 119|84.0% 25| - 0
115 ! L3Streams/DoubleBufferedStream.h | 100% 5| 100% 1| - 0 121 ! L3Streams/IOBuffer.cpp |95.0% 920|97.7% 44| - 0
116 ! L3Streams/IOBuffer.cpp |95.1% 669|96.7% 30| - 0 !
118 L3Streams/IOBufferFloatPrint.cpp |84.5% 464| 100% 29| - 0 123 L3Streams/IOBufferFloatPrint.cpp |84.5% 464| 100% 29| - 0
119 ! L3Streams/IOBufferIntegerPrint.cpp |85.2% 460|93.5% 93| - 0 124 ! L3Streams/IOBufferIntegerPrint.cpp |85.5% 454|93.5% 93| - 0
! 125 ! L3Streams/IOBufferJsonPrint.cpp | 100% 32| 100% 13| - 0
! 126 ! L3Streams/IOBufferStandardPrint.cpp | 100% 21| 100% 9| - 0
! 127 ! L3Streams/IOBufferXMLPrint.cpp | 100% 25| 100% 12| - 0
! 128 ! L3Streams/JsonPrinter.cpp | 100% 49|95.2% 21| - 0
121 ! L3Streams/SingleBufferedStream.cpp |84.1% 176|83.3% 24| - 0 130 ! L3Streams/PrinterI.cpp | 100% 17|88.9% 9| - 0
! 131 ! L3Streams/ReferenceContainer.cpp |92.0% 25| 100% 3| - 0
! 132 ! L3Streams/SingleBufferedStream.cpp |84.9% 185|83.3% 24| - 0
! 140 ! L3Streams/StreamStructuredData.cpp | 100% 9| 100% 5| - 0
! 141 ! L3Streams/StreamStructuredData.h |98.8% 254|67.7% 62| - 0
! 142 ! L3Streams/StreamStructuredDataI.cpp | 100% 12|85.7% 7| - 0
! 143 ! L3Streams/XMLPrinter.cpp |93.9% 33|89.5% 19| - 0
133 ! L4Configuration/IntrospectionStructure.cpp |93.8% 146| 100% 14| - 0 149 ! L4Configuration/IntrospectionStructure.cpp |95.5% 266| 100% 16| - 0
164 + L4HttpService/HttpDefinition.cpp | 100% 40| 100% 5| - 0
165 + L4HttpService/HttpDefinition.h | 100% 40| 100% 3| - 0
166 + L4HttpService/HttpRealmI.cpp | 100% 5|80.0% 5| - 0
191 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/FileSystem/L1Portability/Environment/Linux/] 210 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/FileSystem/L1Portability/Environment/Linux/]
192 BasicFile.cpp |87.8% 278|93.9% 33| - 0 211 BasicFile.cpp |87.8%
194 BasicSocket.cpp |92.2% 51|82.4% 17| - 0 213 BasicSocket.cpp |92.2% 51|82.4% 17| - 0
195 ! BasicTCPSocket.cpp |85.5% 234| 100% 25| - 0 214 ! BasicTCPSocket.cpp |88.2% 238| 100% 25| - 0
197 Directory.cpp |62.5% 80|80.0% 15| - 0 216 Directory.cpp |62.5% 80|80.0% 15| - 0
203 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/FileSystem/L3Streams/] 222 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/FileSystem/L3Streams/]
204 File.cpp |71.4% 7|57.1% 7| - 0 223 File.cpp |71.4% 7|57.1% 7| - 0
208 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/FileSystem/L4LoggerService/] 227 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/FileSystem/L4HttpService/]
! 228 ! HttpChunkedStream.cpp |97.2% 36|81.8% 11| - 0
! 229 ! HttpClient.cpp |97.2% 248|95.2% 21| - 0
! 230 ! HttpDataExportI.cpp | 100% 44|87.5% 8| - 0
! 231 ! HttpDirectoryResource.cpp |97.0% 134| 100% 15| - 0
! 232 ! HttpMessageInterface.cpp |96.5% 57| 100% 13| - 0
! 233 ! HttpObjectBrowser.cpp |92.1% 203| 100% 16| - 0
! 234 ! HttpProtocol.cpp |95.2% 539|96.3% 27| - 0
! 235 ! HttpService.cpp |95.3% 148| 100% 16| - 0
! 236 !
! 237 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/FileSystem/L4LoggerService/]
214 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/Scheduler/L1Portability/Environment/Linux/] 243 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/Scheduler/L1Portability/Environment/Linux/]
215 EventSem.cpp |87.2% 141| 100% 15| - 0 244 EventSem.cpp |87.2% 141| 100% 15| - 0
216 MutexSem.cpp |86.8% 121| 100% 13| - 0 245 MutexSem.cpp |86.8% 121| 100% 13| - 0
222 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/Scheduler/L1Portability/] 251 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/Scheduler/L1Portability/]
223 ExceptionHandler.h | 0.0% 2| 0.0% 2| - 0 252 ExceptionHandler.h | 0.0% 2| 0.0% 2| - 0
224 253
225 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/Scheduler/L3Services/] 254 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/Scheduler/L3Services/]
235 ! MultiClientService.cpp |99.1% 112|94.1% 17| - 0 264 ! MultiClientService.cpp |99.1% 117|94.1% 17| - 0
236 ! MultiClientService.h | 100% 7| 100% 4| - 0 265 ! MultiClientService.h | 100% 7| 100% 5| - 0
237 ! MultiThreadService.cpp |95.3% 340| 100% 25| - 0 266 ! MultiThreadService.cpp |95.3% 343| 100% 25| - 0
238 ! SingleThreadService.cpp |91.3% 46|92.3% 13| - 0 267 ! SingleThreadService.cpp |91.5% 47|92.3% 13| - 0
! 268 ! ThreadsInformationQuery.cpp |97.3% 37|70.0% 10| - 0
239 269
245 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/Scheduler/L4Messages/] 275 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/Scheduler/L4Messages/]
246 ! QueuedMessageI.cpp |95.9% 49|90.0% 10| - 0 276 ! QueuedMessageI.cpp |90.7% 54|90.0% 10| - 0
247 QueuedReplyMessageCatcherFilter.cpp |97.8% 45| 100% 12| - 0 277 QueuedReplyMessageCatcherFilter.cpp |97.8% 45| 100% 12| - 0
248 QueueingMessageFilter.cpp |93.2% 44| 100% 7| - 0 278 QueueingMessageFilter.cpp |93.2% 44| 100% 7| - 0
249 279
250 ! [/home/aneto/Projects/MARTe2-dev-master/Source/Core/Scheduler/L4StateMachine/] 280 ! [/home/aneto/Projects/MARTe2-dev/Source/Core/Scheduler/L4StateMachine/]
251 ! StateMachine.cpp |93.1% 175| 100% 15| - 0 281 ! StateMachine.cpp |93.4% 183| 100% 16| - 0
252 StateMachineEvent.cpp |98.0% 50| 100% 15| - 0 282 StateMachineEvent.cpp |98.0% 50| 100% 15| - 0
258 ! MemoryMapAsyncTriggerOutputBroker.cpp |93.8% 257| 100% 20| - 0 288 ! MemoryMapAsyncTriggerOutputBroker.cpp |94.6% 257| 100% 20| - 0
274 ================================================================================ 304 ================================================================================
275 ! Total:|94.1% 21045|87.7% 7k| - 0 305 ! Total:|94.2% 24015|87.3% 8k| - 0
GTest report
[----------] Global test environment tear-down [==========] 4261 tests from 175 test cases ran. (292731 ms total) [ PASSED ] 4261 tests.
Integration test review¶
Date of the review: 09/04/2019
Person who did the review: André Neto
Version of integration tests: 1.0.0
Result of review: N/A
List of non-conformities: N/A
Comments: Not performed.
Acceptance test review¶
Date of the review: 09/04/2019
Person who did the review: André Neto
Version of acceptance tests: 1.0.0
Result of review: N/A
List of non-conformities: N/A
Comments: Not performed.
History
#1 Updated by André Neto almost 6 years ago
- Description updated (diff)
#2 Updated by André Neto almost 6 years ago
- Description updated (diff)
#3 Updated by André Neto almost 6 years ago
- Description updated (diff)