DESCRIBE CHANGES TODO

General

Information

The following files were detected as changed between branches #620_LoggerDataSource_Merge and develop
EclipseLcov.sh
Source/Components/DataSources/LoggerDataSource/LoggerBroker.cpp
Source/Components/DataSources/LoggerDataSource/LoggerBroker.h
Source/Components/DataSources/LoggerDataSource/LoggerDataSource.cpp
Source/Components/DataSources/LoggerDataSource/LoggerDataSource.h
Test/Components/DataSources/LoggerDataSource/LoggerBrokerTest.cpp

OK: no errors found.

Requirements review¶

Date of the review: 10/11/2020

Person who did the review: TODO

Version of requirements: TODO

Result of review: TODO

List of non-conformities: TODO

Comments: TODO

Architecture & design review¶

Date of the review: 10/11/2020

Person who did the review: TODO

Version of architecture & design document: TODO

Result of review: TODO

List of non-conformities: TODO

Comments: TODO

Code and documentation review¶

Date of the review: 10/11/2020

Person who did the review: TODO

Version of source code: 9facb4973f9137474a08e1acea35ea119144d3d7

Result of review: TODO

List of non-conformities:

Run flexelint and report TODO

Headers

OK: All headers are correctly formatted
OK: no errors found.

Lint includes

OK: All files are being included for linting
OK: no errors found.

Linter

ERR: /home/aneto/MARTe2-dev/MakeDefaults/Lint/marte_flint_exceptions.lnt 15
ERR: ./Source/Components/DataSources/EPICSPVA/EPICSPVAOutput.cpp:216:1: Info 766: Header file '/home/aneto/MARTe2-dev/Source/Core/Scheduler/L5GAMs/MemoryMapAsyncOutputBroker.h' not used in module 'EPICSPVAOutput.cpp'
ERR: Note 974: Worst case function for stack usage: 'MARTe::MDSStructuredDataI::Copy' is recursive, loop contains call to 'MARTe::MDSStructuredDataI::Copy'. See stack for a full report. [MISRA C+ Rule 7-5-4]

Doxygen

ERR: warning: Tag `XML_SCHEMA' at line 1788 of file `Doxyfile' has become obsolete.
ERR: warning: Tag `XML_DTD' at line 1794 of file `Doxyfile' has become obsolete.
ERR: warning: source ./Docs/Assets/Snippets/Parsing/MathGrammar.ll is not a readable file or directory... skipping.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:45: warning: Compound OPCUA::NodeProperties is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:60: warning: Compound OPCUA::ObjectProperties is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:354: warning: Member EPICSPVAStructureDataI::ReadArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value) (function) of namespace MARTe is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:417: warning: Member EPICSPVAStructureDataI::WriteArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value, const uint32 &size) (function) of namespace MARTe is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:54: warning: Member OPCUANodeSettings (typedef) of namespace OPCUA is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:68: warning: Member OPCUAObjectSettings (typedef) of namespace OPCUA is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/LoggerDataSource/LoggerBroker.h:76: warning: Member SetPeriod(const uint32 cyclePeriodIn) (function) of class MARTe::LoggerBroker is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/LoggerDataSource/LoggerDataSource.h:68: warning: Member Initialise(StructuredDataI &data) (function) of class MARTe::LoggerDataSource is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:90: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath)
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:95: warning: The following parameters of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented:
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:79: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath)
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:84: warning: The following parameters of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented:
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:129: warning: The following parameters of MARTe::SimulinkDataI::PrintData(const uint64 maxNameLength=0u, StreamString additionalText="") are not documented:
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:273: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:277: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:278: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:273: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:277: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:278: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:273: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:277: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:278: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:294: warning: explicit link request to 'offsetBasedSize' could not be resolved
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:46: warning: Member attr (variable) of class OPCUA::NodeProperties is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:47: warning: Member value (variable) of class OPCUA::NodeProperties is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:48: warning: Member nodeId (variable) of class OPCUA::NodeProperties is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:49: warning: Member nodeName (variable) of class OPCUA::NodeProperties is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:50: warning: Member parentNodeId (variable) of class OPCUA::NodeProperties is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:51: warning: Member parentReferenceNodeId (variable) of class OPCUA::NodeProperties is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:61: warning: Member attr (variable) of class OPCUA::ObjectProperties is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:62: warning: Member nodeId (variable) of class OPCUA::ObjectProperties is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:63: warning: Member nodeName (variable) of class OPCUA::ObjectProperties is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:64: warning: Member parentNodeId (variable) of class OPCUA::ObjectProperties is not documented.
ERR: /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:65: warning: Member parentReferenceNodeId (variable) of class OPCUA::ObjectProperties is not documented.

Unit test review¶

Date of the review: 10/11/2020

Person who did the review: TODO

Version of source code: 9facb4973f9137474a08e1acea35ea119144d3d7

Result of coverage tests review: TODO

Result of functional tests review: TODO

Result of review: TODO

Comments: TODO

List of non-conformities:

Functional tests

ERR: LoggerBroker:SetPeriod is not tested
ERR: LoggerDataSource:Initialise is not tested

GTest

WARN: Number of errors has not changed (but there are still errors). Number of tests: 1843. Current branch: 10. Reference branch: 10
OK: Number of tests unchanged. Current branch: 1843. Reference branch: 1843

Coverage

OK: No coverage errors found
OK: no errors found.

Integration test review¶

Date of the review: 10/11/2020

Person who did the review: TODO

Version of source code: 9facb4973f9137474a08e1acea35ea119144d3d7

Result of review: N/A

List of non-conformities: N/A

Comments: N/A

Acceptance test review¶

Date of the review: 10/11/2020

Person who did the review: TODO

Version of source code: 9facb4973f9137474a08e1acea35ea119144d3d7

Result of review: N/A

List of non-conformities: N/A

Comments: N/A