User story #159
Updated by Ivan Herrero over 9 years ago
Verify and implement coding standard using Flexelint.
h1. Source code files modified
* Source/Core/L0Portability/StringPortable.cpp Source/Core/L0Portability/BasicConsole.h
* Source/Core/L0Portability/StringPortable.h
* Test/Core/L0Portability/StringPortableTest.cpp
* Test/Core/L0Portability/StringPortableTest.h
* Test/GTest/StringPortableGTest.cpp Source/Core/L0Portability/OperatingSystem/Linux/BasicConsoleOS.cpp
h1. Architecture & design review
*Date of the review:* 22/07/2015
*Person who did the review:* Ivan Herrero
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 24/07/2015
*Person who did the review:* Llorenç Capellà
*Result of review:* PASS (MISRA)
*List of non-conformities:* N/A
h1. Unit test review
*Date of the review:* 27/07/2015
*Person who did the review:* Ivan Herrero
*Result of coverage tests review:* PASS
*Result of functional tests review:* PASS
*Result of review:* PASS
*List of non-conformities:*
Coverage Note: Some errors paths not exercised.
h1. Source code files modified
* Source/Core/L0Portability/StringPortable.cpp Source/Core/L0Portability/BasicConsole.h
* Source/Core/L0Portability/StringPortable.h
* Test/Core/L0Portability/StringPortableTest.cpp
* Test/Core/L0Portability/StringPortableTest.h
* Test/GTest/StringPortableGTest.cpp Source/Core/L0Portability/OperatingSystem/Linux/BasicConsoleOS.cpp
h1. Architecture & design review
*Date of the review:* 22/07/2015
*Person who did the review:* Ivan Herrero
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 24/07/2015
*Person who did the review:* Llorenç Capellà
*Result of review:* PASS (MISRA)
*List of non-conformities:* N/A
h1. Unit test review
*Date of the review:* 27/07/2015
*Person who did the review:* Ivan Herrero
*Result of coverage tests review:* PASS
*Result of functional tests review:* PASS
*Result of review:* PASS
*List of non-conformities:*
Coverage Note: Some errors paths not exercised.