User story #179
Updated by André Neto over 9 years ago
Solve the list of non-conformities found in #152:
The following functions test more than one thing and shall be broken down into different functions. This has no impact on the coverage/functional aspects of the test, but will greatly increase readability of the tests and in case of problems will greatly simplify the identification of the culprit :
MemoryTest::TestRealloc()
MemoryTest::TestCopy()
MemoryTest::TestMove()
MemoryTest::TestSet()
MemoryTest::TestSearch()
h1. Source code files modified
* Test/Core/L0Portability/MemoryTest.cpp
* Test/Core/L0Portability/MemoryTest.h
h1. Architecture & design review
*Date of the review:* as per #152.
*Person who did the review:* N/A
*Version of architecture & design document:* N/A
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* as per #152.
*Person who did the review:*
*Result of review:*
*List of non-conformities:* N/A.
h1. Unit test review
*Date of the review:* 11/08/2015
*Person who did the review:* Andre' Neto
*Result of coverage tests review:* PASS
*Result of functional tests review:* PASS
*Result of review:* PASS
*List of non-conformities:*
Note: I have made some minor changes to the documentation of the tests.
The following functions test more than one thing and shall be broken down into different functions. This has no impact on the coverage/functional aspects of the test, but will greatly increase readability of the tests and in case of problems will greatly simplify the identification of the culprit :
MemoryTest::TestRealloc()
MemoryTest::TestCopy()
MemoryTest::TestMove()
MemoryTest::TestSet()
MemoryTest::TestSearch()
h1. Source code files modified
* Test/Core/L0Portability/MemoryTest.cpp
* Test/Core/L0Portability/MemoryTest.h
h1. Architecture & design review
*Date of the review:* as per #152.
*Person who did the review:* N/A
*Version of architecture & design document:* N/A
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* as per #152.
*Person who did the review:*
*Result of review:*
*List of non-conformities:* N/A.
h1. Unit test review
*Date of the review:* 11/08/2015
*Person who did the review:* Andre' Neto
*Result of coverage tests review:* PASS
*Result of functional tests review:* PASS
*Result of review:* PASS
*List of non-conformities:*
Note: I have made some minor changes to the documentation of the tests.