MARTe2 » MARTe2-core

Verify and implement coding standard using Flexelint.

h1. Source code files modified

* Source/Core/L0Portability/Memory.cpp (deleted)
* Source/Core/L0Portability/Memory.h
* Source/Core/L0Portability/OperatingSystem/Linux/MemoryOS.h (deleted)
* Source/Core/L0Portability/OperatingSystem/Windows/MemoryOS.h (deleted)
* Source/Core/L0Portability/OperatingSystem/Linux/MemoryOS.cpp
* Source/Core/L0Portability/OperatingSystem/Windows/MemoryOS.cpp
* Test/Core/L0Portability/MemoryTest.cpp
* Test/Core/L0Portability/MemoryTest.h
* Test/Core/L0Portability/ThreadInformation.cpp
* Test/Core/L0Portability/ThreadDatabase.cpp
* Test/GTest/MemoryGTest.cpp

h1. Architecture & design review

*Date of the review:* 29/07/2015

*Person who did the review:* Andre Neto

*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

*Result of review:* N/A

*List of non-conformities:* N/A

h1. Code and documentation review

*Date of the review:* 29/07/2015

*Person who did the review:* Andre Neto

*Result of review:* PASS (MISRA compliant)

*List of non-conformities:* N/A (I have made some minor cosmetic changes to the documentation).

h1. Unit test review

*Date of the review:* 29/07/2015

*Person who did the review:* Andre' Neto

*Result of coverage tests review:* PASS

*Result of functional tests review:* PASS

*Result of review:* FAIL (but OK for release. See notes below).

*List of non-conformities:*
The following functions test more than one thing and shall be broken down into different functions. This has no impact on the coverage/functional aspects of the test, but will greatly increase readability of the tests and in case of problems will greatly simplify the identification of the culprit :
* MemoryTest::TestRealloc()
* MemoryTest::TestCopy()
* MemoryTest::TestMove()
* MemoryTest::TestSet()
* MemoryTest::TestSearch()
See #179.