MARTe2 » MARTe2-core

Refactor v0.2 code which relied in class static const member variables to define defines constants.
The original idea was to use this strategy as a way to impose a namespace. The downside of this is that it can give rise to static initialisation order problems (e.g. if these are used in the constructor of static objects). Moreover these symbols will also have to be exported which in some embedded systems might give rise to performance problems.
It was agreed that these variables will be replaced by static const in the header files and put inside an equivalent namespace name.

h1. Source code files modified

* Source/Core/L0Portability/BasicConsole.h
* Source/Core/L0Portability/OperatingSystem/Linux/BasicConsoleOS.cpp
* Source/Core/L0Portability/OperatingSystem/Windows/BasicConsoleOS.cpp

h1. Architecture & design review

*Date of the review:* as per #142.

*Person who did the review:* N/A

*Version of architecture & design document:* N/A

*Result of review:* N/A

*List of non-conformities:* N/A

h1. Code and documentation review

*Date of the review:* 20/08/2015. 12/08/2015.

*Person who did the review:* Andre' Neto

*Result of review:* FAIL

*List of non-conformities:*

* static const in FastMath ProcessorType UndefinedCPUs must also be refactored;

h1. Unit test review

*Date of the review:* ../../2015

*Person who did the review:*

*Result of coverage tests review:*

*Result of functional tests review:*

*Result of review:*

*List of non-conformities:*