User story #203
Updated by Ivan Herrero over 9 years ago
h1. Source code files modified
Source/Core/L0TypeDev/FormatDescriptor.h
Source/Core/L0TypeDev/FormatDescriptor.cpp
h1. Architecture & design review
As per the original MARTe implementation, this is a support function and does not require formal design in UML.
h1. Code and documentation review
*Date of the review:* 04/09/2015 03/09/2015
*Person who did the review:* Ivan Herrero
*Result of review:* PASS FAIL
*List of non-conformities:* N/A
Source/Core/L0TypeDev/FormatDescriptor.h:
* It lacks documentation for -FloatNotation-, defaultPrecision, and spareBits.
* Some class members have questions on their documentation, like desiredAction.
* Some namespace members have questions on their documentation, like DesiredAction.
Source/Core/L0TypeDev/FormatDescriptor.cpp:
* Static constants and functions must go to the static section.
h1. Unit test review
*Date of the review:* --/--/2015
*Person who did the review:* -----
*Result of coverage tests review:* [PASS/FAIL]
*Result of functional tests review:* [PASS/FAIL]
*Result of review:* [PASS/FAIL]
*List of non-conformities:*
Source/Core/L0TypeDev/FormatDescriptor.h
Source/Core/L0TypeDev/FormatDescriptor.cpp
h1. Architecture & design review
As per the original MARTe implementation, this is a support function and does not require formal design in UML.
h1. Code and documentation review
*Date of the review:* 04/09/2015 03/09/2015
*Person who did the review:* Ivan Herrero
*Result of review:* PASS FAIL
*List of non-conformities:* N/A
Source/Core/L0TypeDev/FormatDescriptor.h:
* It lacks documentation for -FloatNotation-, defaultPrecision, and spareBits.
* Some class members have questions on their documentation, like desiredAction.
* Some namespace members have questions on their documentation, like DesiredAction.
Source/Core/L0TypeDev/FormatDescriptor.cpp:
* Static constants and functions must go to the static section.
h1. Unit test review
*Date of the review:* --/--/2015
*Person who did the review:* -----
*Result of coverage tests review:* [PASS/FAIL]
*Result of functional tests review:* [PASS/FAIL]
*Result of review:* [PASS/FAIL]
*List of non-conformities:*