User story #204
Updated by Ivan Herrero over 9 years ago
h1. Source code files modified
Source/Core/TypeDescriptor.h
h1. Architecture & design review
As per the original MARTe implementation, this is a support function and does not require formal design in UML.
h1. Code and documentation review
*Date of the review:* 04/09/2015
*Person who did the review:* Ivan Herrero
*Result of review:* PASS
*List of non-conformities:* N/A
*Note:* Arguments of some constructors use the suffix "In" (e.g. isConstantIn). If not, we could write assigments to class attributes using "this" (e.g. this->isConstant = isConstant).
h1. Unit test review
*Date of the review:* 07/09/2015
*Person who did the review:* Ivan Herrero
*Result of coverage tests review:* PASS
*Result of functional tests review:* PASS
*Result of review:* PASS
*List of non-conformities:* N/A
Source/Core/TypeDescriptor.h
h1. Architecture & design review
As per the original MARTe implementation, this is a support function and does not require formal design in UML.
h1. Code and documentation review
*Date of the review:* 04/09/2015
*Person who did the review:* Ivan Herrero
*Result of review:* PASS
*List of non-conformities:* N/A
*Note:* Arguments of some constructors use the suffix "In" (e.g. isConstantIn). If not, we could write assigments to class attributes using "this" (e.g. this->isConstant = isConstant).
h1. Unit test review
*Date of the review:* 07/09/2015
*Person who did the review:* Ivan Herrero
*Result of coverage tests review:* PASS
*Result of functional tests review:* PASS
*Result of review:* PASS
*List of non-conformities:* N/A