MARTe2 » MARTe2-core

Refactor the ClassRegistryDatabase so that each registered class gets a unique identifier.

The implementation shall offer a search facility, by unique identifier, which allows to quickly retrieve a registered class (i.e. without having to walk all the list).

Tasks:
# Develop a new list class StaticListHolder
# Refactor the implementation of ClassRegistryDatabase (use StaticListHolder instead of LinkedListHolder as internal class database)

h1. Source code files modified

* Source/Core/BareMetal/L1Portability/StaticList.cpp
* Source/Core/BareMetal/L1Portability/StaticList.h
* Source/Core/BareMetal/L1Portability/StaticListHolder.cpp
* Source/Core/BareMetal/L1Portability/StaticListHolder.h
* Source/Core/BareMetal/L1Portability/GlobalObjectI.cpp
* Source/Core/BareMetal/L1Portability/GlobalObjectI.h
* Source/Core/BareMetal/L1Portability/GlobalObjectsDatabase.cpp
* Source/Core/BareMetal/L1Portability/GlobalObjectsDatabase.h
* Source/Core/BareMetal/L1Portability/HeapManager.cpp
* Source/Core/BareMetal/L1Portability/HeapManager.h
* Source/Core/BareMetal/L2Objects/ClassRegistryDatabase.cpp
* Source/Core/BareMetal/L2Objects/ClassRegistryDatabase.h

* Test/Core/BareMetal/L1Portability/StaticListTest.cpp
* Test/Core/BareMetal/L1Portability/StaticListTest.h
* Test/Core/BareMetal/L1Portability/GlobalObjectsDatabaseTest.cpp
* Test/Core/BareMetal/L1Portability/GlobalObjectsDatabaseTest.h
* Test/Core/BareMetal/L2Objects/ClassRegistryDatabaseTest.cpp
* Test/Core/BareMetal/L2Objects/ClassRegistryDatabaseTest.h

* Test/GTest/StaticListGTest.cpp
* Test/GTest/GlobalObjectsDatabaseGTest.cpp

h1. Architecture & design review

*Date of the review:* 08/09/2015

*Person who did the review:* Andre' Neto

*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

*Result of review:* N/A

*List of non-conformities:* N/A

h1. Code and documentation review

*Date of the review:* 28/09/2015

*Person who did the review:* Ivan Herrero

*Result of review:* PASS

* In the StaticListHolder.h documentation, the formula MAXCAPACITY cannot be visualized with doxygen tool.
* Maybe a glossary of acronyms is needed.
* GlobalObjectI is not an pure interface because the new operator is static and has an implementation.

*List of non-conformities:* N/A.

h1. Unit test review

*Date of the review:* 28/09/2015

*Person who did the review:* Ivan Herrero

*Result of coverage tests review:* PASS

*Result of functional tests review:* PASS

*Result of review:* PASS

* TestAddOnFullList disabled due to it takes a quiet significant amount of time.
* The coverage is not 100% due to some conditions will never should happen.
* GlobalObjectsDatabaseTest lacks an explicit test for GlobalObjectsDatabase::Add, but it is covered indirectly by another tests.
* GlobalObjectI has not a 100% coverage because the compiler generates two versions of the destructor (one for delete and the other for scope).
* ClassRegistryDatabase has 11.9% lines not covered (this is was accepted on another user story review).

*List of non-conformities:* N/A