Design #231
Updated by Ivan Herrero over 9 years ago
h1. Requirements review
*Date of the review:* 29/09/2015
*Person who did the review:* Ivan Herrero
*Version of requirements:* 0.5
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal requirements.
h1. Architecture & design review
*Date of the review:* 29/09/2015
*Person who did the review:* Ivan Herrero
*Version of architecture & design document:* 0.5
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal design.
h1. Code and documentation review
*Date of the review:* 29/09/2015
*Person who did the review:* Ivan Herrero
*Version of source code:* 0.5
*Result of review:* PASS
*List of non-conformities:* N/A
*Notes:*
* In the StaticListHolder.h documentation, the formula MAXCAPACITY cannot be visualized with doxygen tool.
* GlobalObjectI is not an pure interface because the new operator is static and has an implementation.
h1. Unit test review
*Date of the review:* 29/09/2015
*Person who did the review:* Ivan Herrero
*Version of unit tests:* 0.5
*Result of coverage tests review:* PASS
*Result of functional tests review:* PASS
*Result of review:* PASS
*List of non-conformities:* N/A
*Notes:*
* TestAddOnFullList disabled due to it takes a quiet significant amount of time.
* The coverage on #225 is not 100% due to some conditions will never should happen.
* GlobalObjectsDatabaseTest lacks an explicit test for GlobalObjectsDatabase::Add, but it is covered indirectly by another tests.
* GlobalObjectI has not a 100% coverage because the compiler generates two versions of the destructor (one for delete and the other for scope).
* ClassRegistryDatabase has 11.9% lines not covered (this is was accepted on another user story review).
* The coverage of the ClassRegistryDatabase is not 100%
h1. Integration test review
*Date of the review:* 29/09/2015
*Person who did the review:* Ivan Herrero
*Version of integration tests:* 0.5
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal integration tests.
h1. Acceptance test review
*Date of the review:* 29/09/2015
*Person who did the review:* Ivan Herrero
*Version of acceptance tests:* 0.5
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal acceptance tests.
*Date of the review:* 29/09/2015
*Person who did the review:* Ivan Herrero
*Version of requirements:* 0.5
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal requirements.
h1. Architecture & design review
*Date of the review:* 29/09/2015
*Person who did the review:* Ivan Herrero
*Version of architecture & design document:* 0.5
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal design.
h1. Code and documentation review
*Date of the review:* 29/09/2015
*Person who did the review:* Ivan Herrero
*Version of source code:* 0.5
*Result of review:* PASS
*List of non-conformities:* N/A
*Notes:*
* In the StaticListHolder.h documentation, the formula MAXCAPACITY cannot be visualized with doxygen tool.
* GlobalObjectI is not an pure interface because the new operator is static and has an implementation.
h1. Unit test review
*Date of the review:* 29/09/2015
*Person who did the review:* Ivan Herrero
*Version of unit tests:* 0.5
*Result of coverage tests review:* PASS
*Result of functional tests review:* PASS
*Result of review:* PASS
*List of non-conformities:* N/A
*Notes:*
* TestAddOnFullList disabled due to it takes a quiet significant amount of time.
* The coverage on #225 is not 100% due to some conditions will never should happen.
* GlobalObjectsDatabaseTest lacks an explicit test for GlobalObjectsDatabase::Add, but it is covered indirectly by another tests.
* GlobalObjectI has not a 100% coverage because the compiler generates two versions of the destructor (one for delete and the other for scope).
* ClassRegistryDatabase has 11.9% lines not covered (this is was accepted on another user story review).
* The coverage of the ClassRegistryDatabase is not 100%
h1. Integration test review
*Date of the review:* 29/09/2015
*Person who did the review:* Ivan Herrero
*Version of integration tests:* 0.5
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal integration tests.
h1. Acceptance test review
*Date of the review:* 29/09/2015
*Person who did the review:* Ivan Herrero
*Version of acceptance tests:* 0.5
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal acceptance tests.