User story #240
Updated by Riccardo Vitelli over 9 years ago
https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2/blob/develop_svn/Source/Core/LXTypeDev/IOBufferIntegerPrint.h
Take special attention to macros, namespace, move to cpp, ...
h1. Source code files modified
IOBufferIntegerPrint.cpp
h1. Architecture & design review
*Date of the review:* 30/09/2015
*Person who did the review:* André Neto
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 21/10/2015 --/--/2015
*Person who did the review:* R. Vitelli
*Result of review:* PASS
*List of non-conformities:* N/A.
h1. Unit test review
*Date of the review:* 21/10/2015 --/--/2015
*Person who did the review:* R. Vitelli -----
*Result of coverage tests review:* PASS [PASS/FAIL]
*Result of functional tests review:* PASS [PASS/FAIL]
*Result of review:* PASS [PASS/FAIL]
*List of non-conformities:*
* The following functions have not been covered by tests:
* _ZN5MARTe28IntegerToStreamOctalNotationIiEEbRNS_8IOBufferET_tbbtb
* _ZN5MARTe28IntegerToStreamOctalNotationIsEEbRNS_8IOBufferET_tbbtb
* _ZN5MARTe29IntegerToStreamBinaryNotationIiEEbRNS_8IOBufferET_tbbtb
* _ZN5MARTeL30GetNumberOfDigitsOctalNotationIiEEtT_
* _ZN5MARTeL30GetNumberOfDigitsOctalNotationIsEEtT_
* _ZN5MARTeL31GetNumberOfDigitsBinaryNotationIiEEtT_
However those functions are generated to print (u)int64, which miss a component to be completed. The tests will be repeated after the completion of IOBufferIntegerPrint and the addition of DoubleInteger, next sprint.
Take special attention to macros, namespace, move to cpp, ...
h1. Source code files modified
IOBufferIntegerPrint.cpp
h1. Architecture & design review
*Date of the review:* 30/09/2015
*Person who did the review:* André Neto
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 21/10/2015 --/--/2015
*Person who did the review:* R. Vitelli
*Result of review:* PASS
*List of non-conformities:* N/A.
h1. Unit test review
*Date of the review:* 21/10/2015 --/--/2015
*Person who did the review:* R. Vitelli -----
*Result of coverage tests review:* PASS [PASS/FAIL]
*Result of functional tests review:* PASS [PASS/FAIL]
*Result of review:* PASS [PASS/FAIL]
*List of non-conformities:*
* The following functions have not been covered by tests:
* _ZN5MARTe28IntegerToStreamOctalNotationIiEEbRNS_8IOBufferET_tbbtb
* _ZN5MARTe28IntegerToStreamOctalNotationIsEEbRNS_8IOBufferET_tbbtb
* _ZN5MARTe29IntegerToStreamBinaryNotationIiEEbRNS_8IOBufferET_tbbtb
* _ZN5MARTeL30GetNumberOfDigitsOctalNotationIiEEtT_
* _ZN5MARTeL30GetNumberOfDigitsOctalNotationIsEEtT_
* _ZN5MARTeL31GetNumberOfDigitsBinaryNotationIiEEtT_
However those functions are generated to print (u)int64, which miss a component to be completed. The tests will be repeated after the completion of IOBufferIntegerPrint and the addition of DoubleInteger, next sprint.