MARTe2 » MARTe2-core

Finish the implementation of bit set for 64 bit integers.

h1. Source code files modified

BareMetal/L0Types/DoubleInteger.h
BareMetal/L0Types/Shift.h
BareMetal/L3Streams/IOBufferIntegerPrint.h

h1. Architecture & design review

*Date of the review:* 23/10/2015

*Person who did the review:* André Neto

*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

*Result of review:* N/A

*List of non-conformities:* N/A

h1. Code and documentation review

*Date of the review:* 27/10/2015

*Person who did the review:* R. Vitelli

*Result of review:* PASS

*List of non-conformities:*

To be verified:
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::DoubleInteger<<1>>::SetLower(<1>)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::DoubleInteger<<1>>::SetUpper(<1>)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::DoubleInteger<<1>>::operator&=(const MARTe::DoubleInteger<<1>> &)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::DoubleInteger<<1>>::operator+=(const MARTe::DoubleInteger<<1>> &)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::DoubleInteger<<1>>::operator-=(const MARTe::DoubleInteger<<1>> &)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::DoubleInteger<<1>>::operator<<=(unsigned short)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::DoubleInteger<<1>>::operator>>=(unsigned short)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::DoubleInteger<<1>>::operator|=(const MARTe::DoubleInteger<<1>> &)

N/A.

h1. Unit test review

*Date of the review:* 27/10/2015 --/--/2015

*Person who did the review:* R. Vitelli -----

*Result of coverage tests review:* PASS [PASS/FAIL]

*Result of functional tests review:* PASS [PASS/FAIL]

*Result of review:* PASS [PASS/FAIL]

*List of non-conformities:*

Few incarnations of the templated functions are not tested due to escessive nesting.