User story #251
Updated by Riccardo Vitelli over 9 years ago
h1. Source code files modified
* Source/Core/BareMetal/L3Streams/String.cpp
* Source/Core/BareMetal/L3Streams/String.h
* Source/Core/BareMetal/L3Streams/StringIOBuffer.cpp
* Source/Core/BareMetal/L3Streams/StringIOBuffer.h
* Test/Core/BareMetal/L3Streams/StringTest.cpp
* Test/Core/BareMetal/L3Streams/StringTest.h
* Test/Core/BareMetal/L3Streams/StringIOBufferTest.cpp
* Test/Core/BareMetal/L3Streams/StringIOBufferTest.h
The prefix "Stream" was dropped from all these files (on file name and class name).
h1. Architecture & design review
*Date of the review:* 23/10/2015
*Person who did the review:* André Neto
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 27/10/2015 26/10/2015
*Person who did the review:* R. Vitelli Ivan Herrero
*Result of review:* PASS FAIL
*List of non-conformities:*
* The string "StreamString" remains on comments of some source files.
* The string "StreamString" remains on comments of some test files.
* The string "StreamString" remains as suffix on some test names.
* The string "StreamString" remains as name of some local test variables.
h1. Unit test review
*Date of the review:* 27/10/2015 --/--/2015
*Person who did the review:* R. Vitelli -----
*Result of coverage tests review:* PASS [PASS/FAIL]
*Result of functional tests review:* PASS [PASS/FAIL]
*Result of review:* PASS [PASS/FAIL]
*List of non-conformities:*
* Source/Core/BareMetal/L3Streams/String.cpp
* Source/Core/BareMetal/L3Streams/String.h
* Source/Core/BareMetal/L3Streams/StringIOBuffer.cpp
* Source/Core/BareMetal/L3Streams/StringIOBuffer.h
* Test/Core/BareMetal/L3Streams/StringTest.cpp
* Test/Core/BareMetal/L3Streams/StringTest.h
* Test/Core/BareMetal/L3Streams/StringIOBufferTest.cpp
* Test/Core/BareMetal/L3Streams/StringIOBufferTest.h
The prefix "Stream" was dropped from all these files (on file name and class name).
h1. Architecture & design review
*Date of the review:* 23/10/2015
*Person who did the review:* André Neto
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 27/10/2015 26/10/2015
*Person who did the review:* R. Vitelli Ivan Herrero
*Result of review:* PASS FAIL
*List of non-conformities:*
* The string "StreamString" remains on comments of some source files.
* The string "StreamString" remains on comments of some test files.
* The string "StreamString" remains as suffix on some test names.
* The string "StreamString" remains as name of some local test variables.
h1. Unit test review
*Date of the review:* 27/10/2015 --/--/2015
*Person who did the review:* R. Vitelli -----
*Result of coverage tests review:* PASS [PASS/FAIL]
*Result of functional tests review:* PASS [PASS/FAIL]
*Result of review:* PASS [PASS/FAIL]
*List of non-conformities:*