MARTe2 » MARTe2-core

Implement the Linux UDP socket stream based on the previous MARTe implementation.

h1. Source code files modified
FileSystem/BasicSocket.h FileSystem/BasicUDPSocket.*
FileSystem/BasicUDPSocket.h
FileSystem/InternetHost.h
FileSystem/Environment/Linux/BasicSocket.cpp
FileSystem/Environment/Linux/BasicUDPSocket.cpp
FileSystem/Environment/Linux/InternetHost.cpp
FileSystem/Environment/Linux/SocketCore.h

h1. Architecture & design review

*Date of the review:* 23/10/2015

*Person who did the review:* André Neto

*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

*Result of review:* N/A

*List of non-conformities:* N/A

h1. Code and documentation review

*Date of the review:* 29/10/2015 --/--/2015

*Person who did the review:* André Neto



*Result of review:* FAIL



*List of non-conformities:* N/A.

./Source/Core/FileSystem/L1Portability/Environment/Linux/BasicSocket.cpp:92:1: Info 1762: Member function 'MARTe::BasicSocket::GetSource(void)' could be made const [MISRA C++ Rule 9-3-3]
./Source/Core/FileSystem/L1Portability/Environment/Linux/BasicSocket.cpp:96:1: Info 1762: Member function 'MARTe::BasicSocket::GetDestination(void)' could be made const [MISRA C++ Rule 9-3-3]
./Source/Core/FileSystem/L1Portability/Environment/Linux/BasicUDPSocket.cpp:113:41: Warning 641: Converting enum '__socket_type' to 'int'

h1. Unit test review

*Date of the review:* --/--/2015

*Person who did the review:* -----

*Result of coverage tests review:* [PASS/FAIL]

*Result of functional tests review:* [PASS/FAIL]

*Result of review:* [PASS/FAIL]

*List of non-conformities:*