Test #285
Updated by Ivan Herrero over 9 years ago
h1. Requirements review
*Date of the review:* 30/11/2015 --/--/----
*Person who did the review:* Ivan Herrero
*Version of requirements:* 0.8 0.9
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal requirements.
h1. Architecture & design review
*Date of the review:* 30/11/2015 --/--/----
*Person who did the review:* Ivan Herrero
*Version of architecture & design document:* 0.8 0.9
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal design.
h1. Code and documentation review
*Date of the review:* 30/11/2015 --/--/----
*Person who did the review:* Ivan Herrero
*Version of source code:* 0.8 0.9
*Result of review:* PASS [PASS|FAIL]
*List of non-conformities:*
[#253]
* There are several warnings that should be fixed in a dedicated user-stories.
* The following tests (already working for Linux) had to be commented: [N/A|list]
# BasicFileGTest.x
# InternetHostGTest.x
# InternetServiceGTest.x
# BasicSocketGTest.x
# BasicTCPSocketGTest.x
# BasicUDPSocketGTest.x
[#255] As a pattern DirectoryScanner should use LinkedListHolder and not inherit from it.
[#267] Merged with #268.
[#269] Merged with #268.
h1. Unit test review
*Date of the review:* 30/11/2015 --/--/----
*Person who did the review:* Ivan Herrero
*Version of unit tests:* 0.8 0.9
*Result of coverage tests review:* PASS [PASS|FAIL]
*Result of functional tests review:* PASS [PASS|FAIL]
*Result of review:* PASS [PASS|FAIL]
*List of non-conformities:*
[#243] Need to add an unit test to verify ALL possible combinations of opening flags [N/A|list]
[#244]
Note: some tests unrelated to this user-story are failing on Windows:
[ FAILED ] BufferedStreamIGTest.TestPrintFormatted_Pointer_BufferSize_1
[ FAILED ] BufferedStreamIGTest.TestPrintFormatted_Pointer_BufferSize_2
[ FAILED ] BufferedStreamIGTest.TestPrintFormatted_Pointer_BufferSize_8
[ FAILED ] BufferedStreamIGTest.TestPrintFormatted_Pointer_BufferSize_64
[ FAILED ] BufferedStreamIGTest.TestPrintFormatted_Pointer_BufferSize_128
[ FAILED ] BufferedStreamIGTest.TestPrintFormatted_Pointer_BufferSize_1024
[ FAILED ] IOBufferGTest.TestPrintFormatted_Pointer
[ FAILED ] IOBufferGTest.TestPrintFormattedMultiple
[#256] Coverage tests for structured data (still not implemented in MARTe) are missing. These should be added as soon as structured data is available.
[#267] Merged with #268.
[#269] Merged with #268.
[#271] The coverage reports that 13 of 14 functions have been executed, but the class Select has 11 functions and all have been executed.
h1. Integration test review
*Date of the review:* 30/11/2015 --/--/----
*Person who did the review:* Ivan Herrero
*Version of integration tests:* 0.8 0.9
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal integration tests.
h1. Acceptance test review
*Date of the review:* 30/11/2015 --/--/----
*Person who did the review:* Ivan Herrero
*Version of acceptance tests:* 0.8 0.9
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal acceptance tests.
*Date of the review:* 30/11/2015 --/--/----
*Person who did the review:* Ivan Herrero
*Version of requirements:* 0.8 0.9
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal requirements.
h1. Architecture & design review
*Date of the review:* 30/11/2015 --/--/----
*Person who did the review:* Ivan Herrero
*Version of architecture & design document:* 0.8 0.9
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal design.
h1. Code and documentation review
*Date of the review:* 30/11/2015 --/--/----
*Person who did the review:* Ivan Herrero
*Version of source code:* 0.8 0.9
*Result of review:* PASS [PASS|FAIL]
*List of non-conformities:*
[#253]
* There are several warnings that should be fixed in a dedicated user-stories.
* The following tests (already working for Linux) had to be commented: [N/A|list]
# BasicFileGTest.x
# InternetHostGTest.x
# InternetServiceGTest.x
# BasicSocketGTest.x
# BasicTCPSocketGTest.x
# BasicUDPSocketGTest.x
[#255] As a pattern DirectoryScanner should use LinkedListHolder and not inherit from it.
[#267] Merged with #268.
[#269] Merged with #268.
h1. Unit test review
*Date of the review:* 30/11/2015 --/--/----
*Person who did the review:* Ivan Herrero
*Version of unit tests:* 0.8 0.9
*Result of coverage tests review:* PASS [PASS|FAIL]
*Result of functional tests review:* PASS [PASS|FAIL]
*Result of review:* PASS [PASS|FAIL]
*List of non-conformities:*
[#243] Need to add an unit test to verify ALL possible combinations of opening flags [N/A|list]
[#244]
Note: some tests unrelated to this user-story are failing on Windows:
[ FAILED ] BufferedStreamIGTest.TestPrintFormatted_Pointer_BufferSize_1
[ FAILED ] BufferedStreamIGTest.TestPrintFormatted_Pointer_BufferSize_2
[ FAILED ] BufferedStreamIGTest.TestPrintFormatted_Pointer_BufferSize_8
[ FAILED ] BufferedStreamIGTest.TestPrintFormatted_Pointer_BufferSize_64
[ FAILED ] BufferedStreamIGTest.TestPrintFormatted_Pointer_BufferSize_128
[ FAILED ] BufferedStreamIGTest.TestPrintFormatted_Pointer_BufferSize_1024
[ FAILED ] IOBufferGTest.TestPrintFormatted_Pointer
[ FAILED ] IOBufferGTest.TestPrintFormattedMultiple
[#256] Coverage tests for structured data (still not implemented in MARTe) are missing. These should be added as soon as structured data is available.
[#267] Merged with #268.
[#269] Merged with #268.
[#271] The coverage reports that 13 of 14 functions have been executed, but the class Select has 11 functions and all have been executed.
h1. Integration test review
*Date of the review:* 30/11/2015 --/--/----
*Person who did the review:* Ivan Herrero
*Version of integration tests:* 0.8 0.9
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal integration tests.
h1. Acceptance test review
*Date of the review:* 30/11/2015 --/--/----
*Person who did the review:* Ivan Herrero
*Version of acceptance tests:* 0.8 0.9
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal acceptance tests.