User story #296
Updated by André Neto about 9 years ago
Update the GTest folder structure to align with the Source and Test structure.
h1. Source code files modified
(see on the commit message)
h1. Architecture & design review
*Date of the review:* 18/01/2016
*Person who did the review:* Andre' Neto
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 18/01/2016
*Person who did the review:* Andre' Neto
*Result of review:* FAIL
*List of non-conformities:*
Note that on branch #188 I have already solved some of these issues.
During Specific Walk:
File ./Source/Core/BareMetal/L3Streams/IOBufferIntegerPrint.cpp line 531: MARTe::BitSetToInteger(?, ?, ?, 8?, !=0) #1
File ./Source/Core/BareMetal/L3Streams/BitSetToInteger.h line 345: MARTe::BitSetToBitSet([1], 0, 8, 1, ?, ?, 8?, !=0) #2
File ./Source/Core/BareMetal/L3Streams/BitSetToInteger.h line 286: MARTe::BSToBS([1], 0, 8, 1, ?, 31? | 0?, 8?, !=0) #3
File ./Source/Core/BareMetal/L3Streams/BitSetToInteger.h line 105: MARTe::MemoryOperationsHelper::Copy([4], ?, 5?) #30
./Source/Core/BareMetal/L1Portability/Environment/Generic/MemoryOperationsHelper_CLIB_Generic.cpp:58:1: Warning 669: Possible data overrun for function 'memcpy(void *, const void *, unsigned long)', argument 3 (size=5) exceeds argument 1 (size=4)
./Source/Core/BareMetal/L3Streams/BitSetToInteger.h:101:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L3Streams/BitSetToInteger.h:105:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L3Streams/BitSetToInteger.h:227:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L3Streams/BitSetToInteger.h:242:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L3Streams/BitSetToInteger.h:286:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L3Streams/BitSetToInteger.h:345:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L3Streams/IOBufferIntegerPrint.cpp:528:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L3Streams/IOBufferIntegerPrint.cpp:531:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L4Configuration/ParserI.cpp:51:80: Note 9138: null statement not in line by itself [MISRA C++ Rule 6-2-3]
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:45:34: Error 14: Symbol 'MARTe::StringHelper::Length(const char *)' previously defined (line 150, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:150:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:62:34: Error 14: Symbol 'MARTe::StringHelper::Compare(const char *, const char *)' previously defined (line 94, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:94:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:96:29: Error 14: Symbol 'MARTe::StringHelper::CompareN(const char *, const char *, unsigned int)' previously defined (line 105, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:105:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:132:37: Error 14: Symbol 'MARTe::StringHelper::Concatenate(char *, const char *)' previously defined (line 62, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:62:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:153:32: Error 14: Symbol 'MARTe::StringHelper::ConcatenateN(char *, const char *, unsigned int)' previously defined (line 75, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:75:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:175:37: Error 14: Symbol 'MARTe::StringHelper::SearchChar(const char *, char)' previously defined (line 85, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:85:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:205:30: Error 14: Symbol 'MARTe::StringHelper::Copy(char *, const char *)' previously defined (line 117, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:117:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:219:25: Error 14: Symbol 'MARTe::StringHelper::CopyN(char *, const char *, unsigned int)' previously defined (line 130, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:130:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:232:38: Error 14: Symbol 'MARTe::StringHelper::SearchIndex(const char *, const char *)' previously defined (line 142, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:142:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:266:45: Error 14: Symbol 'MARTe::StringHelper::SearchChars(const char *, const char *)' previously defined (line 158, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:158:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:310:41: Error 14: Symbol 'MARTe::StringHelper::SearchLastChar(const char *, char)' previously defined (line 167, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:167:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:335:46: Error 14: Symbol 'MARTe::StringHelper::SearchString(const char *, const char *)' previously defined (line 176, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:176:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:363:26: Error 14: Symbol 'MARTe::StringHelper::SetChar(char *, unsigned int, char)' previously defined (line 223, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:223:1: Info 830: Location cited in prior message
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::Threads::EndThread(void)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetDay(unsigned int)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetHour(unsigned int)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetMinutes(unsigned int)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetMonth(unsigned int)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetSeconds(unsigned int)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetYear(unsigned int)
Note 974: Worst case function for stack usage: 'MARTe::BasicTCPSocket::WaitConnection' is recursive, loop contains call to 'MARTe::BasicTCPSocket::WaitConnection'. See +stack for a full report. [MISRA C++ Rule 7-5-4]
h1. Unit test review
*Date of the review:* --/--/2016
*Person who did the review:* -----
*Result of coverage tests review:* [PASS/FAIL]
*Result of functional tests review:* [PASS/FAIL]
*Result of review:* [PASS/FAIL]
*List of non-conformities:*
h1. Source code files modified
(see on the commit message)
h1. Architecture & design review
*Date of the review:* 18/01/2016
*Person who did the review:* Andre' Neto
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 18/01/2016
*Person who did the review:* Andre' Neto
*Result of review:* FAIL
*List of non-conformities:*
Note that on branch #188 I have already solved some of these issues.
During Specific Walk:
File ./Source/Core/BareMetal/L3Streams/IOBufferIntegerPrint.cpp line 531: MARTe::BitSetToInteger(?, ?, ?, 8?, !=0) #1
File ./Source/Core/BareMetal/L3Streams/BitSetToInteger.h line 345: MARTe::BitSetToBitSet([1], 0, 8, 1, ?, ?, 8?, !=0) #2
File ./Source/Core/BareMetal/L3Streams/BitSetToInteger.h line 286: MARTe::BSToBS([1], 0, 8, 1, ?, 31? | 0?, 8?, !=0) #3
File ./Source/Core/BareMetal/L3Streams/BitSetToInteger.h line 105: MARTe::MemoryOperationsHelper::Copy([4], ?, 5?) #30
./Source/Core/BareMetal/L1Portability/Environment/Generic/MemoryOperationsHelper_CLIB_Generic.cpp:58:1: Warning 669: Possible data overrun for function 'memcpy(void *, const void *, unsigned long)', argument 3 (size=5) exceeds argument 1 (size=4)
./Source/Core/BareMetal/L3Streams/BitSetToInteger.h:101:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L3Streams/BitSetToInteger.h:105:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L3Streams/BitSetToInteger.h:227:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L3Streams/BitSetToInteger.h:242:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L3Streams/BitSetToInteger.h:286:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L3Streams/BitSetToInteger.h:345:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L3Streams/IOBufferIntegerPrint.cpp:528:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L3Streams/IOBufferIntegerPrint.cpp:531:1: Info 831: Reference cited in prior message
./Source/Core/BareMetal/L4Configuration/ParserI.cpp:51:80: Note 9138: null statement not in line by itself [MISRA C++ Rule 6-2-3]
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:45:34: Error 14: Symbol 'MARTe::StringHelper::Length(const char *)' previously defined (line 150, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:150:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:62:34: Error 14: Symbol 'MARTe::StringHelper::Compare(const char *, const char *)' previously defined (line 94, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:94:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:96:29: Error 14: Symbol 'MARTe::StringHelper::CompareN(const char *, const char *, unsigned int)' previously defined (line 105, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:105:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:132:37: Error 14: Symbol 'MARTe::StringHelper::Concatenate(char *, const char *)' previously defined (line 62, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:62:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:153:32: Error 14: Symbol 'MARTe::StringHelper::ConcatenateN(char *, const char *, unsigned int)' previously defined (line 75, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:75:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:175:37: Error 14: Symbol 'MARTe::StringHelper::SearchChar(const char *, char)' previously defined (line 85, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:85:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:205:30: Error 14: Symbol 'MARTe::StringHelper::Copy(char *, const char *)' previously defined (line 117, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:117:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:219:25: Error 14: Symbol 'MARTe::StringHelper::CopyN(char *, const char *, unsigned int)' previously defined (line 130, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:130:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:232:38: Error 14: Symbol 'MARTe::StringHelper::SearchIndex(const char *, const char *)' previously defined (line 142, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:142:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:266:45: Error 14: Symbol 'MARTe::StringHelper::SearchChars(const char *, const char *)' previously defined (line 158, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:158:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:310:41: Error 14: Symbol 'MARTe::StringHelper::SearchLastChar(const char *, char)' previously defined (line 167, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:167:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:335:46: Error 14: Symbol 'MARTe::StringHelper::SearchString(const char *, const char *)' previously defined (line 176, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:176:1: Info 830: Location cited in prior message
./Source/Core/BareMetal/L1Portability/Environment/Generic/StringHelper_Portable_Generic.cpp:363:26: Error 14: Symbol 'MARTe::StringHelper::SetChar(char *, unsigned int, char)' previously defined (line 223, file ./Source/Core/BareMetal/L1Portability/StringHelper.h)
./Source/Core/BareMetal/L1Portability/StringHelper.h:223:1: Info 830: Location cited in prior message
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::Threads::EndThread(void)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetDay(unsigned int)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetHour(unsigned int)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetMinutes(unsigned int)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetMonth(unsigned int)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetSeconds(unsigned int)
Note 1960: Violates MISRA C++ 2008 Required Rule 0-1-8, Void return type for function without external side-effects: MARTe::TimeStamp::SetYear(unsigned int)
Note 974: Worst case function for stack usage: 'MARTe::BasicTCPSocket::WaitConnection' is recursive, loop contains call to 'MARTe::BasicTCPSocket::WaitConnection'. See +stack for a full report. [MISRA C++ Rule 7-5-4]
h1. Unit test review
*Date of the review:* --/--/2016
*Person who did the review:* -----
*Result of coverage tests review:* [PASS/FAIL]
*Result of functional tests review:* [PASS/FAIL]
*Result of review:* [PASS/FAIL]
*List of non-conformities:*