MARTe2 » MARTe2-core

Port the old BaseLib2 StateMachine to MARTe2.

h1. Source code files modified

h1. Architecture & design review

*Date of the review:* 29/09/2016

*Person who did the review:* Andre' Neto

*Version of architecture & design document:* N/A. As per the original MARTe implementation.

*Result of review:* N/A

*List of non-conformities:* N/A

h1. Code and documentation review

*Date of the review:* 25/10/2016 --/--/2016

*Person who did the review:* R. Vitelli



*Result of review:* PASS



*List of non-conformities:*

Unrelated linting errors to be fixed in the next sprint:
<pre>
./Source/Core/Scheduler/L3Services/EmbeddedThreadI.cpp:216:35: Warning 578: Declaration of symbol 'threadId' hides symbol 'MARTe::EmbeddedThreadI::threadId' (line 232, file ./Source/Core/Scheduler/L3Services/EmbeddedThreadI.h, module ./Source/Core/Scheduler/L3Services/EmbeddedThread.cpp) [MISRA C++ Rule 2-10-2]
./Source/Core/Scheduler/L3Services/EmbeddedThreadI.h:232:1: Info 830: Location cited in prior message
./Source/Core/Scheduler/L4Messages/QueuedMessageI.cpp:47:37: Note 9153: viable set contains both function 'MARTe::SingleThreadService::SingleThreadService (line 65, file ./Source/Core/Scheduler/L3Services/SingleThreadService.h, module ./Source/Core/Scheduler/L3Services/MultiClientEmbeddedThread.cpp)' and template 'MARTe::SingleThreadService::SingleThreadService (line 148, file ./Source/Core/Scheduler/L3Services/SingleThreadService.h)' [MISRA C++ Rule 14-8-2]
./Source/Core/Scheduler/L3Services/SingleThreadService.h:65:1: Info 830: Location cited in prior message
</pre>

h1. Unit test review

*Date of the review:* 25/10/2016 --/--/2016

*Person who did the review:* R. Vitelli



*Result of coverage tests review:* PASS



*Result of functional tests review:* PASS



*Result of review:* PASS



*List of non-conformities:*

Two tests fail, both unrelated to this user story. Both will be fixed in the next sprint.

<pre>
MultiThreadServiceGTest.TestStart_Restart
IOBufferGTest.TestPrintStructuredDataInterface
</pre>