User story #313
Updated by André Neto over 8 years ago
Solve this issues found during the IO demo:
* Load classes from DLL in run-time; (SOLVED)
* BufferedStreamGenerator for File, UDPSocket and other streams is not working; (SOLVED)
* Improve documentation on timing DataSourceI signal names (SOLVED)
* Improve documentation DataSourceI Locked parameter (value must be specified as 1 and not as true) (SOLVED)
* Do not remove signals from the DataSourceI even these are not consumed or produced by a GAM (IT WAS NOT A BUG)
* The EmbeddedThreadI has to allow to specify affinity and friends (SOLVED)
* Allow to Trigger the DataSourceI at a precise point in time (Feature added)
* Solved many small bugs on the GAMScheduler and on the FileSystem/L3Streams
h1. Source code files modified
h1. Architecture & design review
*Date of the review:* 15/11/2016
*Person who did the review:* Andre' Neto
*Version of architecture & design document:* N/A.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 28/11/2016
*Person who did the review:* Andre' Neto (in an independent PC)
*Result of review:* PASS
*List of non-conformities:*
./Source/Core/FileSystem/L1Portability/Environment/Linux/BasicSocket.cpp:59:16: Warning 1506: Call to virtual function 'MARTe::BasicSocket::IsValid(void) const' within a constructor or destructor [MISRA C++ Rule 12-1-1]
./Source/Core/Scheduler/L5GAMs/GAMScheduler.cpp:170:82: Note 9153: viable set contains both function 'MARTe::MultiThreadService::MultiThreadService (line 60, file ./Source/Core/Scheduler/L3Services/MultiThreadService.h)' and template 'MARTe::MultiThreadService::MultiThreadService (line 261, file ./Source/Core/Scheduler/L3Services/MultiThreadService.h)' [MISRA C++ Rule 14-8-2]
./Source/Core/Scheduler/L3Services/MultiThreadService.h:60:1: Info 830: Location cited in prior message
./Source/Core/Scheduler/L4Messages/QueuedMessageI.cpp:47:37: Note 9153: viable set contains both function 'MARTe::SingleThreadService::SingleThreadService (line 65, file ./Source/Core/Scheduler/L3Services/SingleThreadService.h, module ./Source/Core/Scheduler/L5GAMs/GAMScheduler.cpp)' and template 'MARTe::SingleThreadService::SingleThreadService (line 160, file ./Source/Core/Scheduler/L3Services/SingleThreadService.h)' [MISRA C++ Rule 14-8-2]
./Source/Core/Scheduler/L3Services/SingleThreadService.h:65:1: Info 830: Location cited in prior message
Note 974: Worst case function for stack usage: 'MARTe::ConfigurationDatabase::Copy' is recursive, loop contains call to 'MARTe::ConfigurationDatabase::Copy'. See +stack for a full report. [MISRA C++ Rule 7-5-4]
h1. Unit test review
*Date of the review:* 28/11/2016
*Person who did the review:* Andre' Neto
*Result of coverage tests review:* PASS
*Result of functional tests review:* PASS
*Result of review:* PASS
*List of non-conformities:*
[ FAILED ] 5 tests, listed below:
[ FAILED ] ThreadsGTest.TestGetThreadInfoCopy
[ FAILED ] ThreadsGTest.TestPriority
[ FAILED ] IOBufferGTest.TestPrintStructuredDataInterface
[ FAILED ] HighResolutionTimerGTest.TestCounter
[ FAILED ] HighResolutionTimerGTest.TestCounter32
* Load classes from DLL in run-time; (SOLVED)
* BufferedStreamGenerator for File, UDPSocket and other streams is not working; (SOLVED)
* Improve documentation on timing DataSourceI signal names (SOLVED)
* Improve documentation DataSourceI Locked parameter (value must be specified as 1 and not as true) (SOLVED)
* Do not remove signals from the DataSourceI even these are not consumed or produced by a GAM (IT WAS NOT A BUG)
* The EmbeddedThreadI has to allow to specify affinity and friends (SOLVED)
* Allow to Trigger the DataSourceI at a precise point in time (Feature added)
* Solved many small bugs on the GAMScheduler and on the FileSystem/L3Streams
h1. Source code files modified
h1. Architecture & design review
*Date of the review:* 15/11/2016
*Person who did the review:* Andre' Neto
*Version of architecture & design document:* N/A.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 28/11/2016
*Person who did the review:* Andre' Neto (in an independent PC)
*Result of review:* PASS
*List of non-conformities:*
./Source/Core/FileSystem/L1Portability/Environment/Linux/BasicSocket.cpp:59:16: Warning 1506: Call to virtual function 'MARTe::BasicSocket::IsValid(void) const' within a constructor or destructor [MISRA C++ Rule 12-1-1]
./Source/Core/Scheduler/L5GAMs/GAMScheduler.cpp:170:82: Note 9153: viable set contains both function 'MARTe::MultiThreadService::MultiThreadService (line 60, file ./Source/Core/Scheduler/L3Services/MultiThreadService.h)' and template 'MARTe::MultiThreadService::MultiThreadService (line 261, file ./Source/Core/Scheduler/L3Services/MultiThreadService.h)' [MISRA C++ Rule 14-8-2]
./Source/Core/Scheduler/L3Services/MultiThreadService.h:60:1: Info 830: Location cited in prior message
./Source/Core/Scheduler/L4Messages/QueuedMessageI.cpp:47:37: Note 9153: viable set contains both function 'MARTe::SingleThreadService::SingleThreadService (line 65, file ./Source/Core/Scheduler/L3Services/SingleThreadService.h, module ./Source/Core/Scheduler/L5GAMs/GAMScheduler.cpp)' and template 'MARTe::SingleThreadService::SingleThreadService (line 160, file ./Source/Core/Scheduler/L3Services/SingleThreadService.h)' [MISRA C++ Rule 14-8-2]
./Source/Core/Scheduler/L3Services/SingleThreadService.h:65:1: Info 830: Location cited in prior message
Note 974: Worst case function for stack usage: 'MARTe::ConfigurationDatabase::Copy' is recursive, loop contains call to 'MARTe::ConfigurationDatabase::Copy'. See +stack for a full report. [MISRA C++ Rule 7-5-4]
h1. Unit test review
*Date of the review:* 28/11/2016
*Person who did the review:* Andre' Neto
*Result of coverage tests review:* PASS
*Result of functional tests review:* PASS
*Result of review:* PASS
*List of non-conformities:*
[ FAILED ] 5 tests, listed below:
[ FAILED ] ThreadsGTest.TestGetThreadInfoCopy
[ FAILED ] ThreadsGTest.TestPriority
[ FAILED ] IOBufferGTest.TestPrintStructuredDataInterface
[ FAILED ] HighResolutionTimerGTest.TestCounter
[ FAILED ] HighResolutionTimerGTest.TestCounter32