MARTe2 » MARTe2-core

h1. Requirements review

*Date of the review:* 20/01/2016

*Person who did the review:* Ivan Herrero

*Version of requirements:* 0.12

*Result of review:* N/A

*List of non-conformities:* N/A

*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal requirements.

h1. Architecture & design review

*Date of the review:* 20/01/2016

*Person who did the review:* Ivan Herrero

*Version of architecture & design document:* 0.12

*Result of review:* N/A

*List of non-conformities:* N/A

*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal design.

h1. Code and documentation review

*Date of the review:* 20/01/2016

*Person who did the review:* Ivan Herrero

*Version of source code:* 0.12

*Result of review:* PASS

*List of non-conformities:*
<pre>


Note 974: Worst case function for stack usage: 'MARTe::ConfigurationDatabase::Copy' is recursive, loop contains call to 'MARTe::ConfigurationDatabase::Copy'. See +stack for a full report. [MISRA C++ Rule 7-5-4]
MARTe::Atomic::Exchange lacks documentation for return value.
</pre>

h1. Unit test review

*Date of the review:* 20/01/2016

*Person who did the review:* Ivan Herrero

*Version of unit tests:* 0.12

*Result of coverage tests review:* PASS

*Result of functional tests review:* PASS

*Result of review:* PASS

*List of non-conformities:*

_LCOV report (methods not executed at all):_
<pre>
TimeoutType EmbeddedThreadI::GetTimeout() const
inline ExceptionHandler::~ExceptionHandler()
bool GAMDataSource::Synchronise()
bool GAM::SetContext(ConstReference context)
ReferenceT<T>* ReferenceT<T>::operator&() (*)
Object *Object::Clone() const
IntrospectionEntry::IntrospectionEntry()
Introspection::Introspection()
uint32 ClassProperties::GetSize() const
void MemoryArea::SetHeapName(const char8 * const name)
</pre>

(*) The ReferenceT<T>::operator& is private. See solution applied in Reference::operator&.

_LCOV report (fragments of code not executed):_
<pre>
case if (timeout.IsFinite()) @ bool BasicUDPSocket::Write(const char8 * const input, uint32 & size, const TimeoutType &timeout)
loop for (uint32 i = 0u; i < numberOfChildren; i++) @ bool RealTimeThread::ToStructuredData(StructuredDataI& data)
call with recursive==true @ Reference ReferenceContainer::Find(const char8 * const path, const bool recursive)
case if (dllOpened) @ ClassRegistryItem *ClassRegistryDatabase::Find(const char8 *className)
case if (ok) @ bool BasicConsole::Open(const FlagsType &mode)
case else if (shift < bitSize) @ DoubleInteger<T2> Shift::LogicalRightShift(DoubleInteger<T2> number, uint8 shift)
error reporting and set variables to default values on error checking @ all classes
</pre>

_GTest report_
<pre>
[----------] Global test environment tear-down
[==========] 3674 tests from 133 test cases ran. (225205 ms total)
[ PASSED ] 3664 tests.
[ FAILED ] 10 tests, listed below:
[ FAILED ] DirectoryGTest.TestGetSize_FileIncorrect
[ FAILED ] DirectoryGTest.TestGetSize_FileIncorrect2
[ FAILED ] DirectoryGTest.TestGetLastAccessTime_ReRead
[ FAILED ] DirectoryGTest.TestGetLastAccessTime_ReRead2
[ FAILED ] DirectoryGTest.TestGetLastWriteTime_ReWrite
[ FAILED ] DirectoryGTest.TestGetLastWriteTime_ReWrite2
[ FAILED ] ThreadsGTest.TestGetThreadInfoCopy
[ FAILED ] ThreadsGTest.TestPriority
[ FAILED ] IOBufferGTest.TestPrintStructuredDataInterface
[ FAILED ] BasicConsoleGTest.TestOpenModePerformCharacterInput
</pre>

h1. Integration test review

*Date of the review:* 20/01/2016

*Person who did the review:* Ivan Herrero

*Version of integration tests:* 0.12

*Result of review:* N/A

*List of non-conformities:* N/A

*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal integration tests.

h1. Acceptance test review

*Date of the review:* 20/01/2016

*Person who did the review:* Ivan Herrero

*Version of acceptance tests:* 0.12

*Result of review:* N/A

*List of non-conformities:* N/A

*Comments*: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal acceptance tests.