Meeting #353
Updated by André Neto over 6 years ago
The v0.6 adds support to EPICSPVA and aligns with the v0.19 of the core.
h1. Requirements review
*Date of the review:* 21/12/2018
*Person who did the review:* André Neto
*Version of requirements:* N/A
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: Not applicable to this release (each individual component requirements was analysed separately).
h1. Architecture & design review
*Date of the review:* 21/12/2018
*Person who did the review:* André Neto
*Version of architecture & design document:* 0.6
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: Not applicable to this release (each individual component architecture was analysed separately).
h1. Code and documentation review
*Date of the review:* 21/12/2018
*Person who did the review:* André Neto
*Version of source code:* 0.6
*Result of review:* PASS
*List of non-conformities:*
The NI6259 and NI6368 do not allow access to more than one GAM at the time. This is to prevent a synchornisation bug (see GetLastBufferIdx). The impact is minor but they should be updated to use the new Circular Buffer of the core framework.
*List of warnings reported by Doxygen:*
<pre>
NONE
</pre>
h1. Unit test review
*Date of the review:* 21/12/2018
*Person who did the review:* André Neto
*Version of unit tests:* 0.6
*Result of coverage tests review:* PASS
*Result of functional tests review:* PASS
*Result of review:* PASS
ITER components tested @ trunk.codac.iter.org mini-codac2 (but I did not test the hardware). DAN not tested as the test xml is no longer valid in 6.0! hardware)
*List of non-conformities:*
Note: execute with <pre>lcov -l Build/MARTe2-components.coverage.info</pre> Build/MARTe2.coverage.info</pre> and compare with the latest master release using tkdiff.
Files containing functions with coverage < 90% or which have changed w.r.t. to last master release. Exclamation marks inform of differences w.r.t. to the last master.:_
<pre>
1
|Lines |Functions|Branches 1 |Lines |Functions|Branches
2
Filename |Rate Num|Rate Num|Rate Num 2 Filename |Rate Num|Rate Num|Rate Num
3
================================================================================ 3 ================================================================================
4 !
[/home/aneto/Projects/MARTe2-components/Source/Components/] 4 ! [/home/aneto/Projects/MARTe2-components-master/Source/Components/]
5 !
DataSources/EPICSCA/EPICSCAInput.cpp |94.9% |94.0% 196|95.7% 182|95.7% 23| - 0 5 ! DataSources/EPICSCA/EPICSCAInput.cpp
GAMs/ConversionGAM/ConversionGAM.cpp |95.1% |99.3% 183|95.7% 305|66.7% 23| - 0
6 ! DataSources/EPICSCA/EPICSCAOutput.cpp |98.9% 188| 100% 23| - 0 6 ! DataSources/EPICSCA/EPICSCAOutput.cpp |98.8% 173| 100% 23| - 0
7 ! DataSources/EPICSPVA/EPICSPVAChannelWrapper.cpp|94.8% 271|92.9% 14| - 0 !
8 ! DataSources/EPICSPVA/EPICSPVAChannelWrapper.h |91.4% 35| 100% 23| - 0 !
9 ! DataSources/EPICSPVA/EPICSPVAInput.cpp |97.8% 92| 100% 18| - 0 !
10 ! DataSources/EPICSPVA/EPICSPVAOutput.cpp | 100% 104| 100% 20| - 0 !
11 DataSources/EpicsDataSource/Atomic2.h | 100% 4| 100% 2| - 0 7 DataSources/EpicsDataSource/Atomic2.h | 100% 4| 100% 2| - 0
14 DataSources/EpicsDataSource/Platform.cpp |72.4% 58|75.0% 4| - 0 10 DataSources/EpicsDataSource/Platform.cpp |72.4% 58|75.0% 4| - 0
29 ! DataSources/MDSWriter/MDSWriterNode.cpp |90.4% 417| 100% 27| - 0 25 ! DataSources/MDSWriter/MDSWriterNode.cpp |96.7% 389| 100% 27| - 0
30 ! DataSources/RealTimeTh...eThreadAsyncBridge.cpp| 100% 234|83.3% 18| - 0 26 ! DataSources/RealTimeTh...eThreadAsyncBridge.cpp| 100% 227|83.3% 18| - 0
34 ! DataSources/SDN/SDNPublisher.cpp |95.1% 265| 100% 19| - 0 30 ! DataSources/SDN/SDNPublisher.cpp |94.2% 258| 100% 19| - 0
35 ! DataSources/SDN/SDNSubscriber.cpp |86.4% 279| 100% 20| - 0 31 ! DataSources/SDN/SDNSubscriber.cpp |97.7% 257| 100% 20| - 0
36 ! GAMs/ConstantGAM/ConstantGAM.cpp | 100% 103| 100% 12| - 0 32 ! GAMs/ConstantGAM/ConstantGAM.cpp | 100% 90| 100% 12| - 0
40 !
GAMs/FilterGAM/FilterGAM.cpp |98.8% |98.2% 337|86.4% 341|86.4% 22| - 0 36 ! GAMs/FilterGAM/FilterGAM.cpp |95.5%
GAMs/SSMGAM/SSMGAM.cpp |97.7% 337|86.4% 444|76.9% 22| 13| - 0
42 ! GAMs/HistogramGAM/HistogramComparatorT.h | 100% 38| 100% 80| - 0 38 ! GAMs/HistogramGAM/HistogramComparatorT.h | 100% 36| 100% 70| - 0
43 ! GAMs/HistogramGAM/HistogramGAM.cpp | 100%
GAMs/WaveformGAM/Waveform.cpp |98.5% 132|77.3% 324|91.7% 66| 12| - 0 39 ! GAMs/HistogramGAM/HistogramGAM.cpp
GAMs/WaveformGAM/WaveformChirp.cpp | 100% 115|76.9% 65| |99.0% - 0
52 ! GAMs/TriggerOnChangeGA...ntConditionTrigger.cpp|96.2% 209| 100% 97|86.4% 18| 22| - 0 48 ! GAMs/TriggerOnChangeGA...ntConditionTrigger.cpp|97.2%
GAMs/WaveformGAM/WaveformPointsDef.cpp |96.4% 177| 100% 167|88.0% 18| 25| - 0
54 ! GAMs/TriggerOnChangeGAM/TriggerOnChangeGAM.cpp | 100% 235|69.2% 13|
GAMs/WaveformGAM/WaveformSin.cpp |98.7% - 0 50 ! GAMs/TriggerOnChangeGAM/TriggerOnChangeGAM.cpp | 100% 233|69.2% 75|86.4% 13| 22| - 0
62 !
Interfaces/EPICS/EPICSCAClient.cpp |92.3% |75.0% 104| 100% 100|94.1% 17| - 0 58 ! Interfaces/EPICS/EPICSCAClient.cpp |77.7% 103|94.1% 17| - 0
63 !
Interfaces/EPICS/EPICSPV.cpp |97.5% |93.6% 326| 100% 251|96.3% 30| - 0 59 ! Interfaces/EPICS/EPICSPV.cpp |96.7% 269|96.3% 27| - 0
64 ! Interfaces/EPICSPVA/EP...tryDatabaseService.cpp| 100% 46| 100%
================================================================================
Total:|92.5% 11637|96.0% 12| 1k| - 0 60 ! Interfaces/MemoryGate/MemoryGate.cpp |98.6% 144| 100% 13|
</pre>
_LCOV report (files containing functions with coverage < 90%):_
<pre>
|Lines |Functions|Branches
Filename |Rate - 0
65 ! Interfaces/EPICSPVA/EPICSPVA2V3Service.cpp |99.0% 192| 100% Num|Rate 16| - 0 !
66 ! Interfaces/EPICSPVA/EPICSPVADatabase.cpp |93.9% 98| 100% 17| - 0 !
67 ! Interfaces/EPICSPVA/EPICSPVAHelper.cpp |95.9% Num|Rate 196| 100% 23| - 0 !
68 ! Interfaces/EPICSPVA/EPICSPVAMessageI.cpp Num
================================================================================
[/home/aneto/Projects/MARTe2-components/Source/Components/]
DataSources/EpicsDataSource/Platform.cpp |95.1% |81.0% 41|90.0% 10| - 0 !
69 ! Interfaces/EPICSPVA/EPICSPVARecord.cpp |94.2% 189| 58| 100% 19| - 0 !
70 ! Interfaces/EPICSPVA/EPICSPVAStructureDataI.cpp |95.9% 585| 100% 35| 4| - 0 !
71 ! Interfaces/EPICSPVA/EPICSPVAStructureDataI.h
Interfaces/EPICS/EPICSCAClient.cpp |89.0% | 100% 41| 100% 100|94.1% 22| 17| - 0 !
72 ! Interfaces/EPICSPVA/EPICSRPCClient.cpp |89.7% 29| 100%
================================================================================
Total:|92.5% 11637|96.0% 10| 1k| - 0 !
73 ! Interfaces/EPICSPVA/EP...lientMessageFilter.cpp|92.3% 52|91.7% 12| - 0 !
74 ! Interfaces/EPICSPVA/EPICSRPCServer.cpp |92.6% 81| 100% 16| - 0 !
75 ! Interfaces/EPICSPVA/EPICSRPCService.cpp | 100% 5|80.0% 5| - 0 !
76 ! Interfaces/EPICSPVA/EPICSRPCServiceAdapter.cpp | 100% 10| 100% 7| - 0 !
77 ! Interfaces/MemoryGate/MemoryGate.cpp |98.6% 142|92.3% 13| - 0 !
</pre>
_GTest report_
<pre>
[----------] Global test environment tear-down
[==========] 2316 2024 tests from 78 64 test cases ran. (706310 (480116 ms total)
[ PASSED ] 2316 2024 tests.
</pre>
h1. Integration test review
*Date of the review:* 21/12/2018 05/09/2018
*Person who did the review:* André Neto
*Version of integration tests:* 0.6 0.5
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: Not performed.
h1. Acceptance test review
*Date of the review:* 21/12/2018 05/09/2018
*Person who did the review:* André Neto
*Version of acceptance tests:* 0.6 0.5
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: Not performed.
h1. Requirements review
*Date of the review:* 21/12/2018
*Person who did the review:* André Neto
*Version of requirements:* N/A
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: Not applicable to this release (each individual component requirements was analysed separately).
h1. Architecture & design review
*Date of the review:* 21/12/2018
*Person who did the review:* André Neto
*Version of architecture & design document:* 0.6
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: Not applicable to this release (each individual component architecture was analysed separately).
h1. Code and documentation review
*Date of the review:* 21/12/2018
*Person who did the review:* André Neto
*Version of source code:* 0.6
*Result of review:* PASS
*List of non-conformities:*
The NI6259 and NI6368 do not allow access to more than one GAM at the time. This is to prevent a synchornisation bug (see GetLastBufferIdx). The impact is minor but they should be updated to use the new Circular Buffer of the core framework.
*List of warnings reported by Doxygen:*
<pre>
NONE
</pre>
h1. Unit test review
*Date of the review:* 21/12/2018
*Person who did the review:* André Neto
*Version of unit tests:* 0.6
*Result of coverage tests review:* PASS
*Result of functional tests review:* PASS
*Result of review:* PASS
ITER components tested @ trunk.codac.iter.org mini-codac2 (but I did not test the hardware). DAN not tested as the test xml is no longer valid in 6.0! hardware)
*List of non-conformities:*
Note: execute with <pre>lcov -l Build/MARTe2-components.coverage.info</pre> Build/MARTe2.coverage.info</pre> and compare with the latest master release using tkdiff.
Files containing functions with coverage < 90% or which have changed w.r.t. to last master release. Exclamation marks inform of differences w.r.t. to the last master.:_
<pre>
1
|Lines |Functions|Branches 1 |Lines |Functions|Branches
2
Filename |Rate Num|Rate Num|Rate Num 2 Filename |Rate Num|Rate Num|Rate Num
3
================================================================================ 3 ================================================================================
4 !
[/home/aneto/Projects/MARTe2-components/Source/Components/] 4 ! [/home/aneto/Projects/MARTe2-components-master/Source/Components/]
5 !
DataSources/EPICSCA/EPICSCAInput.cpp |94.9% |94.0% 196|95.7% 182|95.7% 23| - 0 5 ! DataSources/EPICSCA/EPICSCAInput.cpp
GAMs/ConversionGAM/ConversionGAM.cpp |95.1% |99.3% 183|95.7% 305|66.7% 23| - 0
6 ! DataSources/EPICSCA/EPICSCAOutput.cpp |98.9% 188| 100% 23| - 0 6 ! DataSources/EPICSCA/EPICSCAOutput.cpp |98.8% 173| 100% 23| - 0
7 ! DataSources/EPICSPVA/EPICSPVAChannelWrapper.cpp|94.8% 271|92.9% 14| - 0 !
8 ! DataSources/EPICSPVA/EPICSPVAChannelWrapper.h |91.4% 35| 100% 23| - 0 !
9 ! DataSources/EPICSPVA/EPICSPVAInput.cpp |97.8% 92| 100% 18| - 0 !
10 ! DataSources/EPICSPVA/EPICSPVAOutput.cpp | 100% 104| 100% 20| - 0 !
11 DataSources/EpicsDataSource/Atomic2.h | 100% 4| 100% 2| - 0 7 DataSources/EpicsDataSource/Atomic2.h | 100% 4| 100% 2| - 0
14 DataSources/EpicsDataSource/Platform.cpp |72.4% 58|75.0% 4| - 0 10 DataSources/EpicsDataSource/Platform.cpp |72.4% 58|75.0% 4| - 0
29 ! DataSources/MDSWriter/MDSWriterNode.cpp |90.4% 417| 100% 27| - 0 25 ! DataSources/MDSWriter/MDSWriterNode.cpp |96.7% 389| 100% 27| - 0
30 ! DataSources/RealTimeTh...eThreadAsyncBridge.cpp| 100% 234|83.3% 18| - 0 26 ! DataSources/RealTimeTh...eThreadAsyncBridge.cpp| 100% 227|83.3% 18| - 0
34 ! DataSources/SDN/SDNPublisher.cpp |95.1% 265| 100% 19| - 0 30 ! DataSources/SDN/SDNPublisher.cpp |94.2% 258| 100% 19| - 0
35 ! DataSources/SDN/SDNSubscriber.cpp |86.4% 279| 100% 20| - 0 31 ! DataSources/SDN/SDNSubscriber.cpp |97.7% 257| 100% 20| - 0
36 ! GAMs/ConstantGAM/ConstantGAM.cpp | 100% 103| 100% 12| - 0 32 ! GAMs/ConstantGAM/ConstantGAM.cpp | 100% 90| 100% 12| - 0
40 !
GAMs/FilterGAM/FilterGAM.cpp |98.8% |98.2% 337|86.4% 341|86.4% 22| - 0 36 ! GAMs/FilterGAM/FilterGAM.cpp |95.5%
GAMs/SSMGAM/SSMGAM.cpp |97.7% 337|86.4% 444|76.9% 22| 13| - 0
42 ! GAMs/HistogramGAM/HistogramComparatorT.h | 100% 38| 100% 80| - 0 38 ! GAMs/HistogramGAM/HistogramComparatorT.h | 100% 36| 100% 70| - 0
43 ! GAMs/HistogramGAM/HistogramGAM.cpp | 100%
GAMs/WaveformGAM/Waveform.cpp |98.5% 132|77.3% 324|91.7% 66| 12| - 0 39 ! GAMs/HistogramGAM/HistogramGAM.cpp
GAMs/WaveformGAM/WaveformChirp.cpp | 100% 115|76.9% 65| |99.0% - 0
52 ! GAMs/TriggerOnChangeGA...ntConditionTrigger.cpp|96.2% 209| 100% 97|86.4% 18| 22| - 0 48 ! GAMs/TriggerOnChangeGA...ntConditionTrigger.cpp|97.2%
GAMs/WaveformGAM/WaveformPointsDef.cpp |96.4% 177| 100% 167|88.0% 18| 25| - 0
54 ! GAMs/TriggerOnChangeGAM/TriggerOnChangeGAM.cpp | 100% 235|69.2% 13|
GAMs/WaveformGAM/WaveformSin.cpp |98.7% - 0 50 ! GAMs/TriggerOnChangeGAM/TriggerOnChangeGAM.cpp | 100% 233|69.2% 75|86.4% 13| 22| - 0
62 !
Interfaces/EPICS/EPICSCAClient.cpp |92.3% |75.0% 104| 100% 100|94.1% 17| - 0 58 ! Interfaces/EPICS/EPICSCAClient.cpp |77.7% 103|94.1% 17| - 0
63 !
Interfaces/EPICS/EPICSPV.cpp |97.5% |93.6% 326| 100% 251|96.3% 30| - 0 59 ! Interfaces/EPICS/EPICSPV.cpp |96.7% 269|96.3% 27| - 0
64 ! Interfaces/EPICSPVA/EP...tryDatabaseService.cpp| 100% 46| 100%
================================================================================
Total:|92.5% 11637|96.0% 12| 1k| - 0 60 ! Interfaces/MemoryGate/MemoryGate.cpp |98.6% 144| 100% 13|
</pre>
_LCOV report (files containing functions with coverage < 90%):_
<pre>
|Lines |Functions|Branches
Filename |Rate - 0
65 ! Interfaces/EPICSPVA/EPICSPVA2V3Service.cpp |99.0% 192| 100% Num|Rate 16| - 0 !
66 ! Interfaces/EPICSPVA/EPICSPVADatabase.cpp |93.9% 98| 100% 17| - 0 !
67 ! Interfaces/EPICSPVA/EPICSPVAHelper.cpp |95.9% Num|Rate 196| 100% 23| - 0 !
68 ! Interfaces/EPICSPVA/EPICSPVAMessageI.cpp Num
================================================================================
[/home/aneto/Projects/MARTe2-components/Source/Components/]
DataSources/EpicsDataSource/Platform.cpp |95.1% |81.0% 41|90.0% 10| - 0 !
69 ! Interfaces/EPICSPVA/EPICSPVARecord.cpp |94.2% 189| 58| 100% 19| - 0 !
70 ! Interfaces/EPICSPVA/EPICSPVAStructureDataI.cpp |95.9% 585| 100% 35| 4| - 0 !
71 ! Interfaces/EPICSPVA/EPICSPVAStructureDataI.h
Interfaces/EPICS/EPICSCAClient.cpp |89.0% | 100% 41| 100% 100|94.1% 22| 17| - 0 !
72 ! Interfaces/EPICSPVA/EPICSRPCClient.cpp |89.7% 29| 100%
================================================================================
Total:|92.5% 11637|96.0% 10| 1k| - 0 !
73 ! Interfaces/EPICSPVA/EP...lientMessageFilter.cpp|92.3% 52|91.7% 12| - 0 !
74 ! Interfaces/EPICSPVA/EPICSRPCServer.cpp |92.6% 81| 100% 16| - 0 !
75 ! Interfaces/EPICSPVA/EPICSRPCService.cpp | 100% 5|80.0% 5| - 0 !
76 ! Interfaces/EPICSPVA/EPICSRPCServiceAdapter.cpp | 100% 10| 100% 7| - 0 !
77 ! Interfaces/MemoryGate/MemoryGate.cpp |98.6% 142|92.3% 13| - 0 !
</pre>
_GTest report_
<pre>
[----------] Global test environment tear-down
[==========] 2316 2024 tests from 78 64 test cases ran. (706310 (480116 ms total)
[ PASSED ] 2316 2024 tests.
</pre>
h1. Integration test review
*Date of the review:* 21/12/2018 05/09/2018
*Person who did the review:* André Neto
*Version of integration tests:* 0.6 0.5
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: Not performed.
h1. Acceptance test review
*Date of the review:* 21/12/2018 05/09/2018
*Person who did the review:* André Neto
*Version of acceptance tests:* 0.6 0.5
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments*: Not performed.