MARTe2 » MARTe2-core

Implement requirement MARTe-EX-F-1.1.7 based on the original MARTe implementation

Note: Being able to know the number of CPU cores available allow framework developers to take run-time decisions about the distribution of resources (e.g. threading affinity).

h1. Source code files modified

* Source\Core\L0Portability\Architecture\x86_cl\ProcessorA.h
* Source\Core\L0Portability\Architecture\x86_gcc\ProcessorA.h
* Source\Core\L0Portability\OperatingSystem\Linux\ProcessorOS.h
* Source\Core\L0Portability\OperatingSystem\Windows\ProcessorOS.h
* Source\Core\L0Portability\Processor.cpp
* Source\Core\L0Portability\Processor.h
* Source\Core\L0Portability\ProcessorType.cpp
* Source\Core\L0Portability\ProcessorType.h

h1. Architecture & design review

*Date of the review:* 12/06/2015

*Person who did the review:* André Neto

*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

*Result of review:* N/A

*List of non-conformities:* N/A

h1. Code and documentation review

*Date of the review:* 17/06/2015

*Person who did the review:* Ivan Herrero

*Result of review:* FAIL

*List of non-conformities:*

Manual review for Source\Core\L0Portability\Architecture\x86_cl\ProcessorA.h
Relax rule "definition for inline functions shall be outside class declaration"

Manual review for Source\Core\L0Portability\Architecture\x86_gcc\ProcessorA.h
Relax rule "definition for inline functions shall be outside class declaration"

Manual review for Source\Core\L0Portability\OperatingSystem\Linux\ProcessorOS.h
Relax rule "definition for inline functions shall be outside class declaration"

Manual review for Source\Core\L0Portability\OperatingSystem\Windows\ProcessorOS.h
Relax rule "definition for inline functions shall be outside class declaration"

Manual review for Source\Core\L0Portability\Processor.cpp
Functions have the same the documentation already written on declaration. It is not necessary.

Manual review for Source\Core\L0Portability\Processor.h
OK

Manual review for Source\Core\L0Portability\ProcessorType.cpp
Constructor definition of ProcessorType(const ProcessorType &pt) has the same documentation already written on declaration. It is not necessary.

Manual review for Source\Core\L0Portability\ProcessorType.h
Closing comment "*/" for "operator==" method does not have its own line.