User story #590
Updated by André Neto over 4 years ago
DESCRIBE CHANGES %{background:yellow}TODO%
*General*
Information
<pre>
The following files were detected as changed between branches develop and master
Lint/marte_components_flint_files.lnt
Source/Components/GAMs/Makefile.cov
Source/Components/GAMs/Makefile.inc
Source/Components/GAMs/SimulinkWrapperGAM/Makefile.cov
Source/Components/GAMs/SimulinkWrapperGAM/Makefile.gcc
Source/Components/GAMs/SimulinkWrapperGAM/Makefile.inc
Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.cpp
Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h
Source/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAM.cpp
Source/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAM.h
Test/Components/GAMs/Makefile.cov
Test/Components/GAMs/Makefile.inc
Test/Components/GAMs/SimulinkWrapperGAM/.gitignore
Test/Components/GAMs/SimulinkWrapperGAM/Makefile.cov
Test/Components/GAMs/SimulinkWrapperGAM/Makefile.gcc
Test/Components/GAMs/SimulinkWrapperGAM/Makefile.inc
Test/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAMGTest.cpp
Test/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAMTest.cpp
Test/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAMTest.h
Test/Components/GAMs/SimulinkWrapperGAM/createTestModel.m
Test/GTest/Makefile.cov
Test/GTest/Makefile.gcc
</pre>
%{color:green}OK:% no errors found.
h1. Requirements review
*Date of the review:* 08/11/2020
*Person who did the review:* TODO
*Version of requirements:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
h1. Architecture & design review
*Date of the review:* 08/11/2020
*Person who did the review:* TODO
*Version of architecture & design document:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
h1. Code and documentation review
*Date of the review:* 08/11/2020
*Person who did the review:* TODO
*Version of source code:* c459378586cc141d6d7dbc277acf23501b4030e8
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:*
%{background:red}Run flexelint and report% %{background:yellow}TODO%
*Headers*
%{color:red}ERR:% Invalid @brief in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.cpp
%{color:red}ERR:% Invalid @author in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.cpp
%{color:red}ERR:% Invalid @brief in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h
%{color:red}ERR:% Invalid @author in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h
%{color:red}ERR:% Invalid #includes sorted in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h
%{color:red}ERR:% Invalid @author in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAM.cpp
%{color:red}ERR:% Invalid #includes sorted in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAM.cpp
%{color:red}ERR:% Invalid @author in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAM.h
%{color:red}ERR:% Invalid @author in file Test/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAMGTest.cpp
%{color:red}ERR:% Invalid @author in file Test/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAMTest.cpp
%{color:red}ERR:% Invalid #includes sorted in file Test/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAMTest.cpp
%{color:red}ERR:% Invalid @author in file Test/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAMTest.h
*Lint includes*
%{color:green}OK:% All files are being included for linting
%{color:green}OK:% no errors found.
*Linter*
%{color:red}ERR:% /home/aneto/MARTe2-dev/MakeDefaults/Lint/marte_flint_exceptions.lnt 15
%{color:red}ERR:% ./Source/Components/DataSources/EPICSPVA/EPICSPVAOutput.cpp:216:1: Info 766: Header file '/home/aneto/MARTe2-dev/Source/Core/Scheduler/L5GAMs/MemoryMapAsyncOutputBroker.h' not used in module 'EPICSPVAOutput.cpp'
%{color:red}ERR:% Note 974: Worst case function for stack usage: 'MARTe::MDSStructuredDataI::Copy' is recursive, loop contains call to 'MARTe::MDSStructuredDataI::Copy'. See +stack for a full report. [MISRA C++ Rule 7-5-4]
*Doxygen*
%{color:red}ERR:% warning: Tag `XML_SCHEMA' at line 1788 of file `Doxyfile' has become obsolete.
%{color:red}ERR:% warning: Tag `XML_DTD' at line 1794 of file `Doxyfile' has become obsolete.
%{color:red}ERR:% warning: source ./Docs/Assets/Snippets/Parsing/MathGrammar.ll is not a readable file or directory... skipping.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:45: warning: Compound OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:60: warning: Compound OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:354: warning: Member EPICSPVAStructureDataI::ReadArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value) (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:417: warning: Member EPICSPVAStructureDataI::WriteArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value, const uint32 &size) (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:54: warning: Member OPCUANodeSettings (typedef) of namespace OPCUA is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:68: warning: Member OPCUAObjectSettings (typedef) of namespace OPCUA is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:90: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath)
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:95: warning: The following parameters of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented:
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:79: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath)
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:84: warning: The following parameters of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented:
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:127: warning: The following parameters of MARTe::SimulinkDataI::PrintData(const uint64 maxNameLength=0u, StreamString additionalText="") are not documented:
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:273: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:276: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:273: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:276: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:273: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:276: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:292: warning: explicit link request to 'offsetBasedSize' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:46: warning: Member attr (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:47: warning: Member value (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:48: warning: Member nodeId (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:49: warning: Member nodeName (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:50: warning: Member parentNodeId (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:51: warning: Member parentReferenceNodeId (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:61: warning: Member attr (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:62: warning: Member nodeId (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:63: warning: Member nodeName (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:64: warning: Member parentNodeId (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:65: warning: Member parentReferenceNodeId (variable) of class OPCUA::ObjectProperties is not documented.
h1. Unit test review
*Date of the review:* 08/11/2020
*Person who did the review:* TODO
*Version of source code:* c459378586cc141d6d7dbc277acf23501b4030e8
*Result of coverage tests review:* %{background:yellow}TODO%
*Result of functional tests review:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
*List of non-conformities:*
*Functional tests*
%{color:red}ERR:% SimulinkClasses:Actualise is not tested
%{color:red}ERR:% SimulinkClasses:AddSignal is not tested
%{color:red}ERR:% SimulinkClasses:CopyData is not tested
%{color:red}ERR:% SimulinkClasses:IsContiguous is not tested
%{color:red}ERR:% SimulinkClasses:PrintData is not tested
%{color:red}ERR:% SimulinkClasses:PrintPort is not tested
%{color:red}ERR:% SimulinkClasses:PrintSignal is not tested
%{color:red}ERR:% SimulinkClasses:SimulinkDataI is not tested
%{color:red}ERR:% SimulinkClasses:SimulinkInputPort is not tested
%{color:red}ERR:% SimulinkClasses:SimulinkOutputPort is not tested
%{color:red}ERR:% SimulinkClasses:SimulinkPort is not tested
%{color:red}ERR:% SimulinkClasses:SimulinkSignal is not tested
%{color:red}ERR:% Test file not found: Test/Components/GAMs/SimulinkWrapperGAM/SimulinkClassesGTest.cpp
*GTest*
%{color:red}ERR:% Number of errors has increased. Number of tests: 1709. Current branch: 6. Reference branch: 5
%{color:green}OK:% Number of tests unchanged. Current branch: 1709. Reference branch: 1709
*Coverage*
%{color:green}OK:% No coverage errors found
%{color:green}OK:% no errors found.
h1. Integration test review
*Date of the review:* 08/11/2020
*Person who did the review:* TODO
*Version of source code:* c459378586cc141d6d7dbc277acf23501b4030e8
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments:* N/A
h1. Acceptance test review
*Date of the review:* 08/11/2020
*Person who did the review:* TODO
*Version of source code:* c459378586cc141d6d7dbc277acf23501b4030e8
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments:* N/A
*General*
Information
<pre>
The following files were detected as changed between branches develop and master
Lint/marte_components_flint_files.lnt
Source/Components/GAMs/Makefile.cov
Source/Components/GAMs/Makefile.inc
Source/Components/GAMs/SimulinkWrapperGAM/Makefile.cov
Source/Components/GAMs/SimulinkWrapperGAM/Makefile.gcc
Source/Components/GAMs/SimulinkWrapperGAM/Makefile.inc
Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.cpp
Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h
Source/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAM.cpp
Source/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAM.h
Test/Components/GAMs/Makefile.cov
Test/Components/GAMs/Makefile.inc
Test/Components/GAMs/SimulinkWrapperGAM/.gitignore
Test/Components/GAMs/SimulinkWrapperGAM/Makefile.cov
Test/Components/GAMs/SimulinkWrapperGAM/Makefile.gcc
Test/Components/GAMs/SimulinkWrapperGAM/Makefile.inc
Test/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAMGTest.cpp
Test/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAMTest.cpp
Test/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAMTest.h
Test/Components/GAMs/SimulinkWrapperGAM/createTestModel.m
Test/GTest/Makefile.cov
Test/GTest/Makefile.gcc
</pre>
%{color:green}OK:% no errors found.
h1. Requirements review
*Date of the review:* 08/11/2020
*Person who did the review:* TODO
*Version of requirements:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
h1. Architecture & design review
*Date of the review:* 08/11/2020
*Person who did the review:* TODO
*Version of architecture & design document:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
h1. Code and documentation review
*Date of the review:* 08/11/2020
*Person who did the review:* TODO
*Version of source code:* c459378586cc141d6d7dbc277acf23501b4030e8
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:*
%{background:red}Run flexelint and report% %{background:yellow}TODO%
*Headers*
%{color:red}ERR:% Invalid @brief in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.cpp
%{color:red}ERR:% Invalid @author in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.cpp
%{color:red}ERR:% Invalid @brief in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h
%{color:red}ERR:% Invalid @author in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h
%{color:red}ERR:% Invalid #includes sorted in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h
%{color:red}ERR:% Invalid @author in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAM.cpp
%{color:red}ERR:% Invalid #includes sorted in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAM.cpp
%{color:red}ERR:% Invalid @author in file Source/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAM.h
%{color:red}ERR:% Invalid @author in file Test/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAMGTest.cpp
%{color:red}ERR:% Invalid @author in file Test/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAMTest.cpp
%{color:red}ERR:% Invalid #includes sorted in file Test/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAMTest.cpp
%{color:red}ERR:% Invalid @author in file Test/Components/GAMs/SimulinkWrapperGAM/SimulinkWrapperGAMTest.h
*Lint includes*
%{color:green}OK:% All files are being included for linting
%{color:green}OK:% no errors found.
*Linter*
%{color:red}ERR:% /home/aneto/MARTe2-dev/MakeDefaults/Lint/marte_flint_exceptions.lnt 15
%{color:red}ERR:% ./Source/Components/DataSources/EPICSPVA/EPICSPVAOutput.cpp:216:1: Info 766: Header file '/home/aneto/MARTe2-dev/Source/Core/Scheduler/L5GAMs/MemoryMapAsyncOutputBroker.h' not used in module 'EPICSPVAOutput.cpp'
%{color:red}ERR:% Note 974: Worst case function for stack usage: 'MARTe::MDSStructuredDataI::Copy' is recursive, loop contains call to 'MARTe::MDSStructuredDataI::Copy'. See +stack for a full report. [MISRA C++ Rule 7-5-4]
*Doxygen*
%{color:red}ERR:% warning: Tag `XML_SCHEMA' at line 1788 of file `Doxyfile' has become obsolete.
%{color:red}ERR:% warning: Tag `XML_DTD' at line 1794 of file `Doxyfile' has become obsolete.
%{color:red}ERR:% warning: source ./Docs/Assets/Snippets/Parsing/MathGrammar.ll is not a readable file or directory... skipping.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:45: warning: Compound OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:60: warning: Compound OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:354: warning: Member EPICSPVAStructureDataI::ReadArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value) (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:417: warning: Member EPICSPVAStructureDataI::WriteArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value, const uint32 &size) (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:54: warning: Member OPCUANodeSettings (typedef) of namespace OPCUA is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:68: warning: Member OPCUAObjectSettings (typedef) of namespace OPCUA is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:90: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath)
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:95: warning: The following parameters of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented:
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:79: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath)
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:84: warning: The following parameters of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented:
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:127: warning: The following parameters of MARTe::SimulinkDataI::PrintData(const uint64 maxNameLength=0u, StreamString additionalText="") are not documented:
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:273: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:276: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:273: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:276: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:273: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:276: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:292: warning: explicit link request to 'offsetBasedSize' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:46: warning: Member attr (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:47: warning: Member value (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:48: warning: Member nodeId (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:49: warning: Member nodeName (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:50: warning: Member parentNodeId (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:51: warning: Member parentReferenceNodeId (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:61: warning: Member attr (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:62: warning: Member nodeId (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:63: warning: Member nodeName (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:64: warning: Member parentNodeId (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:65: warning: Member parentReferenceNodeId (variable) of class OPCUA::ObjectProperties is not documented.
h1. Unit test review
*Date of the review:* 08/11/2020
*Person who did the review:* TODO
*Version of source code:* c459378586cc141d6d7dbc277acf23501b4030e8
*Result of coverage tests review:* %{background:yellow}TODO%
*Result of functional tests review:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
*List of non-conformities:*
*Functional tests*
%{color:red}ERR:% SimulinkClasses:Actualise is not tested
%{color:red}ERR:% SimulinkClasses:AddSignal is not tested
%{color:red}ERR:% SimulinkClasses:CopyData is not tested
%{color:red}ERR:% SimulinkClasses:IsContiguous is not tested
%{color:red}ERR:% SimulinkClasses:PrintData is not tested
%{color:red}ERR:% SimulinkClasses:PrintPort is not tested
%{color:red}ERR:% SimulinkClasses:PrintSignal is not tested
%{color:red}ERR:% SimulinkClasses:SimulinkDataI is not tested
%{color:red}ERR:% SimulinkClasses:SimulinkInputPort is not tested
%{color:red}ERR:% SimulinkClasses:SimulinkOutputPort is not tested
%{color:red}ERR:% SimulinkClasses:SimulinkPort is not tested
%{color:red}ERR:% SimulinkClasses:SimulinkSignal is not tested
%{color:red}ERR:% Test file not found: Test/Components/GAMs/SimulinkWrapperGAM/SimulinkClassesGTest.cpp
*GTest*
%{color:red}ERR:% Number of errors has increased. Number of tests: 1709. Current branch: 6. Reference branch: 5
%{color:green}OK:% Number of tests unchanged. Current branch: 1709. Reference branch: 1709
*Coverage*
%{color:green}OK:% No coverage errors found
%{color:green}OK:% no errors found.
h1. Integration test review
*Date of the review:* 08/11/2020
*Person who did the review:* TODO
*Version of source code:* c459378586cc141d6d7dbc277acf23501b4030e8
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments:* N/A
h1. Acceptance test review
*Date of the review:* 08/11/2020
*Person who did the review:* TODO
*Version of source code:* c459378586cc141d6d7dbc277acf23501b4030e8
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments:* N/A