User story #607
Updated by André Neto about 4 years ago
As per the ECH FAT tools use-case, support CPUs with more than 32 cores.
DESCRIBE CHANGES %{background:yellow}TODO%
*General*
Information
<pre>
The following files were detected as changed between branches #607_MaxCPUCores and develop
.gitignore
AUTHORS
Docs/User/source/_static/examples/Core/ThreadsExample1.cpp
EclipseLcov.sh
MakeDefaults/Lint/marte_flint_files.lnt
Resources/QA/qahelpers.py
Resources/QA/qautils.py
Source/Core/BareMetal/L0Types/BitRange.h
Source/Core/BareMetal/L0Types/BitSet.cpp
Source/Core/BareMetal/L0Types/BitSet.h
Source/Core/BareMetal/L0Types/CompilerTypes.h
Source/Core/BareMetal/L0Types/Makefile.inc
Source/Core/BareMetal/L1Portability/ProcessorType.cpp
Source/Core/BareMetal/L1Portability/ProcessorType.h
Source/Core/BareMetal/L5GAMs/DataSourceI.cpp
Source/Core/BareMetal/L5GAMs/DataSourceI.h
Source/Core/BareMetal/L5GAMs/MemoryMapSynchronisedInputBroker.cpp
Source/Core/Scheduler/L1Portability/Environment/Linux/MutexSem.cpp
Source/Core/Scheduler/L3Services/ThreadsInformationQuery.cpp
Test/Core/BareMetal/L0Types/BitSetTest.cpp
Test/Core/BareMetal/L0Types/BitSetTest.h
Test/Core/BareMetal/L0Types/Makefile.inc
Test/Core/BareMetal/L1Portability/ProcessorTypeTest.cpp
Test/Core/BareMetal/L1Portability/ProcessorTypeTest.h
Test/Core/BareMetal/L3Streams/IOBufferTest.cpp
Test/Core/BareMetal/L5GAMs/DataSourceITest.cpp
Test/Core/BareMetal/L5GAMs/DataSourceITest.h
Test/Core/BareMetal/L6App/LoaderTest.cpp
Test/GTest/BareMetal/L0Types/BitSetGTest.cpp
Test/GTest/BareMetal/L0Types/Makefile.inc
Test/GTest/BareMetal/L5GAMs/DataSourceIGTest.cpp
</pre>
%{color:green}OK:% no errors found.
h1. Requirements review
*Date of the review:* 18/02/2021
*Person who did the review:* Andre Neto
*Version of requirements:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
h1. Architecture & design review
*Date of the review:* 18/02/2021
*Person who did the review:* Andre Neto
*Version of architecture & design document:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
h1. Code and documentation review
*Date of the review:* 18/02/2021
*Person who did the review:* Andre Neto
*Version of source code:* 6027d3cbbba07f7f5035b410e74c30fe0fa7c6a4
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:*
%{background:red}Run flexelint and report% %{background:yellow}TODO%
*Headers*
%{color:red}ERR:% Invalid #includes sorted in file Docs/User/source/_static/examples/Core/ThreadsExample1.cpp
%{color:red}ERR:% Invalid #includes sorted in file Source/Core/BareMetal/L0Types/BitRange.h
%{color:red}ERR:% Invalid @author in file Source/Core/BareMetal/L1Portability/ProcessorType.cpp
%{color:red}ERR:% Invalid #includes sorted in file Source/Core/BareMetal/L1Portability/ProcessorType.h
%{color:red}ERR:% Invalid #includes sorted in file Source/Core/Scheduler/L1Portability/Environment/Linux/MutexSem.cpp
%{color:red}ERR:% Invalid #includes sorted in file Test/Core/BareMetal/L0Types/BitSetTest.h
%{color:red}ERR:% Invalid #includes sorted in file Test/Core/BareMetal/L1Portability/ProcessorTypeTest.cpp
%{color:red}ERR:% Invalid #includes sorted in file Test/Core/BareMetal/L3Streams/IOBufferTest.cpp
%{color:red}ERR:% Invalid @brief in file Test/Core/BareMetal/L5GAMs/DataSourceITest.cpp
%{color:red}ERR:% Invalid #includes sorted in file Test/GTest/BareMetal/L0Types/BitSetGTest.cpp
%{color:red}ERR:% Invalid #includes sorted in file Test/GTest/BareMetal/L5GAMs/DataSourceIGTest.cpp
*Lint includes*
%{color:green}OK:% All files are being included for linting
%{color:green}OK:% no errors found.
*Linter*
%{color:red}ERR:% Note 974: Worst case function for stack usage: 'MARTe::ConfigurationDatabase::Copy' is recursive, loop contains call to 'MARTe::ConfigurationDatabase::Copy'. See +stack for a full report. [MISRA C++ Rule 7-5-4]
*Doxygen*
%{color:red}ERR:% warning: Tag `XML_SCHEMA' at line 1788 of file `Doxyfile' has become obsolete.
%{color:red}ERR:% warning: Tag `XML_DTD' at line 1794 of file `Doxyfile' has become obsolete.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:52: warning: Unsupported xml/html tag <limits> found
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/RuntimeEvaluatorFunction.h:249: warning: explicit link request to 'functionRecord' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/CompilerTypes.h:117: warning: Member MAX(a, b) (macro definition) of file CompilerTypes.h is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/CompilerTypes.h:118: warning: Member MIN(a, b) (macro definition) of file CompilerTypes.h is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/CompilerTypes.h:120: warning: Member ONE (macro definition) of file CompilerTypes.h is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/CompilerTypes.h:121: warning: Member ZERO (macro definition) of file CompilerTypes.h is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:52: warning: Unsupported xml/html tag <limits> found
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/FastMath.h:472: warning: Member SquareRoot(const float32 x) (function) of namespace MARTe::FastMath is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:217: warning: Member IsEqual(float32 a1, float32 a2) (function) of namespace MARTe::SafeMath is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:225: warning: Member IsEqual(float64 a1, float64 a2) (function) of namespace MARTe::SafeMath is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:123: warning: explicit link request to 'Overflow' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:123: warning: explicit link request to 'Underflow' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:143: warning: explicit link request to 'Overflow' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:143: warning: explicit link request to 'Underflow' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:133: warning: explicit link request to 'Overflow' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:133: warning: explicit link request to 'Underflow' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:215: warning: Member Type2TypeDescriptor< int8 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:216: warning: Member Type2TypeDescriptor< int16 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:217: warning: Member Type2TypeDescriptor< int32 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:218: warning: Member Type2TypeDescriptor< int64 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:219: warning: Member Type2TypeDescriptor< uint8 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:220: warning: Member Type2TypeDescriptor< uint16 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:221: warning: Member Type2TypeDescriptor< uint32 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:222: warning: Member Type2TypeDescriptor< uint64 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:223: warning: Member Type2TypeDescriptor< float32 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:224: warning: Member Type2TypeDescriptor< float64 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/RuntimeEvaluatorFunction.h:249: warning: explicit link request to 'functionRecord' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:52: warning: Unsupported xml/html tag <limits> found
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:215: warning: Member Type2TypeDescriptor< int8 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:216: warning: Member Type2TypeDescriptor< int16 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:217: warning: Member Type2TypeDescriptor< int32 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:218: warning: Member Type2TypeDescriptor< int64 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:219: warning: Member Type2TypeDescriptor< uint8 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:220: warning: Member Type2TypeDescriptor< uint16 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:221: warning: Member Type2TypeDescriptor< uint32 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:222: warning: Member Type2TypeDescriptor< uint64 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:223: warning: Member Type2TypeDescriptor< float32 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:224: warning: Member Type2TypeDescriptor< float64 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/RuntimeEvaluatorFunction.h:249: warning: explicit link request to 'functionRecord' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/RuntimeEvaluatorFunction.h:249: warning: explicit link request to 'functionRecord' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/RuntimeEvaluatorFunction.h:253: warning: explicit link request to 'functionRecord' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L3Streams/GrammarInfo.h:130: warning: Member spare[64] (variable) of class MARTe::GrammarInfo is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/LexicalAnalyzer.h:102: warning: Member LexicalAnalyzer(StreamI &stream, const char8 *const terminalsIn, const char8 *const separatorsIn, const char8 *const oneLineCommentBeginIn, const char8 *const multipleLineCommentBeginIn, const char8 *const multipleLineCommentEndIn, const char8 *const keywordsIn) (function) of class MARTe::LexicalAnalyzer is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/MathExpressionParser.h:291: warning: explicit link request to 'stackMachineExpression' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/RuntimeEvaluator.h:391: warning: argument 'RPNCode' of command @param is not found in the argument list of MARTe::RuntimeEvaluator::RuntimeEvaluator(StreamString RPNCodeIn)
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/RuntimeEvaluator.h:394: warning: The following parameters of MARTe::RuntimeEvaluator::RuntimeEvaluator(StreamString RPNCodeIn) are not documented:
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:52: warning: Unsupported xml/html tag <limits> found
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:184: warning: Member MinValue() (function) of class MARTe::TypeCharacteristics is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:189: warning: Member MinValue() (function) of class MARTe::TypeCharacteristics is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:52: warning: Unsupported xml/html tag <limits> found
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/FastMath.h:472: warning: Member SquareRoot(const float32 x) (function) of namespace MARTe::FastMath is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:52: warning: Unsupported xml/html tag <limits> found
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:52: warning: Unsupported xml/html tag <limits> found
h1. Unit test review
*Date of the review:* 18/02/2021
*Person who did the review:* Andre Neto
*Version of source code:* 6027d3cbbba07f7f5035b410e74c30fe0fa7c6a4
*Result of coverage tests review:* %{background:yellow}TODO%
*Result of functional tests review:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
*List of non-conformities:*
*Functional tests*
%{color:red}ERR:% BitRange:GetNumberOfBits is not tested
%{color:red}ERR:% ProcessorType:GetProcessorMask is not tested
%{color:red}ERR:% ProcessorType:SetDefaultCPUs is not tested
%{color:red}ERR:% DataSourceI:AllocateMemory is not tested
%{color:red}ERR:% DataSourceI:GetBrokerName is not tested
%{color:red}ERR:% DataSourceI:GetFunctionSignalName is not tested
%{color:red}ERR:% DataSourceI:GetSignalMemoryBuffer is not tested
%{color:red}ERR:% DataSourceI:Purge is not tested
%{color:red}ERR:% DataSourceI:Synchronise is not tested
*GTest*
%{color:red}ERR:% Number of errors has increased. Number of tests: 4764. Current branch: 4. Reference branch: 3
%{color:green}OK:% Number of tests increased. Current branch: 4764. Reference branch: 4753
*Coverage*
%{color:yellow}WARN:% L1Portability/FastPollingMutexSem.cpp: was modified. line coverage is still OK (but has decreased). This branch (94.7 %% >= 90.0 %%). Reference branch (97.4 %% >= 90.0 %%)
%{color:yellow}WARN:% LoggerService.cpp: was modified. line coverage is still OK (but has decreased). This branch (96.4 %% >= 90.0 %%). Reference branch (97.6 %% >= 90.0 %%)
%{color:green}OK:% L0Types/BitSet.cpp: is new. Line coverage is OK: (98.0 %% >= 90.0 %%)
%{color:green}OK:% BasicTCPSocket.cpp: insufficient line coverage (but has improved): (88.7 %% < 90.0 %%). Reference branch (88.2 %% < 90.0 %%)
%{color:green}OK:% MutexSem.cpp: insufficient line coverage (but has improved): (86.8 %% < 90.0 %%). Reference branch (85.8 %% < 90.0 %%)
%{color:green}OK:% No coverage errors found
h1. Integration test review
*Date of the review:* 18/02/2021
*Person who did the review:* Andre Neto
*Version of source code:* 6027d3cbbba07f7f5035b410e74c30fe0fa7c6a4
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments:* N/A
h1. Acceptance test review
*Date of the review:* 18/02/2021
*Person who did the review:* Andre Neto
*Version of source code:* 6027d3cbbba07f7f5035b410e74c30fe0fa7c6a4
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments:* N/A
DESCRIBE CHANGES %{background:yellow}TODO%
*General*
Information
<pre>
The following files were detected as changed between branches #607_MaxCPUCores and develop
.gitignore
AUTHORS
Docs/User/source/_static/examples/Core/ThreadsExample1.cpp
EclipseLcov.sh
MakeDefaults/Lint/marte_flint_files.lnt
Resources/QA/qahelpers.py
Resources/QA/qautils.py
Source/Core/BareMetal/L0Types/BitRange.h
Source/Core/BareMetal/L0Types/BitSet.cpp
Source/Core/BareMetal/L0Types/BitSet.h
Source/Core/BareMetal/L0Types/CompilerTypes.h
Source/Core/BareMetal/L0Types/Makefile.inc
Source/Core/BareMetal/L1Portability/ProcessorType.cpp
Source/Core/BareMetal/L1Portability/ProcessorType.h
Source/Core/BareMetal/L5GAMs/DataSourceI.cpp
Source/Core/BareMetal/L5GAMs/DataSourceI.h
Source/Core/BareMetal/L5GAMs/MemoryMapSynchronisedInputBroker.cpp
Source/Core/Scheduler/L1Portability/Environment/Linux/MutexSem.cpp
Source/Core/Scheduler/L3Services/ThreadsInformationQuery.cpp
Test/Core/BareMetal/L0Types/BitSetTest.cpp
Test/Core/BareMetal/L0Types/BitSetTest.h
Test/Core/BareMetal/L0Types/Makefile.inc
Test/Core/BareMetal/L1Portability/ProcessorTypeTest.cpp
Test/Core/BareMetal/L1Portability/ProcessorTypeTest.h
Test/Core/BareMetal/L3Streams/IOBufferTest.cpp
Test/Core/BareMetal/L5GAMs/DataSourceITest.cpp
Test/Core/BareMetal/L5GAMs/DataSourceITest.h
Test/Core/BareMetal/L6App/LoaderTest.cpp
Test/GTest/BareMetal/L0Types/BitSetGTest.cpp
Test/GTest/BareMetal/L0Types/Makefile.inc
Test/GTest/BareMetal/L5GAMs/DataSourceIGTest.cpp
</pre>
%{color:green}OK:% no errors found.
h1. Requirements review
*Date of the review:* 18/02/2021
*Person who did the review:* Andre Neto
*Version of requirements:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
h1. Architecture & design review
*Date of the review:* 18/02/2021
*Person who did the review:* Andre Neto
*Version of architecture & design document:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
h1. Code and documentation review
*Date of the review:* 18/02/2021
*Person who did the review:* Andre Neto
*Version of source code:* 6027d3cbbba07f7f5035b410e74c30fe0fa7c6a4
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:*
%{background:red}Run flexelint and report% %{background:yellow}TODO%
*Headers*
%{color:red}ERR:% Invalid #includes sorted in file Docs/User/source/_static/examples/Core/ThreadsExample1.cpp
%{color:red}ERR:% Invalid #includes sorted in file Source/Core/BareMetal/L0Types/BitRange.h
%{color:red}ERR:% Invalid @author in file Source/Core/BareMetal/L1Portability/ProcessorType.cpp
%{color:red}ERR:% Invalid #includes sorted in file Source/Core/BareMetal/L1Portability/ProcessorType.h
%{color:red}ERR:% Invalid #includes sorted in file Source/Core/Scheduler/L1Portability/Environment/Linux/MutexSem.cpp
%{color:red}ERR:% Invalid #includes sorted in file Test/Core/BareMetal/L0Types/BitSetTest.h
%{color:red}ERR:% Invalid #includes sorted in file Test/Core/BareMetal/L1Portability/ProcessorTypeTest.cpp
%{color:red}ERR:% Invalid #includes sorted in file Test/Core/BareMetal/L3Streams/IOBufferTest.cpp
%{color:red}ERR:% Invalid @brief in file Test/Core/BareMetal/L5GAMs/DataSourceITest.cpp
%{color:red}ERR:% Invalid #includes sorted in file Test/GTest/BareMetal/L0Types/BitSetGTest.cpp
%{color:red}ERR:% Invalid #includes sorted in file Test/GTest/BareMetal/L5GAMs/DataSourceIGTest.cpp
*Lint includes*
%{color:green}OK:% All files are being included for linting
%{color:green}OK:% no errors found.
*Linter*
%{color:red}ERR:% Note 974: Worst case function for stack usage: 'MARTe::ConfigurationDatabase::Copy' is recursive, loop contains call to 'MARTe::ConfigurationDatabase::Copy'. See +stack for a full report. [MISRA C++ Rule 7-5-4]
*Doxygen*
%{color:red}ERR:% warning: Tag `XML_SCHEMA' at line 1788 of file `Doxyfile' has become obsolete.
%{color:red}ERR:% warning: Tag `XML_DTD' at line 1794 of file `Doxyfile' has become obsolete.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:52: warning: Unsupported xml/html tag <limits> found
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/RuntimeEvaluatorFunction.h:249: warning: explicit link request to 'functionRecord' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/CompilerTypes.h:117: warning: Member MAX(a, b) (macro definition) of file CompilerTypes.h is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/CompilerTypes.h:118: warning: Member MIN(a, b) (macro definition) of file CompilerTypes.h is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/CompilerTypes.h:120: warning: Member ONE (macro definition) of file CompilerTypes.h is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/CompilerTypes.h:121: warning: Member ZERO (macro definition) of file CompilerTypes.h is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:52: warning: Unsupported xml/html tag <limits> found
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/FastMath.h:472: warning: Member SquareRoot(const float32 x) (function) of namespace MARTe::FastMath is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:217: warning: Member IsEqual(float32 a1, float32 a2) (function) of namespace MARTe::SafeMath is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:225: warning: Member IsEqual(float64 a1, float64 a2) (function) of namespace MARTe::SafeMath is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:123: warning: explicit link request to 'Overflow' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:123: warning: explicit link request to 'Underflow' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:143: warning: explicit link request to 'Overflow' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:143: warning: explicit link request to 'Underflow' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:133: warning: explicit link request to 'Overflow' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/SafeMath.h:133: warning: explicit link request to 'Underflow' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:215: warning: Member Type2TypeDescriptor< int8 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:216: warning: Member Type2TypeDescriptor< int16 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:217: warning: Member Type2TypeDescriptor< int32 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:218: warning: Member Type2TypeDescriptor< int64 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:219: warning: Member Type2TypeDescriptor< uint8 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:220: warning: Member Type2TypeDescriptor< uint16 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:221: warning: Member Type2TypeDescriptor< uint32 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:222: warning: Member Type2TypeDescriptor< uint64 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:223: warning: Member Type2TypeDescriptor< float32 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:224: warning: Member Type2TypeDescriptor< float64 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/RuntimeEvaluatorFunction.h:249: warning: explicit link request to 'functionRecord' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:52: warning: Unsupported xml/html tag <limits> found
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:215: warning: Member Type2TypeDescriptor< int8 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:216: warning: Member Type2TypeDescriptor< int16 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:217: warning: Member Type2TypeDescriptor< int32 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:218: warning: Member Type2TypeDescriptor< int64 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:219: warning: Member Type2TypeDescriptor< uint8 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:220: warning: Member Type2TypeDescriptor< uint16 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:221: warning: Member Type2TypeDescriptor< uint32 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:222: warning: Member Type2TypeDescriptor< uint64 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:223: warning: Member Type2TypeDescriptor< float32 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/TypeDescriptor.h:224: warning: Member Type2TypeDescriptor< float64 >() (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/RuntimeEvaluatorFunction.h:249: warning: explicit link request to 'functionRecord' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/RuntimeEvaluatorFunction.h:249: warning: explicit link request to 'functionRecord' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/RuntimeEvaluatorFunction.h:253: warning: explicit link request to 'functionRecord' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L3Streams/GrammarInfo.h:130: warning: Member spare[64] (variable) of class MARTe::GrammarInfo is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/LexicalAnalyzer.h:102: warning: Member LexicalAnalyzer(StreamI &stream, const char8 *const terminalsIn, const char8 *const separatorsIn, const char8 *const oneLineCommentBeginIn, const char8 *const multipleLineCommentBeginIn, const char8 *const multipleLineCommentEndIn, const char8 *const keywordsIn) (function) of class MARTe::LexicalAnalyzer is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/MathExpressionParser.h:291: warning: explicit link request to 'stackMachineExpression' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/RuntimeEvaluator.h:391: warning: argument 'RPNCode' of command @param is not found in the argument list of MARTe::RuntimeEvaluator::RuntimeEvaluator(StreamString RPNCodeIn)
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L4Configuration/RuntimeEvaluator.h:394: warning: The following parameters of MARTe::RuntimeEvaluator::RuntimeEvaluator(StreamString RPNCodeIn) are not documented:
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:52: warning: Unsupported xml/html tag <limits> found
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:184: warning: Member MinValue() (function) of class MARTe::TypeCharacteristics is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:189: warning: Member MinValue() (function) of class MARTe::TypeCharacteristics is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:52: warning: Unsupported xml/html tag <limits> found
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L1Portability/FastMath.h:472: warning: Member SquareRoot(const float32 x) (function) of namespace MARTe::FastMath is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:52: warning: Unsupported xml/html tag <limits> found
%{color:red}ERR:% /home/aneto/Projects/MARTe2-dev/Source/Core/BareMetal/L0Types/TypeCharacteristics.h:52: warning: Unsupported xml/html tag <limits> found
h1. Unit test review
*Date of the review:* 18/02/2021
*Person who did the review:* Andre Neto
*Version of source code:* 6027d3cbbba07f7f5035b410e74c30fe0fa7c6a4
*Result of coverage tests review:* %{background:yellow}TODO%
*Result of functional tests review:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
*List of non-conformities:*
*Functional tests*
%{color:red}ERR:% BitRange:GetNumberOfBits is not tested
%{color:red}ERR:% ProcessorType:GetProcessorMask is not tested
%{color:red}ERR:% ProcessorType:SetDefaultCPUs is not tested
%{color:red}ERR:% DataSourceI:AllocateMemory is not tested
%{color:red}ERR:% DataSourceI:GetBrokerName is not tested
%{color:red}ERR:% DataSourceI:GetFunctionSignalName is not tested
%{color:red}ERR:% DataSourceI:GetSignalMemoryBuffer is not tested
%{color:red}ERR:% DataSourceI:Purge is not tested
%{color:red}ERR:% DataSourceI:Synchronise is not tested
*GTest*
%{color:red}ERR:% Number of errors has increased. Number of tests: 4764. Current branch: 4. Reference branch: 3
%{color:green}OK:% Number of tests increased. Current branch: 4764. Reference branch: 4753
*Coverage*
%{color:yellow}WARN:% L1Portability/FastPollingMutexSem.cpp: was modified. line coverage is still OK (but has decreased). This branch (94.7 %% >= 90.0 %%). Reference branch (97.4 %% >= 90.0 %%)
%{color:yellow}WARN:% LoggerService.cpp: was modified. line coverage is still OK (but has decreased). This branch (96.4 %% >= 90.0 %%). Reference branch (97.6 %% >= 90.0 %%)
%{color:green}OK:% L0Types/BitSet.cpp: is new. Line coverage is OK: (98.0 %% >= 90.0 %%)
%{color:green}OK:% BasicTCPSocket.cpp: insufficient line coverage (but has improved): (88.7 %% < 90.0 %%). Reference branch (88.2 %% < 90.0 %%)
%{color:green}OK:% MutexSem.cpp: insufficient line coverage (but has improved): (86.8 %% < 90.0 %%). Reference branch (85.8 %% < 90.0 %%)
%{color:green}OK:% No coverage errors found
h1. Integration test review
*Date of the review:* 18/02/2021
*Person who did the review:* Andre Neto
*Version of source code:* 6027d3cbbba07f7f5035b410e74c30fe0fa7c6a4
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments:* N/A
h1. Acceptance test review
*Date of the review:* 18/02/2021
*Person who did the review:* Andre Neto
*Version of source code:* 6027d3cbbba07f7f5035b410e74c30fe0fa7c6a4
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments:* N/A