User story #745
Updated by André Neto about 4 years ago
DESCRIBE CHANGES %{background:yellow}TODO%
*General*
Information
<pre>
The following files were detected as changed between branches #745_LinuxTimer_TCNPlugin and develop
Lint/marte_components_flint_files.lnt
QAHelper.sh
Source/Components/DataSources/LinuxTimer/HighResolutionTimeProvider.cpp
Source/Components/DataSources/LinuxTimer/HighResolutionTimeProvider.h
Source/Components/DataSources/LinuxTimer/LinuxTimer.cpp
Source/Components/DataSources/LinuxTimer/LinuxTimer.h
Source/Components/DataSources/LinuxTimer/Makefile.gcc
Source/Components/DataSources/LinuxTimer/Makefile.inc
Source/Components/DataSources/LinuxTimer/TimeProvider.cpp
Source/Components/DataSources/LinuxTimer/TimeProvider.h
Source/Components/Interfaces/Makefile.cov
Source/Components/Interfaces/Makefile.inc
Source/Components/Interfaces/TcnTimeProvider/Makefile.cov
Source/Components/Interfaces/TcnTimeProvider/Makefile.gcc
Source/Components/Interfaces/TcnTimeProvider/Makefile.inc
Source/Components/Interfaces/TcnTimeProvider/TcnTimeProvider.cpp
Source/Components/Interfaces/TcnTimeProvider/TcnTimeProvider.h
Test/Components/DataSources/LinuxTimer/HighResolutionTimeProviderGTest.cpp
Test/Components/DataSources/LinuxTimer/HighResolutionTimeProviderTest.cpp
Test/Components/DataSources/LinuxTimer/HighResolutionTimeProviderTest.h
Test/Components/DataSources/LinuxTimer/LinuxTimerGTest.cpp
Test/Components/DataSources/LinuxTimer/LinuxTimerTest.cpp
Test/Components/DataSources/LinuxTimer/LinuxTimerTest.h
Test/Components/DataSources/LinuxTimer/Makefile.cov
Test/Components/DataSources/LinuxTimer/Makefile.gcc
Test/Components/DataSources/LinuxTimer/Makefile.inc
Test/Components/DataSources/LinuxTimer/TimeProviderTest.cpp
Test/Components/DataSources/LinuxTimer/TimeProviderTest.h
Test/Components/Interfaces/Makefile.cov
Test/Components/Interfaces/Makefile.inc
Test/Components/Interfaces/TcnTimeProvider/.gitignore
Test/Components/Interfaces/TcnTimeProvider/Makefile.cov
Test/Components/Interfaces/TcnTimeProvider/Makefile.gcc
Test/Components/Interfaces/TcnTimeProvider/Makefile.inc
Test/Components/Interfaces/TcnTimeProvider/TcnTimeProviderGTest.cpp
Test/Components/Interfaces/TcnTimeProvider/TcnTimeProviderTest.cpp
Test/Components/Interfaces/TcnTimeProvider/TcnTimeProviderTest.h
</pre>
%{color:green}OK:% no errors found.
h1. Requirements review
*Date of Add the review:* 26/03/2021
*Person who did LinuxTimer TCN plugin to the review:* TODO
*Version of requirements:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
h1. Architecture & design review
*Date of the review:* 26/03/2021
*Person who did the review:* TODO
*Version of architecture & design document:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
h1. Code and documentation review
*Date of the review:* 26/03/2021
*Person who did the review:* TODO
*Version of source code:* 2efe6d137e0bfc829ee07f6d5dc689e8a8723447
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:*
%{background:red}Run flexelint and report% %{background:yellow}TODO%
*Headers*
%{color:green}OK:% All headers are correctly formatted
%{color:green}OK:% no errors found.
*Lint includes*
%{color:green}OK:% All files are being included for linting
%{color:green}OK:% no errors found.
*Linter*
%{color:red}ERR:% /home/aneto/MARTe2-dev/MakeDefaults/Lint/marte_flint_exceptions.lnt 15
%{color:red}ERR:% Note 974: Worst case function for stack usage: 'MARTe::MDSStructuredDataI::Copy' is recursive, loop contains call to 'MARTe::MDSStructuredDataI::Copy'. See +stack for a full report. [MISRA C++ Rule 7-5-4]
*Doxygen*
%{color:red}ERR:% warning: Tag `XML_SCHEMA' at line 1788 of file `Doxyfile' has become obsolete.
%{color:red}ERR:% warning: Tag `XML_DTD' at line 1794 of file `Doxyfile' has become obsolete.
%{color:red}ERR:% warning: source ./Docs/Assets/Snippets/Parsing/MathGrammar.ll is not a readable file or directory... skipping.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:45: warning: Compound OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:60: warning: Compound OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:354: warning: Member EPICSPVAStructureDataI::ReadArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value) (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:417: warning: Member EPICSPVAStructureDataI::WriteArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value, const uint32 &size) (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:54: warning: Member OPCUANodeSettings (typedef) of namespace OPCUA is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:68: warning: Member OPCUAObjectSettings (typedef) of namespace OPCUA is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:286: warning: Unsupported xml/html tag <osal> found
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/LoggerDataSource/LoggerBroker.h:76: warning: Member SetPeriod(const uint32 cyclePeriodIn) (function) of class MARTe::LoggerBroker is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/LoggerDataSource/LoggerDataSource.h:68: warning: Member Initialise(StructuredDataI &data) (function) of class MARTe::LoggerDataSource is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:90: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath)
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:95: warning: The following parameters of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented:
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:79: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath)
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:84: warning: The following parameters of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented:
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/ProfinetDataSource.h:339: warning: expected <li> tag but found TK_LNKWORD token instead!
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/ProfinetDataSource.h:622: warning: unexpected end of comment while inside <ul> block
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:126: warning: The following parameters of MARTe::SimulinkDataI::PrintData(const uint64 maxNameLength=0u, StreamString additionalText="") are not documented:
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:269: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:269: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:269: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:291: warning: explicit link request to 'offsetBasedSize' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:46: warning: Member attr (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:47: warning: Member value (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:48: warning: Member nodeId (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:49: warning: Member nodeName (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:50: warning: Member parentNodeId (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:51: warning: Member parentReferenceNodeId (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:61: warning: Member attr (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:62: warning: Member nodeId (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:63: warning: Member nodeName (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:64: warning: Member parentNodeId (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:65: warning: Member parentReferenceNodeId (variable) of class OPCUA::ObjectProperties is not documented.
h1. Unit test review
*Date of the review:* 26/03/2021
*Person who did the review:* TODO
*Version of source code:* 2efe6d137e0bfc829ee07f6d5dc689e8a8723447
*Result of coverage tests review:* %{background:yellow}TODO%
*Result of functional tests review:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
*List of non-conformities:*
*Functional tests*
%{color:red}ERR:% Test file not found: Test/Components/DataSources/LinuxTimer/TimeProviderGTest.cpp
%{color:green}OK:% All public methods are being tested at least once
*GTest*
%{color:yellow}WARN:% Number of errors has not changed (but there are still errors). Number of tests: 1866. Current branch: 10. Reference branch: 10
%{color:green}OK:% Number of tests increased. Current branch: 1866. Reference branch: 1843
*Unsolved Failing Tests*
%{color:red}ERR:% Test_Read_ExtensionObject_Complex
%{color:red}ERR:% Test_Read_ExtensionObject_Array
%{color:red}ERR:% Test_Write_ExtensionObject_Complex
%{color:red}ERR:% Test_Write_ExtensionObject_Array
%{color:red}ERR:% TestOPCUAMethodCall_Array
%{color:red}ERR:% Test_Read_ExtensionObject_Complex
%{color:red}ERR:% Test_Read_ExtensionObject_Array
%{color:red}ERR:% Test_Write_ExtensionObject_Complex
%{color:red}ERR:% Test_Write_ExtensionObject_Array
%{color:red}ERR:% TestOPCUAMethodCall_Array
*New Failing Tests*
*Solved Failing Tests*
*Coverage*
%{color:red}ERR:% DataSources/EPICSCA/EPICSCAInput.cpp: insufficient line coverage: (1.5 %% < 90.0 %%). Reference branch (91.4 %% < 90.0 %%)
%{color:red}ERR:% DataSources/EPICSCA/EPICSCAInput.h: insufficient line coverage (new file): (0.0 %% < 90.0 %%)
%{color:red}ERR:% DataSources/EPICSCA/EPICSCAOutput.cpp: insufficient line coverage: (1.2 %% < 90.0 %%). Reference branch (99.0 %% < 90.0 %%)
%{color:red}ERR:% DataSources/EPICSPVA/EPICSPVAChannelWrapper.cpp: insufficient line coverage: (0.4 %% < 90.0 %%). Reference branch (94.5 %% < 90.0 %%)
%{color:red}ERR:% DataSources/EPICSPVA/EPICSPVAChannelWrapper.h: insufficient line coverage: (0.0 %% < 90.0 %%). Reference branch (90.3 %% < 90.0 %%)
%{color:red}ERR:% DataSources/EPICSPVA/EPICSPVAInput.cpp: insufficient line coverage: (2.2 %% < 90.0 %%). Reference branch (97.8 %% < 90.0 %%)
%{color:red}ERR:% DataSources/EPICSPVA/EPICSPVAOutput.cpp: insufficient line coverage: (1.9 %% < 90.0 %%). Reference branch (100.0 %% < 90.0 %%)
%{color:red}ERR:% DataSources/OPCUADataSource/OPCUAClientI.cpp: insufficient line coverage: (0.9 %% < 90.0 %%). Reference branch (87.0 %% < 90.0 %%)
%{color:red}ERR:% DataSources/OPCUADataS.../OPCUAClientMethod.cpp: insufficient line coverage: (0.3 %% < 90.0 %%). Reference branch (85.5 %% < 90.0 %%)
%{color:red}ERR:% DataSources/OPCUADataSource/OPCUAClientRead.cpp: insufficient line coverage: (0.5 %% < 90.0 %%). Reference branch (83.1 %% < 90.0 %%)
%{color:red}ERR:% DataSources/OPCUADataS...e/OPCUAClientWrite.cpp: insufficient line coverage: (0.3 %% < 90.0 %%). Reference branch (84.5 %% < 90.0 %%)
%{color:red}ERR:% DataSources/OPCUADataSource/OPCUADSInput.cpp: insufficient line coverage: (0.5 %% < 90.0 %%). Reference branch (97.1 %% < 90.0 %%)
%{color:red}ERR:% DataSources/OPCUADataSource/OPCUADSOutput.cpp: insufficient line coverage: (0.6 %% < 90.0 %%). Reference branch (92.4 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICS/EPICSCAClient.cpp: insufficient line coverage: (3.8 %% < 90.0 %%). Reference branch (77.1 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICS/EPICSPV.cpp: insufficient line coverage: (1.1 %% < 90.0 %%). Reference branch (98.2 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EP...tryDatabaseService.cpp: insufficient line coverage: (4.5 %% < 90.0 %%). Reference branch (100.0 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSPVA2V3Service.cpp: insufficient line coverage: (1.1 %% < 90.0 %%). Reference branch (97.8 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSPVADatabase.cpp: insufficient line coverage: (2.7 %% < 90.0 %%). Reference branch (91.9 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSPVAHelper.cpp: insufficient line coverage: (0.3 %% < 90.0 %%). Reference branch (96.2 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSPVAMessageI.cpp: insufficient line coverage: (5.1 %% < 90.0 %%). Reference branch (94.9 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSPVARecord.cpp: insufficient line coverage: (1.1 %% < 90.0 %%). Reference branch (92.9 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSPVAStructureDataI.cpp: insufficient line coverage: (0.3 %% < 90.0 %%). Reference branch (92.5 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSPVAStructureDataI.h: insufficient line coverage: (0.0 %% < 90.0 %%). Reference branch (98.5 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSRPCClient.cpp: insufficient line coverage: (10.7 %% < 90.0 %%). Reference branch (89.3 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EP...lientMessageFilter.cpp: insufficient line coverage: (4.1 %% < 90.0 %%). Reference branch (91.8 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSRPCServer.cpp: insufficient line coverage: (3.9 %% < 90.0 %%). Reference branch (92.2 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSRPCService.cpp: insufficient line coverage: (20.0 %% < 90.0 %%). Reference branch (100.0 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSRPCServiceAdapter.cpp: insufficient line coverage: (10.0 %% < 90.0 %%). Reference branch (100.0 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/OPCUA/OPCUAMessageClient.cpp: insufficient line coverage: (0.9 %% < 90.0 %%). Reference branch (78.9 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/OPCUA/OPCUANode.cpp: insufficient line coverage: (2.2 %% < 90.0 %%). Reference branch (97.8 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/OPCUA/OPCUAObject.cpp: insufficient line coverage: (7.7 %% < 90.0 %%). Reference branch (100.0 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/OPCUA/OPCUAReferenceContainer.cpp: insufficient line coverage: (3.6 %% < 90.0 %%). Reference branch (100.0 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/OPCUA/OPCUAServer.cpp: insufficient line coverage: (1.0 %% < 90.0 %%). Reference branch (94.4 %% < 90.0 %%)
%{color:green}OK:% DataSources/EpicsDataSource/Platform.cpp: insufficient line coverage (but has improved): (84.5 %% < 90.0 %%). Reference branch (81.0 %% < 90.0 %%)
%{color:green}OK:% DataSources/EpicsDataSource/SharedDataArea.cpp: was modified. line coverage is still OK. This branch (95.8 %% >= 90.0 %%). Reference branch (94.4 %% >= 90.0 %%)
%{color:green}OK:% DataSources/FileDataSource/FileReader.cpp: was modified. line coverage is still OK. This branch (96.8 %% >= 90.0 %%). Reference branch (96.6 %% >= 90.0 %%)
h1. Integration test review
*Date of the review:* 26/03/2021
*Person who did the review:* TODO
*Version of source code:* 2efe6d137e0bfc829ee07f6d5dc689e8a8723447
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments:* N/A
h1. Acceptance test review
*Date of the review:* 26/03/2021
*Person who did the review:* TODO
*Version of source code:* 2efe6d137e0bfc829ee07f6d5dc689e8a8723447
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments:* N/A
Interfaces folder.
*General*
Information
<pre>
The following files were detected as changed between branches #745_LinuxTimer_TCNPlugin and develop
Lint/marte_components_flint_files.lnt
QAHelper.sh
Source/Components/DataSources/LinuxTimer/HighResolutionTimeProvider.cpp
Source/Components/DataSources/LinuxTimer/HighResolutionTimeProvider.h
Source/Components/DataSources/LinuxTimer/LinuxTimer.cpp
Source/Components/DataSources/LinuxTimer/LinuxTimer.h
Source/Components/DataSources/LinuxTimer/Makefile.gcc
Source/Components/DataSources/LinuxTimer/Makefile.inc
Source/Components/DataSources/LinuxTimer/TimeProvider.cpp
Source/Components/DataSources/LinuxTimer/TimeProvider.h
Source/Components/Interfaces/Makefile.cov
Source/Components/Interfaces/Makefile.inc
Source/Components/Interfaces/TcnTimeProvider/Makefile.cov
Source/Components/Interfaces/TcnTimeProvider/Makefile.gcc
Source/Components/Interfaces/TcnTimeProvider/Makefile.inc
Source/Components/Interfaces/TcnTimeProvider/TcnTimeProvider.cpp
Source/Components/Interfaces/TcnTimeProvider/TcnTimeProvider.h
Test/Components/DataSources/LinuxTimer/HighResolutionTimeProviderGTest.cpp
Test/Components/DataSources/LinuxTimer/HighResolutionTimeProviderTest.cpp
Test/Components/DataSources/LinuxTimer/HighResolutionTimeProviderTest.h
Test/Components/DataSources/LinuxTimer/LinuxTimerGTest.cpp
Test/Components/DataSources/LinuxTimer/LinuxTimerTest.cpp
Test/Components/DataSources/LinuxTimer/LinuxTimerTest.h
Test/Components/DataSources/LinuxTimer/Makefile.cov
Test/Components/DataSources/LinuxTimer/Makefile.gcc
Test/Components/DataSources/LinuxTimer/Makefile.inc
Test/Components/DataSources/LinuxTimer/TimeProviderTest.cpp
Test/Components/DataSources/LinuxTimer/TimeProviderTest.h
Test/Components/Interfaces/Makefile.cov
Test/Components/Interfaces/Makefile.inc
Test/Components/Interfaces/TcnTimeProvider/.gitignore
Test/Components/Interfaces/TcnTimeProvider/Makefile.cov
Test/Components/Interfaces/TcnTimeProvider/Makefile.gcc
Test/Components/Interfaces/TcnTimeProvider/Makefile.inc
Test/Components/Interfaces/TcnTimeProvider/TcnTimeProviderGTest.cpp
Test/Components/Interfaces/TcnTimeProvider/TcnTimeProviderTest.cpp
Test/Components/Interfaces/TcnTimeProvider/TcnTimeProviderTest.h
</pre>
%{color:green}OK:% no errors found.
h1. Requirements review
*Date of Add the review:* 26/03/2021
*Person who did LinuxTimer TCN plugin to the review:* TODO
*Version of requirements:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
h1. Architecture & design review
*Date of the review:* 26/03/2021
*Person who did the review:* TODO
*Version of architecture & design document:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
h1. Code and documentation review
*Date of the review:* 26/03/2021
*Person who did the review:* TODO
*Version of source code:* 2efe6d137e0bfc829ee07f6d5dc689e8a8723447
*Result of review:* %{background:yellow}TODO%
*List of non-conformities:*
%{background:red}Run flexelint and report% %{background:yellow}TODO%
*Headers*
%{color:green}OK:% All headers are correctly formatted
%{color:green}OK:% no errors found.
*Lint includes*
%{color:green}OK:% All files are being included for linting
%{color:green}OK:% no errors found.
*Linter*
%{color:red}ERR:% /home/aneto/MARTe2-dev/MakeDefaults/Lint/marte_flint_exceptions.lnt 15
%{color:red}ERR:% Note 974: Worst case function for stack usage: 'MARTe::MDSStructuredDataI::Copy' is recursive, loop contains call to 'MARTe::MDSStructuredDataI::Copy'. See +stack for a full report. [MISRA C++ Rule 7-5-4]
*Doxygen*
%{color:red}ERR:% warning: Tag `XML_SCHEMA' at line 1788 of file `Doxyfile' has become obsolete.
%{color:red}ERR:% warning: Tag `XML_DTD' at line 1794 of file `Doxyfile' has become obsolete.
%{color:red}ERR:% warning: source ./Docs/Assets/Snippets/Parsing/MathGrammar.ll is not a readable file or directory... skipping.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:45: warning: Compound OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:60: warning: Compound OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:354: warning: Member EPICSPVAStructureDataI::ReadArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value) (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:417: warning: Member EPICSPVAStructureDataI::WriteArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value, const uint32 &size) (function) of namespace MARTe is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:54: warning: Member OPCUANodeSettings (typedef) of namespace OPCUA is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:68: warning: Member OPCUAObjectSettings (typedef) of namespace OPCUA is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:286: warning: Unsupported xml/html tag <osal> found
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/LoggerDataSource/LoggerBroker.h:76: warning: Member SetPeriod(const uint32 cyclePeriodIn) (function) of class MARTe::LoggerBroker is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/LoggerDataSource/LoggerDataSource.h:68: warning: Member Initialise(StructuredDataI &data) (function) of class MARTe::LoggerDataSource is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:90: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath)
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:95: warning: The following parameters of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented:
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:79: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath)
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:84: warning: The following parameters of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented:
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/ProfinetDataSource.h:339: warning: expected <li> tag but found TK_LNKWORD token instead!
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/ProfinetDataSource.h:622: warning: unexpected end of comment while inside <ul> block
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:126: warning: The following parameters of MARTe::SimulinkDataI::PrintData(const uint64 maxNameLength=0u, StreamString additionalText="") are not documented:
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:269: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:269: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:269: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:291: warning: explicit link request to 'offsetBasedSize' could not be resolved
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:46: warning: Member attr (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:47: warning: Member value (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:48: warning: Member nodeId (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:49: warning: Member nodeName (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:50: warning: Member parentNodeId (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:51: warning: Member parentReferenceNodeId (variable) of class OPCUA::NodeProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:61: warning: Member attr (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:62: warning: Member nodeId (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:63: warning: Member nodeName (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:64: warning: Member parentNodeId (variable) of class OPCUA::ObjectProperties is not documented.
%{color:red}ERR:% /home/aneto/Projects/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:65: warning: Member parentReferenceNodeId (variable) of class OPCUA::ObjectProperties is not documented.
h1. Unit test review
*Date of the review:* 26/03/2021
*Person who did the review:* TODO
*Version of source code:* 2efe6d137e0bfc829ee07f6d5dc689e8a8723447
*Result of coverage tests review:* %{background:yellow}TODO%
*Result of functional tests review:* %{background:yellow}TODO%
*Result of review:* %{background:yellow}TODO%
*Comments:* %{background:yellow}TODO%
*List of non-conformities:*
*Functional tests*
%{color:red}ERR:% Test file not found: Test/Components/DataSources/LinuxTimer/TimeProviderGTest.cpp
%{color:green}OK:% All public methods are being tested at least once
*GTest*
%{color:yellow}WARN:% Number of errors has not changed (but there are still errors). Number of tests: 1866. Current branch: 10. Reference branch: 10
%{color:green}OK:% Number of tests increased. Current branch: 1866. Reference branch: 1843
*Unsolved Failing Tests*
%{color:red}ERR:% Test_Read_ExtensionObject_Complex
%{color:red}ERR:% Test_Read_ExtensionObject_Array
%{color:red}ERR:% Test_Write_ExtensionObject_Complex
%{color:red}ERR:% Test_Write_ExtensionObject_Array
%{color:red}ERR:% TestOPCUAMethodCall_Array
%{color:red}ERR:% Test_Read_ExtensionObject_Complex
%{color:red}ERR:% Test_Read_ExtensionObject_Array
%{color:red}ERR:% Test_Write_ExtensionObject_Complex
%{color:red}ERR:% Test_Write_ExtensionObject_Array
%{color:red}ERR:% TestOPCUAMethodCall_Array
*New Failing Tests*
*Solved Failing Tests*
*Coverage*
%{color:red}ERR:% DataSources/EPICSCA/EPICSCAInput.cpp: insufficient line coverage: (1.5 %% < 90.0 %%). Reference branch (91.4 %% < 90.0 %%)
%{color:red}ERR:% DataSources/EPICSCA/EPICSCAInput.h: insufficient line coverage (new file): (0.0 %% < 90.0 %%)
%{color:red}ERR:% DataSources/EPICSCA/EPICSCAOutput.cpp: insufficient line coverage: (1.2 %% < 90.0 %%). Reference branch (99.0 %% < 90.0 %%)
%{color:red}ERR:% DataSources/EPICSPVA/EPICSPVAChannelWrapper.cpp: insufficient line coverage: (0.4 %% < 90.0 %%). Reference branch (94.5 %% < 90.0 %%)
%{color:red}ERR:% DataSources/EPICSPVA/EPICSPVAChannelWrapper.h: insufficient line coverage: (0.0 %% < 90.0 %%). Reference branch (90.3 %% < 90.0 %%)
%{color:red}ERR:% DataSources/EPICSPVA/EPICSPVAInput.cpp: insufficient line coverage: (2.2 %% < 90.0 %%). Reference branch (97.8 %% < 90.0 %%)
%{color:red}ERR:% DataSources/EPICSPVA/EPICSPVAOutput.cpp: insufficient line coverage: (1.9 %% < 90.0 %%). Reference branch (100.0 %% < 90.0 %%)
%{color:red}ERR:% DataSources/OPCUADataSource/OPCUAClientI.cpp: insufficient line coverage: (0.9 %% < 90.0 %%). Reference branch (87.0 %% < 90.0 %%)
%{color:red}ERR:% DataSources/OPCUADataS.../OPCUAClientMethod.cpp: insufficient line coverage: (0.3 %% < 90.0 %%). Reference branch (85.5 %% < 90.0 %%)
%{color:red}ERR:% DataSources/OPCUADataSource/OPCUAClientRead.cpp: insufficient line coverage: (0.5 %% < 90.0 %%). Reference branch (83.1 %% < 90.0 %%)
%{color:red}ERR:% DataSources/OPCUADataS...e/OPCUAClientWrite.cpp: insufficient line coverage: (0.3 %% < 90.0 %%). Reference branch (84.5 %% < 90.0 %%)
%{color:red}ERR:% DataSources/OPCUADataSource/OPCUADSInput.cpp: insufficient line coverage: (0.5 %% < 90.0 %%). Reference branch (97.1 %% < 90.0 %%)
%{color:red}ERR:% DataSources/OPCUADataSource/OPCUADSOutput.cpp: insufficient line coverage: (0.6 %% < 90.0 %%). Reference branch (92.4 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICS/EPICSCAClient.cpp: insufficient line coverage: (3.8 %% < 90.0 %%). Reference branch (77.1 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICS/EPICSPV.cpp: insufficient line coverage: (1.1 %% < 90.0 %%). Reference branch (98.2 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EP...tryDatabaseService.cpp: insufficient line coverage: (4.5 %% < 90.0 %%). Reference branch (100.0 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSPVA2V3Service.cpp: insufficient line coverage: (1.1 %% < 90.0 %%). Reference branch (97.8 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSPVADatabase.cpp: insufficient line coverage: (2.7 %% < 90.0 %%). Reference branch (91.9 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSPVAHelper.cpp: insufficient line coverage: (0.3 %% < 90.0 %%). Reference branch (96.2 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSPVAMessageI.cpp: insufficient line coverage: (5.1 %% < 90.0 %%). Reference branch (94.9 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSPVARecord.cpp: insufficient line coverage: (1.1 %% < 90.0 %%). Reference branch (92.9 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSPVAStructureDataI.cpp: insufficient line coverage: (0.3 %% < 90.0 %%). Reference branch (92.5 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSPVAStructureDataI.h: insufficient line coverage: (0.0 %% < 90.0 %%). Reference branch (98.5 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSRPCClient.cpp: insufficient line coverage: (10.7 %% < 90.0 %%). Reference branch (89.3 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EP...lientMessageFilter.cpp: insufficient line coverage: (4.1 %% < 90.0 %%). Reference branch (91.8 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSRPCServer.cpp: insufficient line coverage: (3.9 %% < 90.0 %%). Reference branch (92.2 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSRPCService.cpp: insufficient line coverage: (20.0 %% < 90.0 %%). Reference branch (100.0 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/EPICSPVA/EPICSRPCServiceAdapter.cpp: insufficient line coverage: (10.0 %% < 90.0 %%). Reference branch (100.0 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/OPCUA/OPCUAMessageClient.cpp: insufficient line coverage: (0.9 %% < 90.0 %%). Reference branch (78.9 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/OPCUA/OPCUANode.cpp: insufficient line coverage: (2.2 %% < 90.0 %%). Reference branch (97.8 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/OPCUA/OPCUAObject.cpp: insufficient line coverage: (7.7 %% < 90.0 %%). Reference branch (100.0 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/OPCUA/OPCUAReferenceContainer.cpp: insufficient line coverage: (3.6 %% < 90.0 %%). Reference branch (100.0 %% < 90.0 %%)
%{color:red}ERR:% Interfaces/OPCUA/OPCUAServer.cpp: insufficient line coverage: (1.0 %% < 90.0 %%). Reference branch (94.4 %% < 90.0 %%)
%{color:green}OK:% DataSources/EpicsDataSource/Platform.cpp: insufficient line coverage (but has improved): (84.5 %% < 90.0 %%). Reference branch (81.0 %% < 90.0 %%)
%{color:green}OK:% DataSources/EpicsDataSource/SharedDataArea.cpp: was modified. line coverage is still OK. This branch (95.8 %% >= 90.0 %%). Reference branch (94.4 %% >= 90.0 %%)
%{color:green}OK:% DataSources/FileDataSource/FileReader.cpp: was modified. line coverage is still OK. This branch (96.8 %% >= 90.0 %%). Reference branch (96.6 %% >= 90.0 %%)
h1. Integration test review
*Date of the review:* 26/03/2021
*Person who did the review:* TODO
*Version of source code:* 2efe6d137e0bfc829ee07f6d5dc689e8a8723447
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments:* N/A
h1. Acceptance test review
*Date of the review:* 26/03/2021
*Person who did the review:* TODO
*Version of source code:* 2efe6d137e0bfc829ee07f6d5dc689e8a8723447
*Result of review:* N/A
*List of non-conformities:* N/A
*Comments:* N/A
Interfaces folder.