User story #103
Updated by Ivan Herrero almost 10 years ago
Implement requirement MARTe-EX-D-1.2.1 based on the original MARTe implementation
Note: One of the key features of MARTe is the possibility of executing real-time multi-threading applications.
h1. Source code files modified
* Source/Core/L0Portability/ThreadsDatabase.h
* Source/Core/L0Portability/ThreadsDatabase.cpp
* Source/Core/L0Portability/Threads.h
* Source/Core/L0Portability/Threads.cpp
* Source/Core/L0Portability/OperatingSystem/Linux/ThreadsOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/ThreadsOS.h
* Source/Core/L0Portability/ThreadInformation.h
* Source/Core/L0Portability/TimeoutType.h
h1. Architecture & design review
*Date of the review:* 08/06/2015
*Person who did the review:* André Neto
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support class and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 18/06/2015 16/06/2015
*Person who did the review:* Ivan Herrero
*Result of review:* FAIL
*List of non-conformities:*
Manual review for Source/Core/L0Portability/ThreadsDatabase.h
OK
Manual review for Source/Core/L0Portability/ThreadsDatabase.cpp
Definition of methods have comments which seem to overlap with those on declaration counterparts.
Manual review for Source/Core/L0Portability/Threads.h
OK
Manual review for Source/Core/L0Portability/Threads.cpp
OK
Manual review for Source/Core/L0Portability/OperatingSystem/Linux/ThreadsOS.h
Relax rule "definition for inline functions shall be outside class declaration"
Method SetPriorityLevel have the @details documentation duplicated.
Method Name does not document the direction of its parameter.
Manual review for Source/Core/L0Portability/OperatingSystem/Windows/ThreadsOS.h
Function ThreadProtectedExecute does not have documentation at all.
Relax rule "definition for inline functions shall be outside class declaration"
Method Name does not document the direction of its parameter.
Manual review for Source/Core/L0Portability/ThreadInformation.h
OK
Manual review for Source/Core/L0Portability/TimeoutType.h
There is a standalone comment before class documentation.
*Note:* Automatic review with cppcheck OK
Note: One of the key features of MARTe is the possibility of executing real-time multi-threading applications.
h1. Source code files modified
* Source/Core/L0Portability/ThreadsDatabase.h
* Source/Core/L0Portability/ThreadsDatabase.cpp
* Source/Core/L0Portability/Threads.h
* Source/Core/L0Portability/Threads.cpp
* Source/Core/L0Portability/OperatingSystem/Linux/ThreadsOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/ThreadsOS.h
* Source/Core/L0Portability/ThreadInformation.h
* Source/Core/L0Portability/TimeoutType.h
h1. Architecture & design review
*Date of the review:* 08/06/2015
*Person who did the review:* André Neto
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support class and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 18/06/2015 16/06/2015
*Person who did the review:* Ivan Herrero
*Result of review:* FAIL
*List of non-conformities:*
Manual review for Source/Core/L0Portability/ThreadsDatabase.h
OK
Manual review for Source/Core/L0Portability/ThreadsDatabase.cpp
Definition of methods have comments which seem to overlap with those on declaration counterparts.
Manual review for Source/Core/L0Portability/Threads.h
OK
Manual review for Source/Core/L0Portability/Threads.cpp
OK
Manual review for Source/Core/L0Portability/OperatingSystem/Linux/ThreadsOS.h
Relax rule "definition for inline functions shall be outside class declaration"
Method SetPriorityLevel have the @details documentation duplicated.
Method Name does not document the direction of its parameter.
Manual review for Source/Core/L0Portability/OperatingSystem/Windows/ThreadsOS.h
Function ThreadProtectedExecute does not have documentation at all.
Relax rule "definition for inline functions shall be outside class declaration"
Method Name does not document the direction of its parameter.
Manual review for Source/Core/L0Portability/ThreadInformation.h
OK
Manual review for Source/Core/L0Portability/TimeoutType.h
There is a standalone comment before class documentation.
*Note:* Automatic review with cppcheck OK