User story #115
Updated by Ivan Herrero almost 10 years ago
Implement requirement MARTe-EX-F-1.3.4 based on the original MARTe implementation
Note: Framework developers might be interested to wait for a shared resource until this is available, no matter how long this might take.
h1. Source code files modified
* Source/Core/L0Portability/MutexSem.cpp
* Source/Core/L0Portability/MutexSem.h
* Source/Core/L0Portability/OperatingSystem/Linux/MutexSemOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/MutexSemOS.h
* Source/Core/L0Portability/SemCore.h
* Source/Core/L0Portability/EventSem.cpp
* Source/Core/L0Portability/EventSem.h
* Source/Core/L0Portability/OperatingSystem/Linux/EventSemOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/EventSemOS.h
* Source/Core/L0Portability/FastPollingMutexSem.h
h1. Architecture & design review
*Date of the review:* 12/06/2015
*Person who did the review:* André Neto
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 22/06/2015
*Person who did the review:* Ivan Herrero
*Result of review:* FAIL
*List of non-conformities:*
* Source/Core/L0Portability/MutexSem.cpp
OK
* Source/Core/L0Portability/MutexSem.h
Documentation for default constructor and destructor better with "/**" and "*/" on their own line.
The method Close always return true. Study if it should Shouldn't they be converted to void instead of bool and fix it or document it. bool?
* Source/Core/L0Portability/OperatingSystem/Linux/MutexSemOS.h
Include of "../../TimeoutType.h" Standard header includes on project section should be moved from to standard header includes to project header includes section.
Documentation for default constructor and destructor better with "/**" and "*/" on their own line.
The Lock method has a comment without @details tag.
Documentation for FastLock and FastUnLock methods better with "/**" and "*/" on their own line.
Documentation for FastLock and FastUnLock methods lack precondition for semH.
* Source/Core/L0Portability/OperatingSystem/Windows/MutexSemOS.h
OK Documentation for FastLock and FastUnLock methods better with "/**" and "*/" on their own line.
* Source/Core/L0Portability/SemCore.h
Documentation for Init method better with "/**" and "*/" on their own line.
* Source/Core/L0Portability/EventSem.cpp
OK
* Source/Core/L0Portability/EventSem.h
Documentation for default constructor and destructor better with "/**" and "*/" on their own line.
* Source/Core/L0Portability/OperatingSystem/Linux/EventSemOS.h
OK Documentation for default constructor and destructor better with "/**" and "*/" on their own line.
* Source/Core/L0Portability/OperatingSystem/Windows/EventSemOS.h
OK
* Source/Core/L0Portability/FastPollingMutexSem.h
Some methods (Create, Close, FastUnLock) always return true. Study if Shouldn't they should be converted to void instead of bool and fix them or document them. bool?
Note: Framework developers might be interested to wait for a shared resource until this is available, no matter how long this might take.
h1. Source code files modified
* Source/Core/L0Portability/MutexSem.cpp
* Source/Core/L0Portability/MutexSem.h
* Source/Core/L0Portability/OperatingSystem/Linux/MutexSemOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/MutexSemOS.h
* Source/Core/L0Portability/SemCore.h
* Source/Core/L0Portability/EventSem.cpp
* Source/Core/L0Portability/EventSem.h
* Source/Core/L0Portability/OperatingSystem/Linux/EventSemOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/EventSemOS.h
* Source/Core/L0Portability/FastPollingMutexSem.h
h1. Architecture & design review
*Date of the review:* 12/06/2015
*Person who did the review:* André Neto
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 22/06/2015
*Person who did the review:* Ivan Herrero
*Result of review:* FAIL
*List of non-conformities:*
* Source/Core/L0Portability/MutexSem.cpp
OK
* Source/Core/L0Portability/MutexSem.h
Documentation for default constructor and destructor better with "/**" and "*/" on their own line.
The method Close always return true. Study if it should Shouldn't they be converted to void instead of bool and fix it or document it. bool?
* Source/Core/L0Portability/OperatingSystem/Linux/MutexSemOS.h
Include of "../../TimeoutType.h" Standard header includes on project section should be moved from to standard header includes to project header includes section.
Documentation for default constructor and destructor better with "/**" and "*/" on their own line.
The Lock method has a comment without @details tag.
Documentation for FastLock and FastUnLock methods better with "/**" and "*/" on their own line.
Documentation for FastLock and FastUnLock methods lack precondition for semH.
* Source/Core/L0Portability/OperatingSystem/Windows/MutexSemOS.h
OK Documentation for FastLock and FastUnLock methods better with "/**" and "*/" on their own line.
* Source/Core/L0Portability/SemCore.h
Documentation for Init method better with "/**" and "*/" on their own line.
* Source/Core/L0Portability/EventSem.cpp
OK
* Source/Core/L0Portability/EventSem.h
Documentation for default constructor and destructor better with "/**" and "*/" on their own line.
* Source/Core/L0Portability/OperatingSystem/Linux/EventSemOS.h
OK Documentation for default constructor and destructor better with "/**" and "*/" on their own line.
* Source/Core/L0Portability/OperatingSystem/Windows/EventSemOS.h
OK
* Source/Core/L0Portability/FastPollingMutexSem.h
Some methods (Create, Close, FastUnLock) always return true. Study if Shouldn't they should be converted to void instead of bool and fix them or document them. bool?