MARTe2 » MARTe2-core

Implement requirement MARTe-EX-F-1.1.15 based on the original MARTe implementation.

Note: Basic is intended as with no streaming support. Expected functionality (as minimum) is I/O to/from stdin/stdout. This implementation should be portable and delegated to the different operating systems console implementation.

h1. Source code files modified

* Source/Core/L0Portability/BasicConsole.cpp
* Source/Core/L0Portability/BasicConsole.h
* Source/Core/L0Portability/OperatingSystem/Linux/BasicConsoleOS.h
* Source/Core/L0Portability/OperatingSystem/Linux/GeneralDefinitionsOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/BasicConsoleOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/GeneralDefinitionsOS.h

h1. Architecture & design review

*Date of the review:* 23/06/2015 12/06/2015

*Person who did the review:* André Neto

*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

*Result of review:* FAIL N/A

*List of non-conformities:*

* Source/Core/L0Portability/BasicConsole.cpp
OK

* Source/Core/L0Portability/BasicConsole.h
It seems that the parameter row of the GetCursorPosition method should be "out", shouldn't it?

* Source/Core/L0Portability/OperatingSystem/Linux/BasicConsoleOS.h
Some methods are not implemented, so they are tagged with a @brief tag "Not implemented". It should be better to use @brief as intended (to explain the purpose of the method) an signal that the method is not implemented in an another way (perhaps using a @warning tag).

* Source/Core/L0Portability/OperatingSystem/Linux/GeneralDefinitionsOS.h
OK

* Source/Core/L0Portability/OperatingSystem/Windows/BasicConsoleOS.h
The method Read lacks documentation for parameter buffer.
The methods GetSize and SetCursorPosition document the parameter "con" as "console".

* Source/Core/L0Portability/OperatingSystem/Windows/GeneralDefinitionsOS.h
OK N/A