MARTe2 » MARTe2-core

Implement requirement MARTe-EX-D-1.4.1 based on the original MARTe implementation

Note: Given that the framework is expected to be deployed and portable to very embedded systems it was decided not to assume that the stdlib malloc and free might be available everywhere.

h1. Source code files modified

* Source/Core/L0Portability/Memory.cpp
* Source/Core/L0Portability/Memory.h
* Source/Core/L0Portability/MemoryStatistics.h
* Source/Core/L0Portability/OperatingSystem/Linux/GeneralDefinitionsOS.h
* Source/Core/L0Portability/OperatingSystem/Linux/MemoryOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/GeneralDefinitionsOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/MemoryOS.h

h1. Architecture & design review

*Date of the review:* 12/06/2015

*Person who did the review:* André Neto

*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

*Result of review:* N/A

*List of non-conformities:* N/A

h1. Code and documentation review

*Date of the review:* 25/06/2015 22/06/2015

*Person who did the review:* Ivan Herrero

*Result of review:* FAIL

*List of non-conformities:*

* Manual review of Source/Core/L0Portability/Memory.cpp
The attribute Memory::defaultAllocationFlag should be defined on static section.
Violation of rule 5-2-4 on lines 82, 122, 133, 166, 229.

* Manual review of Source/Core/L0Portability/Memory.h
OK The attribute Memory::defaultAllocationFlag lacks documentation.

* Manual review of Source/Core/L0Portability/MemoryStatisticsDatabase.h Source/Core/L0Portability/MemoryStatistics.h
OK The name of the class MemoryStatisticsDatabase does not correspond to the file name (MemoryStatistics).
The class MemoryStatisticsDatabase has a private section before the public one.
The definition of MemoryStatisticsDatabase::stackDatabase and MemoryStatisticsDatabase::nOfElements should be on source file.

* Manual review of Source/Core/L0Portability/OperatingSystem/Linux/GeneralDefinitionsOS.h
OK

* Manual review of Source/Core/L0Portability/OperatingSystem/Linux/MemoryOS.h
OK

* Manual review of Source/Core/L0Portability/OperatingSystem/Windows/GeneralDefinitionsOS.h
OK

* Manual review of Source/Core/L0Portability/OperatingSystem/Windows/MemoryOS.h
OK