MARTe2 » MARTe2-core

Implement requirement MARTe-EX-D-1.3.1 based on the original MARTe implementation

Note: The development of multi-thread real-time applications usually requires the controlled and unique access to shared resources.

h1. Source code files modified

* Source/Core/L0Portability/MutexSem.cpp
* Source/Core/L0Portability/MutexSem.h
* Source/Core/L0Portability/OperatingSystem/Linux/MutexSemOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/MutexSemOS.h
* Source/Core/L0Portability/SemCore.h

h1. Architecture & design review

*Date of the review:* 12/06/2015

*Person who did the review:* André Neto

*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

*Result of review:* N/A

*List of non-conformities:* N/A

h1. Code and documentation review

*Date of the review:* 01/07/2015 25/06/2015

*Person who did the review:* Ivan Herrero

*Result of review:* PASS FAIL

*List of non-conformities:* N/A

Source/Core/L0Portability/MutexSem.cpp OK

Source/Core/L0Portability/MutexSem.h OK

Source/Core/L0Portability/OperatingSystem/Linux/MutexSemOS.h
There is an extra class declarated in this file named PrivateMutexSemStruct, which should be on its own header file or embbeded into MutexSemOS.
Documentation's tags for PrivateMutexSemStruct::UnLock method are not in the right order.

Source/Core/L0Portability/OperatingSystem/Windows/MutexSemOS.h
OK

Source/Core/L0Portability/SemCore.h
OK