MARTe2 » MARTe2-core

Implement requirement MARTe-EX-D-1.3.1 based on the original MARTe implementation

Note: The development of multi-thread real-time applications usually requires the controlled and unique access to shared resources.

h1. Source code files modified

* Source/Core/L0Portability/MutexSem.cpp
* Source/Core/L0Portability/MutexSem.h
* Source/Core/L0Portability/OperatingSystem/Linux/MutexSemOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/MutexSemOS.h
* Source/Core/L0Portability/SemCore.h
* Test/Core/L0Portability/MutexTest.cpp
* Test/Core/L0Portability/MutexTest.h
* Test/GTest/MutexGTest.cpp

h1. Architecture & design review

*Date of the review:* 12/06/2015

*Person who did the review:* André Neto

*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

*Result of review:* N/A

*List of non-conformities:* N/A

h1. Code and documentation review

*Date of the review:* 01/07/2015

*Person who did the review:* Ivan Herrero

*Result of review:* PASS

*List of non-conformities:* N/A

h1. Unit test review

*Date of the review:* 02/07/2015

*Person who did the review:* Ivan Herrero

*Result of coverage tests review:* PASS [100%]

*Result of functional tests review:* PASS

*Result of review:* FAIL

*List of non-conformities:*

* Files should be named MutexSemTest instead of MutexTest.

* Test/Core/L0Portability/MutexTest.h
This file includes "Threads.h", but Threads calls are not used until implementation in MutexTest.cpp, so move it to MutexTest.cpp.
The method TestLockCallback has two comments as documentation (it seems the first is a section comment).
IT lacks tests for default constructor and for destructor.

* Test/GTest/MutexGTest.cpp
It does not follow the structure of the code template.