MARTe2 » MARTe2-core

Implement requirement MARTe-EX-F-1.3.4 based on the original MARTe implementation

Note: Framework developers might be interested to wait for a shared resource until this is available, no matter how long this might take.

h1. Source code files modified

* Source/Core/L0Portability/MutexSem.cpp
* Source/Core/L0Portability/MutexSem.h
* Source/Core/L0Portability/OperatingSystem/Linux/MutexSemOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/MutexSemOS.h
* Source/Core/L0Portability/SemCore.h
* Source/Core/L0Portability/EventSem.cpp
* Source/Core/L0Portability/EventSem.h
* Source/Core/L0Portability/OperatingSystem/Linux/EventSemOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/EventSemOS.h
* Source/Core/L0Portability/FastPollingMutexSem.h
* Test/Core/L0Portability/MutexSemTest.cpp
* Test/Core/L0Portability/MutexSemTest.h
* Test/Core/L0Portability/SemCoreTest.cpp
* Test/Core/L0Portability/SemCoreTest.h
* Test/Core/L0Portability/EventSemTest.cpp
* Test/Core/L0Portability/EventSemTest.h
* Test/Core/L0Portability/FastPollingMutexSemTest.cpp
* Test/Core/L0Portability/FastPollingMutexSemTest.h

h1. Requirements review

N/A

h1. Architecture & design review

N/A

h1. Code and documentation review

*Date of the review:* 25/06/2015

*Person who did the review:* Ivan Herrero

*Result of review:* PASS

*List of non-conformities:* N/A

h1. Unit test review

*Date of the review:* 08/07/2015

*Person who did the review:* Ivan Herrero

*Version of unit tests:* 0.2 (479fd12)

*Result of coverage tests review:* PASS FAIL

*Result of functional tests review:* PASS FAIL

*Result of review:* PASS FAIL

*List of non-conformities:* N/A (*)

* Test/Core/L0Portability/MutexSemTest.cpp
Test class must be named after target class MutexSem, so it must be named MutexSemTest, but it is actually named MutexTest.
Test file must be named after target file MutexSem.cpp, so it must be named MutexSemTest.h, but it is actually named MutexTest.cpp.

* Test/Core/L0Portability/MutexSemTest.h
Test class must be named after target class MutexSem, so it must be named MutexSemTest, but it is actually named MutexTest.
Test file must be named after target file MutexSem.h, so it must be named MutexSemTest.h, but it is actually named MutexTest.h.

* Test/Core/L0Portability/SemCoreTest.cpp
Test not implemented.

* Test/Core/L0Portability/SemCoreTest.h
Test not implemented.

* Test/Core/L0Portability/EventSemTest.cpp
The test TestCopyConstructor tries to test a constructor that is only declared on the base class (check also for others intents of creating an instance of EventSem with this constructor).

* Test/Core/L0Portability/EventSemTest.h
File comment with incorrect date format.

* Test/Core/L0Portability/FastPollingMutexSemTest.cpp
Test class must be named after target class FastPollingMutexSem, so it must be named FastPollingMutexSemTest, but it is actually named FastPollingMutexTest.
Test file must be named after target file FastPollingMutexSem.cpp, so it must be named FastPollingMutexSemTest.h, but it is actually named FastPollingMutexTest.cpp.

* Test/Core/L0Portability/FastPollingMutexSemTest.h
Test class must be named after target class FastPollingMutexSem, so it must be named FastPollingMutexSemTest, but it is actually named FastPollingMutexTest.
Test file must be named after target file FastPollingMutexSem.h, so it must be named FastPollingMutexSemTest.h, but it is actually named FastPollingMutexTest.h.

h1. Integration test review

N/A

h1. Acceptance test review

N/A

Note: SemCoreTest class does not have unit test, because it has not implementation and it is not used by any other class of L0.