|
1
|
DESCRIBE CHANGES %{background:yellow}TODO%
|
|
2
|
|
|
3
|
|
|
4
|
*General*
|
|
5
|
|
|
6
|
Information
|
|
7
|
<pre>
|
|
8
|
The following files were detected as changed between branches #622_Merge_NI1588 and develop
|
|
9
|
Source/Components/DataSources/NI1588/NI1588Timestamp.cpp
|
|
10
|
Source/Components/DataSources/NI1588/NI1588Timestamp.h
|
|
11
|
Test/Components/DataSources/NI1588/NI1588TimestampGTest.cpp
|
|
12
|
Test/Components/DataSources/NI1588/NI1588TimestampTest.cpp
|
|
13
|
Test/Components/DataSources/NI1588/NI1588TimestampTest.h
|
|
14
|
</pre>
|
|
15
|
%{color:green}OK:% no errors found.
|
|
16
|
|
|
17
|
h1. Requirements review
|
|
18
|
|
|
19
|
*Date of the review:* 06/04/2021
|
|
20
|
|
|
21
|
*Person who did the review:* TODO
|
|
22
|
|
|
23
|
*Version of requirements:* %{background:yellow}TODO%
|
|
24
|
|
|
25
|
*Result of review:* %{background:yellow}TODO%
|
|
26
|
|
|
27
|
*List of non-conformities:* %{background:yellow}TODO%
|
|
28
|
|
|
29
|
*Comments:* %{background:yellow}TODO%
|
|
30
|
|
|
31
|
h1. Architecture & design review
|
|
32
|
|
|
33
|
*Date of the review:* 06/04/2021
|
|
34
|
|
|
35
|
*Person who did the review:* TODO
|
|
36
|
|
|
37
|
*Version of architecture & design document:* %{background:yellow}TODO%
|
|
38
|
|
|
39
|
*Result of review:* %{background:yellow}TODO%
|
|
40
|
|
|
41
|
*List of non-conformities:* %{background:yellow}TODO%
|
|
42
|
|
|
43
|
*Comments:* %{background:yellow}TODO%
|
|
44
|
|
|
45
|
h1. Code and documentation review
|
|
46
|
|
|
47
|
*Date of the review:* 06/04/2021
|
|
48
|
|
|
49
|
*Person who did the review:* TODO
|
|
50
|
|
|
51
|
*Version of source code:* c9cb11171f7d139aa8ec78d8d82a0c40ab5bd9e2
|
|
52
|
|
|
53
|
*Result of review:* %{background:yellow}TODO%
|
|
54
|
|
|
55
|
*List of non-conformities:*
|
|
56
|
|
|
57
|
%{background:red}Run flexelint and report% %{background:yellow}TODO%
|
|
58
|
|
|
59
|
|
|
60
|
*Headers*
|
|
61
|
|
|
62
|
%{color:green}OK:% All headers are correctly formatted
|
|
63
|
%{color:green}OK:% no errors found.
|
|
64
|
|
|
65
|
|
|
66
|
*Lint includes*
|
|
67
|
|
|
68
|
%{color:green}OK:% All files are being included for linting
|
|
69
|
%{color:green}OK:% no errors found.
|
|
70
|
|
|
71
|
|
|
72
|
*Linter*
|
|
73
|
|
|
74
|
%{color:red}ERR:% /home/codac-dev/MARTe2-dev/MakeDefaults/Lint/marte_flint_exceptions.lnt 15
|
|
75
|
%{color:red}ERR:% Lint/marte_components_flint_files.lnt:114:1: Error 305: Unable to open module 'EventConditionTrigger.cpp'
|
|
76
|
|
|
77
|
*Doxygen*
|
|
78
|
|
|
79
|
%{color:red}ERR:% warning: source ./Docs/Assets/Snippets/Parsing/MathGrammar.ll is not a readable file or directory... skipping.
|
|
80
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:45: warning: Compound OPCUA::NodeProperties is not documented.
|
|
81
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:60: warning: Compound OPCUA::ObjectProperties is not documented.
|
|
82
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:354: warning: Member EPICSPVAStructureDataI::ReadArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value) (function) of namespace MARTe is not documented.
|
|
83
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/EPICSPVA/EPICSPVAStructureDataI.h:417: warning: Member EPICSPVAStructureDataI::WriteArray< std::string >(epics::pvData::PVScalarArrayPtr scalarArrayPtr, AnyType &storedType, const AnyType &value, const uint32 &size) (function) of namespace MARTe is not documented.
|
|
84
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:54: warning: Member OPCUANodeSettings (typedef) of namespace OPCUA is not documented.
|
|
85
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:68: warning: Member OPCUAObjectSettings (typedef) of namespace OPCUA is not documented.
|
|
86
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:21: warning: explicit link request to 'include(CheckIPOSupported)' could not be resolved
|
|
87
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:22: warning: explicit link request to 'check_ipo_supported(RESULT CC_HAS_IPO)' could not be resolved
|
|
88
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:23: warning: explicit link request to 'if(CC_HAS_IPO)' could not be resolved
|
|
89
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:25: warning: explicit link request to 'endif()' could not be resolved
|
|
90
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:28: warning: found </c> at different nesting level (5) than expected (2)
|
|
91
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:29: warning: found </c> at different nesting level (5) than expected (2)
|
|
92
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/README.md:42: warning: end of comment block while expecting command </code>
|
|
93
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:112: warning: Unsupported xml/html tag <DeviceIdentity> found
|
|
94
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:113: warning: Unsupported xml/html tag <InfoText> found
|
|
95
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:114: warning: Unsupported xml/html tag <VendorName> found
|
|
96
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:115: warning: Unsupported xml/html tag </DeviceIdentity> found
|
|
97
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/Docs/README.md:286: warning: Unsupported xml/html tag <osal> found
|
|
98
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/LoggerDataSource/LoggerBroker.h:76: warning: Member SetPeriod(const uint32 cyclePeriodIn) (function) of class MARTe::LoggerBroker is not documented.
|
|
99
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/LoggerDataSource/LoggerDataSource.h:68: warning: Member Initialise(StructuredDataI &data) (function) of class MARTe::LoggerDataSource is not documented.
|
|
100
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:90: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath)
|
|
101
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:90: warning: The following parameters of MARTe::OPCUAClientMethod::SetMethodRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented:
|
|
102
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:79: warning: argument 'nodePaths' of command @param is not found in the argument list of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath)
|
|
103
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/OPCUADataSource/OPCUAClientMethod.h:79: warning: The following parameters of MARTe::OPCUAClientMethod::SetObjectRequest(const uint16 methodNamespaceIndex, StreamString methodPath) are not documented:
|
|
104
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/ProfinetDataSource.h:339: warning: expected <li> tag but found TK_LNKWORD token instead!
|
|
105
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/ProfinetDataSource.h:622: warning: unexpected end of comment while inside <ul> block
|
|
106
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:122: warning: The following parameters of MARTe::SimulinkDataI::PrintData(const uint64 maxNameLength=0u, StreamString additionalText="") are not documented:
|
|
107
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:269: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
|
|
108
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
|
|
109
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
|
|
110
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
|
|
111
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
|
|
112
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
|
|
113
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:291: warning: explicit link request to 'offsetBasedSize' could not be resolved
|
|
114
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:269: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
|
|
115
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
|
|
116
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
|
|
117
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
|
|
118
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
|
|
119
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
|
|
120
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:269: warning: Member runningOffset (variable) of class MARTe::SimulinkPort is not documented.
|
|
121
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:270: warning: Member typeBasedSize (variable) of class MARTe::SimulinkPort is not documented.
|
|
122
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:271: warning: Member offsetBasedSize (variable) of class MARTe::SimulinkPort is not documented.
|
|
123
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:272: warning: Member CAPISize (variable) of class MARTe::SimulinkPort is not documented.
|
|
124
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:274: warning: Member baseAddress (variable) of class MARTe::SimulinkPort is not documented.
|
|
125
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/SimulinkWrapperGAM/SimulinkClasses.h:275: warning: Member lastSignalAddress (variable) of class MARTe::SimulinkPort is not documented.
|
|
126
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/StatisticsGAM/StatisticsHelperT.h:323: warning: Member Reset() (function) of class MARTe::StatisticsHelperT is not documented.
|
|
127
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/StatisticsGAM/StatisticsHelperT.h:399: warning: Member StatisticsHelperT(const uint32 windowSize) (function) of class MARTe::StatisticsHelperT is not documented.
|
|
128
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/StatisticsGAM/StatisticsHelperT.h:420: warning: Member StatisticsHelperT(const uint32 windowSize) (function) of class MARTe::StatisticsHelperT is not documented.
|
|
129
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/StatisticsGAM/StatisticsHelperT.h:626: warning: Member GetAvg() const (function) of class MARTe::StatisticsHelperT is not documented.
|
|
130
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/GAMs/StatisticsGAM/StatisticsHelperT.h:636: warning: Member GetAvg() const (function) of class MARTe::StatisticsHelperT is not documented.
|
|
131
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:46: warning: Member attr (variable) of class OPCUA::NodeProperties is not documented.
|
|
132
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:47: warning: Member value (variable) of class OPCUA::NodeProperties is not documented.
|
|
133
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:48: warning: Member nodeId (variable) of class OPCUA::NodeProperties is not documented.
|
|
134
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:49: warning: Member nodeName (variable) of class OPCUA::NodeProperties is not documented.
|
|
135
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:50: warning: Member parentNodeId (variable) of class OPCUA::NodeProperties is not documented.
|
|
136
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:51: warning: Member parentReferenceNodeId (variable) of class OPCUA::NodeProperties is not documented.
|
|
137
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:61: warning: Member attr (variable) of class OPCUA::ObjectProperties is not documented.
|
|
138
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:62: warning: Member nodeId (variable) of class OPCUA::ObjectProperties is not documented.
|
|
139
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:63: warning: Member nodeName (variable) of class OPCUA::ObjectProperties is not documented.
|
|
140
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:64: warning: Member parentNodeId (variable) of class OPCUA::ObjectProperties is not documented.
|
|
141
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/Interfaces/OPCUA/OPCUATypes.h:65: warning: Member parentReferenceNodeId (variable) of class OPCUA::ObjectProperties is not documented.
|
|
142
|
%{color:red}ERR:% /home/codac-dev/ni9157Testing/MARTe2-components/Source/Components/DataSources/ProfinetDataSource/ProfinetDataSourceAdapter.h:479: warning: The following parameters of ProfinetDataSourceDriver::ProfinetDataSourceAdapter::SetBaseData(MARTe::uint8 vendorIdHigh, MARTe::uint8 vendorIdLow, MARTe::uint8 deviceIdHigh, MARTe::uint8 deviceIdLow, MARTe::uint8 oemVendorIdHigh, MARTe::uint8 oemVendorIdLow, MARTe::uint8 oemDeviceIdHigh, MARTe::uint8 oemDeviceIdLow, MARTe::StreamString productName, MARTe::uint16 minimumDeviceInterval) are not documented:
|
|
143
|
|
|
144
|
|
|
145
|
h1. Unit test review
|
|
146
|
|
|
147
|
*Date of the review:* 06/04/2021
|
|
148
|
|
|
149
|
*Person who did the review:* TODO
|
|
150
|
|
|
151
|
*Version of source code:* c9cb11171f7d139aa8ec78d8d82a0c40ab5bd9e2
|
|
152
|
|
|
153
|
*Result of coverage tests review:* %{background:yellow}TODO%
|
|
154
|
|
|
155
|
*Result of functional tests review:* %{background:yellow}TODO%
|
|
156
|
|
|
157
|
*Result of review:* %{background:yellow}TODO%
|
|
158
|
|
|
159
|
*Comments:* %{background:yellow}TODO%
|
|
160
|
|
|
161
|
*List of non-conformities:*
|
|
162
|
|
|
163
|
|
|
164
|
*Functional tests*
|
|
165
|
|
|
166
|
%{color:green}OK:% All public methods are being tested at least once
|
|
167
|
%{color:green}OK:% no errors found.
|
|
168
|
|
|
169
|
|
|
170
|
*GTest*
|
|
171
|
|
|
172
|
%{color:red}ERR:% helper did not run.
|
|
173
|
|
|
174
|
|
|
175
|
*Unsolved Failing Tests*
|
|
176
|
|
|
177
|
|
|
178
|
*New Failing Tests*
|
|
179
|
|
|
180
|
|
|
181
|
*Solved Failing Tests*
|
|
182
|
|
|
183
|
|
|
184
|
*Coverage*
|
|
185
|
|
|
186
|
%{color:red}ERR:% helper did not run.
|
|
187
|
|
|
188
|
|
|
189
|
|
|
190
|
h1. Integration test review
|
|
191
|
|
|
192
|
*Date of the review:* 06/04/2021
|
|
193
|
|
|
194
|
*Person who did the review:* TODO
|
|
195
|
|
|
196
|
*Version of source code:* c9cb11171f7d139aa8ec78d8d82a0c40ab5bd9e2
|
|
197
|
|
|
198
|
*Result of review:* N/A
|
|
199
|
|
|
200
|
*List of non-conformities:* N/A
|
|
201
|
|
|
202
|
*Comments:* N/A
|
|
203
|
|
|
204
|
|
|
205
|
|
|
206
|
h1. Acceptance test review
|
|
207
|
|
|
208
|
*Date of the review:* 06/04/2021
|
|
209
|
|
|
210
|
*Person who did the review:* TODO
|
|
211
|
|
|
212
|
*Version of source code:* c9cb11171f7d139aa8ec78d8d82a0c40ab5bd9e2
|
|
213
|
|
|
214
|
*Result of review:* N/A
|
|
215
|
|
|
216
|
*List of non-conformities:* N/A
|
|
217
|
|
|
218
|
*Comments:* N/A
|
|
219
|
|