Project

General

Profile

User story #184

Smart pointer base infrastructure

Added by André Neto over 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
0.3
Start date:
11.08.2015
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Git branch (link):
Git merge to develop (link):
SVN commit (link/?p=rev):

Description

Refactor the original MARTe smart pointer infrastructure (aka GCReference).
This would satisfy requirements:
  • MARTe-EX-F-2.1.1: The framework shall offer developers a smart pointer infrastructure..
  • MARTe-EX-F-2.1.3: The framework shall offer to developers the possibility of getting a reference to any object instantiated by the framework.

Source code files modified

  • Source/Core/L0Portability/Heap.cpp
  • Source/Core/L0Portability/Heap.h
  • Source/Core/L1Objects/ClassProperties.cpp
  • Source/Core/L1Objects/ClassProperties.h
  • Source/Core/L1Objects/ClassRegistryDatabase.cpp
  • Source/Core/L1Objects/ClassRegistryDatabase.h
  • Source/Core/L1Objects/ClassRegistryItem.cpp
  • Source/Core/L1Objects/ClassRegistryItem.h
  • Source/Core/L1Objects/Introspection.h
  • Source/Core/L1Objects/Iterator.h
  • Source/Core/L1Objects/IteratorT.h
  • Source/Core/L1Objects/LinkedListable.cpp
  • Source/Core/L1Objects/LinkedListable.h
  • Source/Core/L1Objects/LinkedListHolder.cpp
  • Source/Core/L1Objects/LinkedListHolder.h
  • Source/Core/L1Objects/Object.cpp
  • Source/Core/L1Objects/Object.h
  • Source/Core/L1Objects/Reference.cpp
  • Source/Core/L1Objects/Reference.h
  • Source/Core/L1Objects/ReferenceT.cpp
  • Source/Core/L1Objects/ReferenceT.h
  • Source/Core/L1Objects/SearchFilter.h
  • Source/Core/L1Objects/SearchFilterT.h
  • Source/Core/L1Objects/SortFilter.h
  • Source/Core/L1Objects/SortFilterT.h
  • Source/Core/L1Objects/StructuredData.h

Architecture & design review

Date of the review: 31/07/2015

Person who did the review: Andre' Neto

Version of architecture & design document: No design document was produced but this was thoroughly discussed in several meetings and reported in #191. This should be captured in EA (see #192).

Result of review: N/A

List of non-conformities: N/A

Code and documentation review

Date of the review: 12/08/2015

Person who did the review: Riccardo Vitelli

Result of review: PASS (with LINT)

List of non-conformities:
  • MARTe2-dev/Source/Core/L1Objects/Object.cpp:95:29: Warning 1502: defined object 'ObjectHeap_' of type 'Heap' has no nonstatic data members
    (accepted as the Heap interface is not yet complete)

Unit test review

Date of the review: 20/08/2015

Person who did the review: Andre' Neto

Result of coverage tests review: PASS

Result of functional tests review: PASS

Result of review: PASS

List of non-conformities:

Notes:
The following are to be left for a later sprint when introspection, configuration and DLL support will be available:
  • void Object::GetIntrospectionCopy
  • bool Reference::Initialise
  • bool ReferenceT<T>::Initialise
  • ClassRegistryItem *ClassRegistryDatabase::Find does not test the case with a DLL
The following are private and cannot be tested:
  • ClassRegistryItem::ClassRegistryItem()
  • Object *Object::Clone() const
  • ReferenceT<T>* ReferenceT<T>::operator&()

Subtasks

Meeting #192: Describe the Object implementation in EAClosedIvan Herrero

Associated revisions

Revision de0444d7 (diff)
Added by André Neto over 9 years ago

Work in progress for #184.

Revision 8bc819af
Added by André Neto over 9 years ago

Merge remote-tracking branch
'origin/#184_Smart_Pointer_Base_Infrastructure' into
#184_Smart_Pointer_Base_Infrastructure

Conflicts:
Source/Core/L1Objects/Object.h

Revision 1016c9db (diff)
Added by André Neto over 9 years ago

Finished implementation of the ClassRegistryDatabase infrastructure #184

Revision 46036abc
Added by André Neto over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of
https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into
#184_Smart_Pointer_Base_Infrastructure

Conflicts:
Source/Core/L1Objects/LinkedListable.h
Source/Core/L1Objects/Makefile.inc
Test/Core/L1Objects/Makefile.inc
Test/Core/L1Objects/Makefile.linux
Test/GTest/Makefile.linux

Revision 4e8edcd4
Added by André Neto over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of
https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into
#184_Smart_Pointer_Base_Infrastructure

Conflicts:
Source/Core/L1Objects/LinkedListHolder.h
Source/Core/L1Objects/Makefile.inc

Revision 0c9766ba (diff)
Added by André Neto over 9 years ago

Working but not ready for code review #184.

Documentation still to be improved.

Revision 097d46bd (diff)
Added by Giuseppe Ferro over 9 years ago

List of changes:
-Lint of LinkedListHolder
-Test of LinkedListHolder
#184

Revision 7c4329b2
Added by Giuseppe Ferro over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #184_Smart_Pointer_Base_Infrastructure

Revision 632f554a (diff)
Added by André Neto over 9 years ago

Linting missing to terminate #184.

Revision 5d183e89
Added by Filippo Sartori over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of https://fsartori@vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #184_Smart_Pointer_Base_Infrastructure

Revision c9102092 (diff)
Added by Giuseppe Ferro over 9 years ago

WIP Tests.
#184

Revision 14dd52e2
Added by Giuseppe Ferro over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #184_Smart_Pointer_Base_Infrastructure

Revision 5f29690d (diff)
Added by André Neto over 9 years ago

Finished the linting of #184.

Revision 05bc2b98
Added by Giuseppe Ferro over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #184_Smart_Pointer_Base_Infrastructure

Revision 9702398a
Added by Filippo Sartori over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of https://fsartori@vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #184_Smart_Pointer_Base_Infrastructure

Revision 25c21c55 (diff)
Added by Giuseppe Ferro over 9 years ago

List of changes.
-Added Reference tests.
User story: #184

Revision bdb9c0b9
Added by Filippo Sartori over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of https://fsartori@vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #184_Smart_Pointer_Base_Infrastructure

Revision 436da978
Added by André Neto over 9 years ago

Merge remote-tracking branch
'origin/#184_Smart_Pointer_Base_Infrastructure' into
#184_Smart_Pointer_Base_Infrastructure

Conflicts:
Source/Core/L1Objects/Reference.cpp

Revision 6f232698 (diff)
Added by André Neto over 9 years ago

Lint of #184 finished. Still checking quality of the documentation.

Revision 2cee8d58 (diff)
Added by André Neto over 9 years ago

Finished linting and documentation of #184. Ready for review.

Revision 7fdd30bf (diff)
Added by André Neto over 9 years ago

Moved CreateByName to Reference. #184.

Revision a5801f31 (diff)
Added by Giuseppe Ferro over 9 years ago

List of changes:
-Reference and ReferenceT tests done.
-Fixed other tests accordingly with refactoring.

#184

Revision c799de20 (diff)
Added by André Neto over 9 years ago

Removed the global functions for sorting, iterating and searching #184.

Revision d441fe3e
Added by André Neto over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #184_Smart_Pointer_Base_Infrastructure

Revision 7cf6f6e2
Added by Filippo Sartori over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of
https://fsartori@vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into
#184_Smart_Pointer_Base_Infrastructure

Conflicts:
Source/Core/L1Objects/ClassRegistryItem.h

Revision 916f7880
Added by Filippo Sartori over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of https://fsartori@vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #184_Smart_Pointer_Base_Infrastructure

Revision 38414163
Added by Giuseppe Ferro over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #184_Smart_Pointer_Base_Infrastructure

Revision d3e362ed
Added by Filippo Sartori over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of https://fsartori@vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #184_Smart_Pointer_Base_Infrastructure

Revision e6db1597
Added by Filippo Sartori over 9 years ago

Merge remote-tracking branch 'origin/#186_Named_Objects' into #184_Smart_Pointer_Base_Infrastructure

Revision c0ba378d
Added by Riccardo Vitelli over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2 into #184_Smart_Pointer_Base_Infrastructure

Revision c41764ab
Added by Filippo Sartori over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of
https://fsartori@vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into
#184_Smart_Pointer_Base_Infrastructure

Conflicts:
Source/Core/L0Portability/Heap.cpp
Source/Core/L0Portability/Heap.h

Revision 8856ef0d
Added by Giuseppe Ferro over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #184_Smart_Pointer_Base_Infrastructure

Revision 165bbfa1 (diff)
Added by Giuseppe Ferro over 9 years ago

List of Changes:
-Tests of ClassRegistryDatabase done
#184

Revision 5fedbba9
Added by Filippo Sartori over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of
https://fsartori@vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into
#184_Smart_Pointer_Base_Infrastructure

Conflicts:
Test/Core/L1Objects/ClassRegistryDatabaseTest.cpp

Revision 37c18580 (diff)
Added by Giuseppe Ferro over 9 years ago

Fixed minor things in template and documentation.
#184

Revision bf506741 (diff)
Added by André Neto over 9 years ago

Cosmetic changes to the testing documentation #184.

Revision c359e9a9 (diff)
Added by Giuseppe Ferro over 9 years ago

Added GetClassPropertiesCopy test.
#184

Revision 50c595ea
Added by André Neto over 9 years ago

Merge remote-tracking branch 'origin/develop' into #184_Smart_Pointer_Base_Infrastructure

Revision 87d5d7c3
Added by André Neto over 9 years ago

Merge branch '#186_Named_Objects' into develop

Merged #184 and #186 into develop.

Conflicts:
Source/Core/L1Objects/Object.h
Test/Core/L1Objects/ClassRegistryDatabaseTest.cpp
Test/Core/L1Objects/ObjectTest.cpp
Test/Core/L1Objects/ObjectTest.h
Test/GTest/ObjectGTest.cpp

Revision 5f1ee489 (diff)
Added by Giuseppe Ferro over 9 years ago

Minor changes in documentation.
#184

Revision 79fad01a
Added by André Neto over 9 years ago

Merge branch '#184_Smart_Pointer_Base_Infrastructure' of https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #184_Smart_Pointer_Base_Infrastructure

Revision 21f44270
Added by André Neto over 9 years ago

Merge branch 'develop' into #184_Smart_Pointer_Base_Infrastructure

History

#1 Updated by Riccardo Vitelli over 9 years ago

  • Status changed from New to Code: Impl

#2 Updated by Riccardo Vitelli over 9 years ago

  • Assignee set to André Neto

#3 Updated by André Neto over 9 years ago

  • Description updated (diff)

#4 Updated by André Neto over 9 years ago

  • Description updated (diff)

#5 Updated by Riccardo Vitelli over 9 years ago

  • Status changed from Code: Impl to Code: Rev

#6 Updated by Riccardo Vitelli over 9 years ago

  • Assignee deleted (André Neto)

#7 Updated by Riccardo Vitelli over 9 years ago

  • Description updated (diff)

Corrected duplication in Source File modified.

#8 Updated by Riccardo Vitelli over 9 years ago

  • Assignee set to Riccardo Vitelli

#9 Updated by Riccardo Vitelli over 9 years ago

  • Description updated (diff)

Done Code Review for #d441fe3

#10 Updated by Riccardo Vitelli over 9 years ago

  • Status changed from Code: Rev to Unit: Impl

#11 Updated by Riccardo Vitelli over 9 years ago

  • Assignee deleted (Riccardo Vitelli)

#12 Updated by Giuseppe Ferro over 9 years ago

Unit tests of:
-Object
-Reference
-ReferenceT
-LinkedListable
-LinkedListHolder (and filters associated)
-ClassProperties
-ClassRegistryItem
-ClassRegistryDatabase
done.

#13 Updated by Giuseppe Ferro over 9 years ago

  • Status changed from Unit: Impl to Unit: Rev

#14 Updated by André Neto over 9 years ago

  • Assignee set to André Neto

#15 Updated by André Neto over 9 years ago

  • Description updated (diff)

#16 Updated by André Neto over 9 years ago

  • Status changed from Unit: Rev to Unit: Impl

#17 Updated by André Neto over 9 years ago

  • Assignee deleted (André Neto)

#18 Updated by André Neto over 9 years ago

  • Description updated (diff)

#19 Updated by André Neto over 9 years ago

  • Description updated (diff)

#20 Updated by André Neto over 9 years ago

  • Description updated (diff)

#21 Updated by André Neto over 9 years ago

  • Description updated (diff)

#22 Updated by Giuseppe Ferro over 9 years ago

  • Assignee set to Giuseppe Ferro

#23 Updated by Giuseppe Ferro over 9 years ago

Note: The following functions are private.
ClassRegistryItem::ClassRegistryItem()
Object Object::Clone() const
ReferenceT<T> ReferenceT<T>::operator&()

#24 Updated by Giuseppe Ferro over 9 years ago

  • Status changed from Unit: Impl to Unit: Rev

#25 Updated by Giuseppe Ferro over 9 years ago

  • Assignee deleted (Giuseppe Ferro)

#26 Updated by André Neto over 9 years ago

  • Description updated (diff)

#27 Updated by André Neto over 9 years ago

Unit test revision performed against commit: c359e9a9

#28 Updated by André Neto over 9 years ago

  • Assignee set to André Neto

#29 Updated by André Neto over 9 years ago

  • Status changed from Unit: Rev to Closed
  • Assignee deleted (André Neto)

#30 Updated by André Neto over 9 years ago

  • Status changed from Closed to Unit: Rev

#31 Updated by André Neto over 9 years ago

  • Description updated (diff)

#32 Updated by André Neto over 9 years ago

  • Status changed from Unit: Rev to Closed

Merged with develop in commit 87d5d7c3

Also available in: Atom PDF