User story #228

Address FractionalIntegerGTest and BitRangeGTest compilation warnings

Added by André Neto over 9 years ago. Updated over 9 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Target version:

0.8

Start date:

27.09.2015

Due date:

% Done:

Estimated time:

Git branch (link):

Git merge to develop (link):

SVN commit (link/?p=rev):

Description

Address and solve the following warnings:

In file included from FractionalIntegerGTest.cpp:35:
../Core/BareMetal/L0Types/FractionalIntegerTest.h: In member function ‘bool FractionalIntegerTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = short int, T = unsigned int]’:
FractionalIntegerGTest.cpp:83: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:131: warning: comparison between signed and unsigned integer expressions
FractionalIntegerGTest.cpp:83: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:142: warning: comparison between signed and unsigned integer expressions
../Core/BareMetal/L0Types/FractionalIntegerTest.h: In member function ‘bool FractionalIntegerTest<T>::TestBasicTypeCastMajorSize(T2) [with T2 = short int, T = unsigned int]’:
FractionalIntegerGTest.cpp:89: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:170: warning: comparison between signed and unsigned integer expressions
FractionalIntegerGTest.cpp:89: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:176: warning: comparison between signed and unsigned integer expressions
FractionalIntegerGTest.cpp:89: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:192: warning: comparison between signed and unsigned integer expressions
../Core/BareMetal/L0Types/FractionalIntegerTest.h: In member function ‘bool FractionalIntegerTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = int, T = long long int]’:
FractionalIntegerGTest.cpp:171: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:111: warning: integer overflow in expression
../Core/BareMetal/L0Types/FractionalIntegerTest.h:112: warning: integer overflow in expression
../Core/BareMetal/L0Types/FractionalIntegerTest.h: In member function ‘bool FractionalIntegerTest<T>::TestBasicTypeCastMajorSize(T2) [with T2 = int, T = long long int]’:
FractionalIntegerGTest.cpp:177: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:160: warning: integer overflow in expression
../Core/BareMetal/L0Types/FractionalIntegerTest.h:161: warning: integer overflow in expression
../Core/BareMetal/L0Types/FractionalIntegerTest.h: In member function ‘bool FractionalIntegerTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = int, T = long long unsigned int]’:
FractionalIntegerGTest.cpp:183: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:111: warning: integer overflow in expression
../Core/BareMetal/L0Types/FractionalIntegerTest.h:112: warning: integer overflow in expression
FractionalIntegerGTest.cpp:183: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:131: warning: comparison between signed and unsigned integer expressions
FractionalIntegerGTest.cpp:183: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:142: warning: comparison between signed and unsigned integer expressions
../Core/BareMetal/L0Types/FractionalIntegerTest.h: In member function ‘bool FractionalIntegerTest<T>::TestBasicTypeCastMajorSize(T2) [with T2 = int, T = long long unsigned int]’:
FractionalIntegerGTest.cpp:189: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:160: warning: integer overflow in expression
../Core/BareMetal/L0Types/FractionalIntegerTest.h:161: warning: integer overflow in expression
FractionalIntegerGTest.cpp:189: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:170: warning: comparison between signed and unsigned integer expressions
FractionalIntegerGTest.cpp:189: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:176: warning: comparison between signed and unsigned integer expressions
FractionalIntegerGTest.cpp:189: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:192: warning: comparison between signed and unsigned integer expressions
../Core/BareMetal/L0Types/FractionalIntegerTest.h: In member function ‘bool FractionalIntegerTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = unsigned int, T = int]’:
FractionalIntegerGTest.cpp:203: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:131: warning: comparison between signed and unsigned integer expressions
FractionalIntegerGTest.cpp:203: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:142: warning: comparison between signed and unsigned integer expressions
../Core/BareMetal/L0Types/FractionalIntegerTest.h: In member function ‘bool FractionalIntegerTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = int, T = int]’:
FractionalIntegerGTest.cpp:209: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:111: warning: integer overflow in expression
../Core/BareMetal/L0Types/FractionalIntegerTest.h:112: warning: integer overflow in expression
../Core/BareMetal/L0Types/FractionalIntegerTest.h: In member function ‘bool FractionalIntegerTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = int, T = unsigned int]’:
FractionalIntegerGTest.cpp:215: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:111: warning: integer overflow in expression
../Core/BareMetal/L0Types/FractionalIntegerTest.h:112: warning: integer overflow in expression
FractionalIntegerGTest.cpp:215: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:131: warning: comparison between signed and unsigned integer expressions
FractionalIntegerGTest.cpp:215: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:142: warning: comparison between signed and unsigned integer expressions
../Core/BareMetal/L0Types/FractionalIntegerTest.h: In member function ‘bool FractionalIntegerTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = long long unsigned int, T = int]’:
FractionalIntegerGTest.cpp:228: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:131: warning: comparison between signed and unsigned integer expressions
FractionalIntegerGTest.cpp:228: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:142: warning: comparison between signed and unsigned integer expressions
../Core/BareMetal/L0Types/FractionalIntegerTest.h: In member function ‘bool FractionalIntegerTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = long long int, T = int]’:
FractionalIntegerGTest.cpp:234: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:111: warning: integer overflow in expression
../Core/BareMetal/L0Types/FractionalIntegerTest.h:112: warning: integer overflow in expression
../Core/BareMetal/L0Types/FractionalIntegerTest.h: In member function ‘bool FractionalIntegerTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = long long int, T = unsigned int]’:
FractionalIntegerGTest.cpp:240: instantiated from here
../Core/BareMetal/L0Types/FractionalIntegerTest.h:111: warning: integer overflow in expression
../Core/BareMetal/L0Types/FractionalIntegerTest.h:112: warning: integer overflow in expression
mkdir -p ../../Build/linux//GTest
g++ -c -finline-functions -I../ -I../Core/BareMetal/L0Types -I../Core/BareMetal/L1Portability -I../Core/BareMetal/L2Objects -I../Core/BareMetal/L3Streams -I../Core/Scheduler/L1Portability -I../../Source/Core/BareMetal/L0Types -I../../Source/Core/BareMetal/L1Portability -I../../Source/Core/BareMetal/L2Objects -I../../Source/Core/BareMetal/L3Streams -I../../Source/Core/Scheduler/L1Portability -I../../Lib/gtest-1.7.0/include -fPIC -frtti -Wall -DARCHITECTURE=x86_gcc -DENVIRONMENT=Linux -DUSE_PTHREAD -pthread -g -ggdb BitRangeGTest.cpp -o ../../Build/linux//GTest/BitRangeGTest.o
In file included from BitRangeGTest.cpp:35:
../Core/BareMetal/L0Types/BitRangeTest.h: In member function ‘bool BitRangeTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = short int, T = unsigned int]’:
BitRangeGTest.cpp:89: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:183: warning: comparison between signed and unsigned integer expressions
../Core/BareMetal/L0Types/BitRangeTest.h: In member function ‘bool BitRangeTest<T>::TestBasicTypeCastMajorSize(T2) [with T2 = short int, T = unsigned int]’:
BitRangeGTest.cpp:95: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:213: warning: comparison between signed and unsigned integer expressions
BitRangeGTest.cpp:95: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:220: warning: comparison between signed and unsigned integer expressions
BitRangeGTest.cpp:95: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:235: warning: comparison between signed and unsigned integer expressions
../Core/BareMetal/L0Types/BitRangeTest.h: In member function ‘bool BitRangeTest<T>::TestBasicTypeCastMajorSize(T2) [with T2 = int, T = long long int]’:
BitRangeGTest.cpp:183: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:203: warning: integer overflow in expression
../Core/BareMetal/L0Types/BitRangeTest.h:204: warning: integer overflow in expression
../Core/BareMetal/L0Types/BitRangeTest.h: In member function ‘bool BitRangeTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = int, T = long long unsigned int]’:
BitRangeGTest.cpp:189: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:183: warning: comparison between signed and unsigned integer expressions
../Core/BareMetal/L0Types/BitRangeTest.h: In member function ‘bool BitRangeTest<T>::TestBasicTypeCastMajorSize(T2) [with T2 = int, T = long long unsigned int]’:
BitRangeGTest.cpp:195: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:203: warning: integer overflow in expression
../Core/BareMetal/L0Types/BitRangeTest.h:204: warning: integer overflow in expression
BitRangeGTest.cpp:195: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:213: warning: comparison between signed and unsigned integer expressions
BitRangeGTest.cpp:195: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:220: warning: comparison between signed and unsigned integer expressions
BitRangeGTest.cpp:195: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:235: warning: comparison between signed and unsigned integer expressions
../Core/BareMetal/L0Types/BitRangeTest.h: In member function ‘bool BitRangeTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = unsigned int, T = int]’:
BitRangeGTest.cpp:209: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:183: warning: comparison between signed and unsigned integer expressions
../Core/BareMetal/L0Types/BitRangeTest.h: In member function ‘bool BitRangeTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = int, T = int]’:
BitRangeGTest.cpp:215: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:152: warning: integer overflow in expression
../Core/BareMetal/L0Types/BitRangeTest.h:153: warning: integer overflow in expression
../Core/BareMetal/L0Types/BitRangeTest.h: In member function ‘bool BitRangeTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = int, T = unsigned int]’:
BitRangeGTest.cpp:221: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:183: warning: comparison between signed and unsigned integer expressions
../Core/BareMetal/L0Types/BitRangeTest.h: In member function ‘bool BitRangeTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = long long unsigned int, T = int]’:
BitRangeGTest.cpp:234: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:183: warning: comparison between signed and unsigned integer expressions
../Core/BareMetal/L0Types/BitRangeTest.h: In member function ‘bool BitRangeTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = long long int, T = int]’:
BitRangeGTest.cpp:240: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:152: warning: integer overflow in expression
../Core/BareMetal/L0Types/BitRangeTest.h:153: warning: integer overflow in expression
../Core/BareMetal/L0Types/BitRangeTest.h: In member function ‘bool BitRangeTest<T>::TestBasicTypeCastMinorSize(T2) [with T2 = long long int, T = unsigned int]’:
BitRangeGTest.cpp:246: instantiated from here
../Core/BareMetal/L0Types/BitRangeTest.h:152: warning: integer overflow in expression
../Core/BareMetal/L0Types/BitRangeTest.h:153: warning: integer overflow in expression

Source code files modified¶

modified: Test/Core/BareMetal/L0Types/BitRangeTest.h
modified: Test/Core/BareMetal/L0Types/FractionalIntegerTest.h
modified: Test/GTest/FractionalIntegerGTest.cpp

Architecture & design review¶

Date of the review: 23/10/2015

Person who did the review: André Neto

Version of architecture & design document: N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

Result of review: N/A

List of non-conformities: N/A