#246 is also reviewed here

Implement the Windows UDP socket stream based on the previous MARTe implementation.

Source code files modified¶

• Source/Core/BareMetal/L1Portability/Environment/Windows/HighResolutionTimer.h
• Source/Core/BareMetal/L1Portability/Environment/Windows/HighResolutionTimerCalibrator.cpp
• Source/Core/BareMetal/L1Portability/Environment/Windows/Makefile.inc
• Source/Core/BareMetal/L1Portability/Environment/Windows/TimeStamp.cpp
• Source/Core/BareMetal/L1Portability/Makefile.inc
• Source/Core/BareMetal/L1Portability/TimeStamp.h
• Source/Core/BareMetal/L2Objects/AnyType.cpp
• Source/Core/BareMetal/L2Objects/AnyType.h
• Source/Core/BareMetal/L2Objects/StructuredDataI.h
• Source/Core/BareMetal/L4Configuration/AnyObject.cpp
• Source/Core/BareMetal/L4Configuration/AnyObject.h
• Source/Core/BareMetal/L4Configuration/ConfigurationDatabase.cpp
• Source/Core/BareMetal/L4Configuration/ConfigurationDatabase.h
• Source/Core/BareMetal/L4Configuration/Makefile.msc
• Source/Core/BareMetal/L4Configuration/TypeConversion.cpp
• Source/Core/BareMetal/L4Configuration/TypeConversion.h
• Source/Core/BareMetal/Makefile.msc
• Source/Core/FileSystem/L1Portability/BasicSocket.h
• Source/Core/FileSystem/L1Portability/Environment/Windows/BasicSocket.cpp
• Source/Core/FileSystem/L1Portability/Environment/Windows/BasicTCPSocket.cpp
• Source/Core/FileSystem/L1Portability/Environment/Windows/BasicUDPSocket.cpp
• Source/Core/FileSystem/L1Portability/Environment/Windows/InternetHost.cpp
• Source/Core/FileSystem/L1Portability/Environment/Windows/InternetHostCore.h
• Source/Core/FileSystem/L1Portability/Environment/Windows/InternetService.cpp
• Source/Core/FileSystem/L1Portability/Environment/Windows/InternetServiceCore.h
• Source/Core/FileSystem/L1Portability/Environment/Windows/Makefile.msc
• Source/Core/FileSystem/L1Portability/Environment/Windows/SocketCore.h
• Source/Core/FileSystem/L1Portability/Environment/Windows/SocketSelect.cpp
• Source/Core/FileSystem/L1Portability/Makefile.msc
• Source/Core/FileSystem/Makefile.msc
• Test/Core/BareMetal/L0Types/MatrixTest.cpp
• Test/Core/BareMetal/L1Portability/HeapManagerTest.cpp
• Test/Core/BareMetal/L4Configuration/Makefile.msc
• Test/Core/BareMetal/L4Configuration/TypeConversionTest.cpp
• Test/Core/BareMetal/L4Configuration/TypeConversionTest.h
• Test/Core/BareMetal/Makefile.msc
• Test/Core/FileSystem/L1Portability/Makefile.inc
• Test/GTest/BasicTCPSocketGTest.cpp
• Test/GTest/Makefile.inc
• Test/GTest/TypeConversionGTest.cpp

Architecture & design review¶

Date of the review: 23/10/2015

Person who did the review: André Neto

Version of architecture & design document: N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

Result of review: N/A

List of non-conformities: N/A

Code and documentation review¶

Date of the review: 01/12/2015

Person who did the review: Andre Neto

Result of review: PASS (but see List of non-conformities and create user-story to implement the required documentation)

List of non-conformities: N/A.

• Documentation of LocalHostInfo in InternetHost.cpp is missing both in Linux and Windows

Unit test review¶

Date of the review: 01/12/2015

Person who did the review: Andre Neto

Result of coverage tests review: N/A

Result of functional tests review: PASS

Result of review: PASS

List of non-conformities:

• It is not clear if the HeapManager.TestFreeInvalidPointer crashes in Windows (a user-story to handle this has to be created)

The following list of tests (unrelated to this user-story fail):
[ FAILED ] 9 tests, listed below:
[ FAILED ] BasicFileGTest.TestOpen_FLAG_CREAT_EXCLUSIVE
[ FAILED ] ThreadsGTest.TestBeginThreadStacksize0
[ FAILED ] MutexSemGTest.TestIsRecursive
[ FAILED ] MutexSemGTest.TestRecursiveOff
[ FAILED ] LoadableLibraryGTest.TestOpenCloseLibrary
[ FAILED ] LoadableLibraryGTest.TestCloseLibrary
[ FAILED ] LoadableLibraryGTest.TestLoadFunction
[ FAILED ] LoadableLibraryGTest.TestLoadFunctionSquareBracketsOperator
[ FAILED ] LoadableLibraryGTest.TestGetModule