Requirements review¶

Date of the review: 26/10/2015

Person who did the review: Ivan Herrero

Version of requirements: 0.6

Result of review: N/A

List of non-conformities: N/A

Comments: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal requirements.

Architecture & design review¶

Date of the review: 26/10/2015

Person who did the review: Ivan Herrero

Version of architecture & design document: 0.6

Result of review: N/A

List of non-conformities: N/A

Comments: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal design.

Code and documentation review¶

Date of the review: 26/10/2015

Person who did the review: Ivan Herrero

Version of source code: 0.6

Result of review: PASS

List of non-conformities: N/A

Comments: [#169] Windows specific files not linted, i.e. linting performed in Linux.

Unit test review¶

Date of the review: 26/10/2015

Person who did the review: Ivan Herrero

Version of unit tests: 0.6

Result of coverage tests review: PASS

Result of functional tests review: PASS

Result of review: PASS

List of non-conformities:

• [#240] The following functions have not been covered by tests:
  • _ZN5MARTe28IntegerToStreamOctalNotationIiEEbRNS_8IOBufferET_tbbtb * _ZN5MARTe28IntegerToStreamOctalNotationIsEEbRNS_8IOBufferET_tbbtb * _ZN5MARTe29IntegerToStreamBinaryNotationIiEEbRNS_8IOBufferET_tbbtb * ZN5MARTeL30GetNumberOfDigitsOctalNotationIiEEtT * ZN5MARTeL30GetNumberOfDigitsOctalNotationIsEEtT * ZN5MARTeL31GetNumberOfDigitsBinaryNotationIiEEtT.

  However those functions are generated to print (u)int64, which miss a component to be completed. The tests will be repeated after the completion of IOBufferIntegerPrint and the addition of DoubleInteger, next sprint.

• [#169] The following tests fail in Windows, but succeed on Linux:
  • LoadableLibrary.* (A test with a true DLL is missing) * MutexSemGTest.TestIsRecursive (Recursive semaphores are not supported in Windows) * MutexSemGTest.TestRecursiveOff (Recursive semaphores are not supported in Windows)

Integration test review¶

Date of the review: 26/10/2015

Person who did the review: Ivan Herrero

Version of integration tests: 0.6

Result of review: N/A

List of non-conformities: N/A

Comments: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal integration tests.

Acceptance test review¶

Date of the review: 26/10/2015

Person who did the review: Ivan Herrero

Version of acceptance tests: 0.6

Result of review: N/A

List of non-conformities: N/A

Comments: As per the original MARTe implementation, the user stories of this sprint are support functions and do not require formal acceptance tests.