Project

General

Profile

User story #169

Merge into the develop branch the contents of the "windows" branch

Added by Ivan Herrero over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
High
Assignee:
-
Target version:
Start date:
21.07.2015
Due date:
% Done:

0%

Estimated time:
Git branch (link):
Git merge to develop (link):
SVN commit (link/?p=rev):

Description

The windows branch will contain the modification needed to generate DLL's on Windows without using the "friends idiom".

Note: At 21/07/2015 this branch is not create, yet. It will be created and maintained by Giuseppe and Filippo.

Port the IOBuffer classes from the develop_svn branch.
The IOBuffer classes contain all the infrastructure that is common to all the streams.

Source code files modified

Almost all files to add the export DLL_API macro

Architecture & design review

Date of the review: 22/10/2015

Person who did the review: André Neto

Version of architecture & design document: N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

Result of review: PASS

Code and documentation review

Date of the review: 22/10/2015

Person who did the review: André Neto

Result of review: PASS (Windows specific files not linted, i.e. linting performed in Linux).

List of non-conformities: N/A.

Unit test review

Date of the review: 22/10/2015

Person who did the review: PASS

Result of coverage tests review: PASS (Checked in Linux)

Result of functional tests review: PASS (Some windows tests fail).

Result of review: PASS (Given that in Linux the tests are successful).

List of non-conformities:

The following tests fail in Windows
  • LoadableLibrary.* (A test with a true DLL is missing)
  • MutexSemGTest.TestIsRecursive (Recursive semaphores are not supported in Windows)
  • MutexSemGTest.TestRecursiveOff (Recursive semaphores are not supported in Windows)

Associated revisions

Revision b5abb684 (diff)
Added by Giuseppe Ferrò over 9 years ago

List of Changes:

-Added DLL_EXPORT macro to all classes and functions.
-Added DLLOBJS variable in makefile due to collect all the object files
names (OperatingSystem/Windows path included) and fixed rules to
generate dll and def files.
-Added expdef executable used to generate a def file from a dll.
-Since some threads tests which use the ThreadsDatabase should begin
with the database empty to return successful now before to begin they
wait (with timeout) that threads of previous tests terminate.

User Story: #169

Revision 2cc63fc9 (diff)
Added by Giuseppe Ferro over 9 years ago

List of changes:
-Added empty definitions of dll_import and dll_export in Linux
GeneralDefinitionsOS otherwise it does not compile.

UserStory: #169

Revision 58b0380d (diff)
Added by Giuseppe Ferrò over 9 years ago

Solved all compile errors in windows.
#169

Revision eb563c99 (diff)
Added by Giuseppe Ferrò over 9 years ago

Solved minor issues in tests.
#169

Revision b3618085 (diff)
Added by Giuseppe Ferrò over 9 years ago

Added DDL macros
#169

Revision 04548081 (diff)
Added by Giuseppe Ferro over 9 years ago

Corrected the linux version.
#169

Revision 74c57eb7 (diff)
Added by Giuseppe Ferro over 9 years ago

added clean of .def files also in linux
#169

Revision 0ebfc0b0
Added by André Neto over 9 years ago

Merge remote-tracking branch 'origin/#238.2_Streams_Test' into
#169_Windows_Porting

Conflicts:
Source/Core/BareMetal/L1Portability/GlobalObjectsDatabase.h
Source/Core/BareMetal/L1Portability/Makefile.msc
Source/Core/BareMetal/Makefile.inc
Source/Core/Scheduler/Makefile.inc
Source/Core/Scheduler/Makefile.msc
Test/GTest/Makefile.inc

Revision e5b7542c
Added by Giuseppe Ferrò over 9 years ago

Merge remote-tracking branch 'origin/#238.2_Streams_Test' into
#169_Windows_Porting

Conflicts:
Test/Core/BareMetal/L0Types/Makefile.inc
Test/Core/BareMetal/L2Objects/ReferenceTest.cpp
Test/GTest/Makefile.inc

Revision 8e5b51ef (diff)
Added by André Neto over 9 years ago

#169 Corrected the depends generation

Revision ef6a758b (diff)
Added by André Neto over 9 years ago

#169 Removed static library includes

Revision e4ffa562 (diff)
Added by André Neto over 9 years ago

#169 removed unnecessary DLL_API macros

Revision 619628cf
Added by André Neto over 9 years ago

Merge branch '#169_Windows_Porting' of https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #169_Windows_Porting

Revision a43a42a4 (diff)
Added by André Neto over 9 years ago

#169 changed ErrorManagement and ThreadInformation to Generic

Revision 332add79
Added by André Neto over 9 years ago

Merge branch '#238.2_Streams_Test' into #169_Windows_Porting

Revision 304c13ec (diff)
Added by André Neto over 9 years ago

#169 merged with #238 and cleaned common linting problems

Revision 1f87e688 (diff)
Added by André Neto over 9 years ago

#169 Minor modification to include correct path to expdef.exe

History

#1 Updated by Ivan Herrero over 9 years ago

  • Target version set to Backlog

#2 Updated by Ivan Herrero over 9 years ago

  • Subject changed from Merge into the develop branch the contents of the windows to Merge into the develop branch the contents of the "windows" branch
  • Description updated (diff)

#3 Updated by André Neto over 9 years ago

  • Target version changed from Backlog to 0.3

#4 Updated by Riccardo Vitelli over 9 years ago

  • Status changed from New to Code: Impl

#5 Updated by Giuseppe Ferro over 9 years ago

  • Assignee set to Giuseppe Ferro

#6 Updated by Giuseppe Ferro over 9 years ago

  • Status changed from Code: Impl to Code: Rev

#7 Updated by Giuseppe Ferro over 9 years ago

Code implementation done: b5abb68

#8 Updated by Giuseppe Ferro over 9 years ago

  • Assignee deleted (Giuseppe Ferro)

#9 Updated by Riccardo Vitelli over 9 years ago

  • Target version changed from 0.3 to 0.4

#10 Updated by Riccardo Vitelli over 9 years ago

  • Status changed from Code: Rev to Code: Impl

#11 Updated by André Neto over 9 years ago

  • Target version changed from 0.4 to 0.5

#12 Updated by André Neto over 9 years ago

  • Assignee set to Giuseppe Ferro

#13 Updated by André Neto over 9 years ago

  • Target version changed from 0.5 to 0.6

#14 Updated by Giuseppe Ferro over 9 years ago

  • Status changed from Code: Impl to Code: Rev
  • Assignee deleted (Giuseppe Ferro)

Code implementation done: 74c57eb

#15 Updated by André Neto over 9 years ago

  • Description updated (diff)

#16 Updated by André Neto over 9 years ago

  • Assignee set to André Neto

#17 Updated by André Neto over 9 years ago

  • Assignee deleted (André Neto)

#18 Updated by André Neto over 9 years ago

  • Status changed from Code: Rev to Unit: Impl

#19 Updated by André Neto over 9 years ago

  • Assignee set to Giuseppe Ferro

#20 Updated by André Neto over 9 years ago

  • Assignee deleted (Giuseppe Ferro)

#21 Updated by André Neto over 9 years ago

  • Status changed from Unit: Impl to Unit: Rev

#22 Updated by André Neto over 9 years ago

  • Assignee set to André Neto

#23 Updated by André Neto over 9 years ago

  • Description updated (diff)

#24 Updated by André Neto over 9 years ago

  • Description updated (diff)
  • Assignee deleted (André Neto)

#25 Updated by André Neto over 9 years ago

  • Description updated (diff)

#26 Updated by Riccardo Vitelli over 9 years ago

  • Status changed from Unit: Rev to Closed

Also available in: Atom PDF