User story #278
Makefile adjustements
0%
Description
Align alphabetically the GTests in the GTest Makefile.inc
Removed unused flags in all the Makefiles and make sure that the static linking is done in the same way in Source/Core (where these are CORRECTLY defined in the Makefile.inc) and in Test/Core where these are WRONGLY defined in Makefile.linux and Makefile.msc.
Source code files modified¶
Architecture & design review¶
Date of the review: 25/11/2015
Person who did the review: André Neto
Version of architecture & design document: N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
Result of review: N/A
List of non-conformities: N/A
Code and documentation review¶
N/A
Unit test review¶
N/A
Associated revisions
#278 - Move LIBRARIES_STATIC variable from Makefile.linux and
Makefile.msc files to Makefile.inc ones.
#278 - Remove OPTIM variable from all makefiles, except on
MakeStdLibDefs.*.
History
#1 Updated by Ivan Herrero over 9 years ago
- Assignee set to Ivan Herrero
Branch #278_Makefile_adjustements created.
#2 Updated by Ivan Herrero over 9 years ago
List of source files set on variable OBJSX sorted on every Makefile.inc (commit b18c0bd).
#3 Updated by Ivan Herrero over 9 years ago
LIBRARIES_STATIC variable moved from Makefile.linux and
Makefile.msc files to Makefile.inc ones (commit 5d260bc).
#4 Updated by Ivan Herrero over 9 years ago
OPTIM variable removed from all makefiles, except on MakeStdLibDefs.* ones (commit f4730b6).
#5 Updated by Ivan Herrero over 9 years ago
Warning: Theses changes compile in Linux, but not in Windows because the develop branch lacks fixes done in #248_Windows_UDP_socket. Do not review this user story until #248_Windows_UDP_socket branch had been merged into develop and later merged forward to #278_Makefile_adjustements branch.
#6 Updated by Ivan Herrero over 9 years ago
- Status changed from Code: Impl to Unit: Rev
- Assignee deleted (
Ivan Herrero)
#7 Updated by Ivan Herrero over 9 years ago
- Status changed from Unit: Rev to Closed
Merged with develop branch on commit 5d746f8.
Branch #278_Makefile_adjustements deleted.
Note 1: It compiles on Linux with all tests, but on Windows it is necessary to deactivate the DirectoryScannerTest, DirectoryTest, SelectTest, DirectoryScannerGTest, DirectoryGTest, and SelectGTest.
Note 2: The execution of the unit tests on Windows reports the following issues:- [ FAILED ] HighResolutionTimerGTest.TestGetTimeStamp
- [ FAILED ] LoadableLibraryGTest.TestOpenCloseLibrary
- [ FAILED ] LoadableLibraryGTest.TestCloseLibrary
- [ FAILED ] LoadableLibraryGTest.TestLoadFunction
- [ FAILED ] LoadableLibraryGTest.TestLoadFunctionSquareBracketsOperator
- [ FAILED ] LoadableLibraryGTest.TestGetModule
- [ FAILED ] MutexSemGTest.TestIsRecursive
- [ FAILED ] MutexSemGTest.TestRecursiveOff
- [ FAILED ] ThreadsGTest.TestBeginThreadStacksize0
#8 Updated by Ivan Herrero over 9 years ago
- Description updated (diff)
#278 - Sort list of source files on variable OBJSX of every
makefile.inc.