MARTe2 » MARTe2-core

Verify and implement coding standard using Flexelint.

h1. Source code files modified

* Source/Core/L0Portability/LoadableLibrary.cpp
* Source/Core/L0Portability/LoadableLibrary.h
* Source/Core/L0Portability/OperatingSystem/Linux/LoadableLibraryOS.h
* Source/Core/L0Portability/OperatingSystem/Windows/LoadableLibraryOS.h
* Test/Core/L0Portability/LoadableLibraryTest.cpp
* Test/Core/L0Portability/LoadableLibraryTest.h
* Test/GTest/LoadableLibraryGTest.cpp

h1. Architecture & design review

*Date of the review:* 20/07/2015

*Person who did the review:* Ivan Herrero

*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

*Result of review:* N/A

*List of non-conformities:* N/A

h1. Code and documentation review

*Date of the review:* 20/07/2015

*Person who did the review:* Ivan Herrero

*Result of review:* PASS (MISRA compliant)

*List of non-conformities:* N/A

h1. Unit test review

*Date of the review:* 22/07/2015

*Person who did the review:* Ivan Herrero

*Result of coverage tests review:* FAIL

*Result of functional tests review:* FAIL

*Result of review:* FAIL

*List of non-conformities:*

Coverage: Error paths not exercised

Functions: It lacks a test for the constructor

General:

* The files do not follow the template for source files
* The member myLoadableLibrary must be private
* The private section must go to the end of class declaration

Note: Not proper test can be done for the LoadableLibrary::Close() function. It will have to be discussed in the future.