Project

General

Profile

User story #151

Lint: LoadableLibrary

Added by André Neto almost 10 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
0.2
Start date:
28.06.2015
Due date:
% Done:

0%

Estimated time:
Git branch (link):
Git merge to develop (link):
SVN commit (link/?p=rev):

Description

Verify and implement coding standard using Flexelint.

Source code files modified

  • Source/Core/L0Portability/LoadableLibrary.cpp
  • Source/Core/L0Portability/LoadableLibrary.h
  • Source/Core/L0Portability/OperatingSystem/Linux/LoadableLibraryOS.h
  • Source/Core/L0Portability/OperatingSystem/Windows/LoadableLibraryOS.h
  • Test/Core/L0Portability/LoadableLibraryTest.cpp
  • Test/Core/L0Portability/LoadableLibraryTest.h
  • Test/GTest/LoadableLibraryGTest.cpp

Architecture & design review

Date of the review: 20/07/2015

Person who did the review: Ivan Herrero

Version of architecture & design document: N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

Result of review: N/A

List of non-conformities: N/A

Code and documentation review

Date of the review: 20/07/2015

Person who did the review: Ivan Herrero

Result of review: PASS (MISRA compliant)

List of non-conformities: N/A

Unit test review

Date of the review: 23/07/2015

Person who did the review: Ivan Herrero

Result of coverage tests review: PASS

Result of functional tests review: PASS

Result of review: PASS

List of non-conformities: N/A

Coverage note: Error paths not exercised

Testing note: Not proper test can be done for the LoadableLibrary::Close() function. It will have to be discussed in the future.

Associated revisions

Revision d7a04219 (diff)
Added by Ivan Herrero over 9 years ago

#151 - Relinting of LoadableLibrary source files

Note: New linting errors has arised respect revision 6e57def, after
updating to the last version of flexelint configuration files.

Revision 32e5b2d5 (diff)
Added by Ivan Herrero over 9 years ago

#151 - Apply coding standard to LoadableLibrary source files (template
and comments)

Revision 678c6567 (diff)
Added by Ivan Herrero over 9 years ago

#151 - Minor formatting corrections (following template rules)

History

#1 Updated by Riccardo Vitelli almost 10 years ago

  • Target version set to Backlog

#2 Updated by Riccardo Vitelli almost 10 years ago

  • Target version changed from Backlog to 0.2

#3 Updated by Riccardo Vitelli almost 10 years ago

  • Status changed from New to Code: Impl

#4 Updated by Riccardo Vitelli over 9 years ago

  • Assignee set to Riccardo Vitelli

#5 Updated by Filippo Sartori over 9 years ago

  • Status changed from Code: Impl to Code: Rev

#6 Updated by Filippo Sartori over 9 years ago

  • Assignee deleted (Riccardo Vitelli)

#7 Updated by Ivan Herrero over 9 years ago

  • Description updated (diff)
  • Status changed from Code: Rev to Unit: Impl
  • Assignee set to Llorenc Capella

#8 Updated by Llorenc Capella over 9 years ago

  • Status changed from Unit: Impl to Unit: Rev

#9 Updated by Llorenc Capella over 9 years ago

  • Assignee deleted (Llorenc Capella)

Not proper test can be done for the LoadableLibrary::Close() function. It will have to be discussed in the future.

#10 Updated by Ivan Herrero over 9 years ago

  • Assignee set to Ivan Herrero

#11 Updated by Ivan Herrero over 9 years ago

  • Description updated (diff)
  • Status changed from Unit: Rev to Unit: Impl
  • Assignee deleted (Ivan Herrero)

Unit test review made on revision 32e5b2d.

#12 Updated by Llorenc Capella over 9 years ago

  • Assignee set to Llorenc Capella

#13 Updated by Llorenc Capella over 9 years ago

  • Status changed from Unit: Impl to Unit: Rev

#14 Updated by Llorenc Capella over 9 years ago

  • Assignee deleted (Llorenc Capella)

Template and test added.

#15 Updated by Ivan Herrero over 9 years ago

  • Assignee set to Ivan Herrero

#16 Updated by Ivan Herrero over 9 years ago

  • Description updated (diff)
  • Status changed from Unit: Rev to Closed
  • Assignee deleted (Ivan Herrero)

Unit test review made on revision 678c656.

Branch linting-loadablelibrary merged on develop branch (commit 3155e09).

Branch linting-loadablelibrary deleted.

Also available in: Atom PDF