User story #156
Updated by Ivan Herrero over 9 years ago
Verify and implement coding standard using Flexelint.
h1. Source code files modified
* Source/Core/L0Portability/Makefile.inc
* Source/Core/L0Portability/OperatingSystem/Windows/Makefile.inc
* Source/Core/L0Portability/OperatingSystem/Linux/Makefile.inc
* Source/Core/L0Portability/Processor.h
* Source/Core/L0Portability/Architecture/x86_gcc/ProcessorA.h
* Source/Core/L0Portability/Architecture/x86_cl/ProcessorA.h
* Source/Core/L0Portability/OperatingSystem/Linux/ProcessorOS.cpp
* Source/Core/L0Portability/OperatingSystem/Windows/ProcessorOS.cpp
* Test/Core/L0Portability/StringTestHelper.h
* Test/Core/L0Portability/ProcessorTest.cpp
* Test/Core/L0Portability/ProcessorTest.h
* Test/GTest/ProcessorGTest.cpp
h1. Architecture & design review
*Date of the review:* 27/07/2015
*Person who did the review:* Giuseppe Ferrò
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 27/07/2015
*Person who did the review:* Giuseppe Ferrò
*Result of review:* PASS (MISRA compliant)
*List of non-conformities:* N/A.
h1. Unit test review
*Date of the review:* 27/07/2015
*Person who did the review:* Ivan Herrero
*Result of coverage tests review:* PASS
*Result of functional tests review:* PASS
*Result of review:* PASS
*List of non-conformities:*
Coverage Note: In Processor::Family() the sentences inside the block protected by "if (family == 0xf)" has not been exercised, because the processor's family of the processor used in tests has not reached 0xf, so it does not need to use the Extended Family ID.
h1. Source code files modified
* Source/Core/L0Portability/Makefile.inc
* Source/Core/L0Portability/OperatingSystem/Windows/Makefile.inc
* Source/Core/L0Portability/OperatingSystem/Linux/Makefile.inc
* Source/Core/L0Portability/Processor.h
* Source/Core/L0Portability/Architecture/x86_gcc/ProcessorA.h
* Source/Core/L0Portability/Architecture/x86_cl/ProcessorA.h
* Source/Core/L0Portability/OperatingSystem/Linux/ProcessorOS.cpp
* Source/Core/L0Portability/OperatingSystem/Windows/ProcessorOS.cpp
* Test/Core/L0Portability/StringTestHelper.h
* Test/Core/L0Portability/ProcessorTest.cpp
* Test/Core/L0Portability/ProcessorTest.h
* Test/GTest/ProcessorGTest.cpp
h1. Architecture & design review
*Date of the review:* 27/07/2015
*Person who did the review:* Giuseppe Ferrò
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 27/07/2015
*Person who did the review:* Giuseppe Ferrò
*Result of review:* PASS (MISRA compliant)
*List of non-conformities:* N/A.
h1. Unit test review
*Date of the review:* 27/07/2015
*Person who did the review:* Ivan Herrero
*Result of coverage tests review:* PASS
*Result of functional tests review:* PASS
*Result of review:* PASS
*List of non-conformities:*
Coverage Note: In Processor::Family() the sentences inside the block protected by "if (family == 0xf)" has not been exercised, because the processor's family of the processor used in tests has not reached 0xf, so it does not need to use the Extended Family ID.