User story #156

Lint: Processor

Added by André Neto almost 10 years ago. Updated over 9 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Target version:

0.2

Start date:

28.06.2015

Due date:

% Done:

Estimated time:

Git branch (link):

Git merge to develop (link):

SVN commit (link/?p=rev):

Description

Verify and implement coding standard using Flexelint.

Source code files modified¶

Source/Core/L0Portability/Makefile.inc
Source/Core/L0Portability/OperatingSystem/Windows/Makefile.inc
Source/Core/L0Portability/OperatingSystem/Linux/Makefile.inc
Source/Core/L0Portability/Processor.h
Source/Core/L0Portability/Architecture/x86_gcc/ProcessorA.h
Source/Core/L0Portability/Architecture/x86_cl/ProcessorA.h
Source/Core/L0Portability/OperatingSystem/Linux/ProcessorOS.cpp
Source/Core/L0Portability/OperatingSystem/Windows/ProcessorOS.cpp
Test/Core/L0Portability/StringTestHelper.h
Test/Core/L0Portability/ProcessorTest.cpp
Test/Core/L0Portability/ProcessorTest.h
Test/GTest/ProcessorGTest.cpp

Architecture & design review¶

Date of the review: 27/07/2015

Person who did the review: Giuseppe Ferrò

Version of architecture & design document: N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

Result of review: N/A

List of non-conformities: N/A

Code and documentation review¶

Date of the review: 27/07/2015

Person who did the review: Giuseppe Ferrò

Result of review: PASS (MISRA compliant)

List of non-conformities: N/A.

Unit test review¶

Date of the review: 27/07/2015

Person who did the review: Ivan Herrero

Result of coverage tests review: PASS

Result of functional tests review: PASS

Result of review: PASS

List of non-conformities:

Coverage Note: In Processor::Family() the sentences inside the block protected by "if (family == 0xf)" has not been exercised, because the processor's family of the processor used in tests has not reached 0xf, so it does not need to use the Extended Family ID.

Associated revisions

Revision 7ad0ce43 (diff)
Added by André Neto almost 10 years ago

First linting of the code.

Applied linting rules to stories #144, #146 and #156

Revision ce744402 (diff)
Added by André Neto over 9 years ago

Fixed processor model reported in #123. Implementation of #156.

The bug related to the computation of the processor model was fixed (see
comment in #123).

As part of the linting process (#156) the code structure was slightly
changed in order to delegate the implementation of the Processor
operating system functionality to a .cpp unit. This improves the
consistency with the other operating system classes.

Revision c59c6ccb (diff)
Added by Giuseppe Ferrò over 9 years ago

Added ProcessorOS to makefile.
#156

Revision 330e4788 (diff)
Added by Giuseppe Ferro over 9 years ago

Minor changes to Processor tests implementation.
#156

Revision 4055caff (diff)
Added by Ivan Herrero over 9 years ago

#156 - Minor formatting corrections (following template rules)