User story #162
Updated by Ivan Herrero over 9 years ago
Verify and implement coding standard using Flexelint.
h1. Source code files modified
* Source/Core/L0Portability/ThreadsDatabase.cpp
* Source/Core/L0Portability/ThreadsDatabase.h
h1. Architecture & design review
*Date of the review:* 29/07/2015
*Person who did the review:* Riccardo Vitelli
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 29/07/2015
*Person who did the review:* Riccardo Vitelli
*Result of review:* PASS (MISRA non compliant)
*List of non-conformities:*
* MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:92:85: Note 9025: More than two pointer indirection levels used for type 'ThreadInformation ***' [MISRA C++ Rule 5-0-19]
* MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:92:85: Note 929: cast from pointer to pointer [MISRA C++ Rule 5-2-7]
* MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:195:78: Note 925: cast from pointer to pointer [MISRA C++ Rule 5-2-8], [MISRA C++ Rule 5-2-9]
* MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:207:107: Note 9025: More than two pointer indirection levels used for type 'ThreadInformation ***' [MISRA C++ Rule 5-0-19]
* MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:207:107: Note 929: cast from pointer to pointer [MISRA C++ Rule 5-2-7]
* MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:207:118: Note 925: cast from pointer to pointer [MISRA C++ Rule 5-2-8], [MISRA C++ Rule 5-2-9]
*NOTE:* ThreadsDatabase should be converted to the Singleton design pattern.
h1. Unit test review
*Date of the review:* 29/07/2015 --/07/2015
*Person who did the review:* Ivan Herrero
*Result of coverage tests review:* PASS ---
*Result of functional tests review:* N/A ---
*Result of review:* FAIL ---
*List of non-conformities:*
ThreadsDatabase class has not specific unit tests, but it is actually tested through the unit tests of Threads class.
Some error paths have not been exercised on unit tests. --
h1. Source code files modified
* Source/Core/L0Portability/ThreadsDatabase.cpp
* Source/Core/L0Portability/ThreadsDatabase.h
h1. Architecture & design review
*Date of the review:* 29/07/2015
*Person who did the review:* Riccardo Vitelli
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* N/A
*List of non-conformities:* N/A
h1. Code and documentation review
*Date of the review:* 29/07/2015
*Person who did the review:* Riccardo Vitelli
*Result of review:* PASS (MISRA non compliant)
*List of non-conformities:*
* MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:92:85: Note 9025: More than two pointer indirection levels used for type 'ThreadInformation ***' [MISRA C++ Rule 5-0-19]
* MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:92:85: Note 929: cast from pointer to pointer [MISRA C++ Rule 5-2-7]
* MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:195:78: Note 925: cast from pointer to pointer [MISRA C++ Rule 5-2-8], [MISRA C++ Rule 5-2-9]
* MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:207:107: Note 9025: More than two pointer indirection levels used for type 'ThreadInformation ***' [MISRA C++ Rule 5-0-19]
* MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:207:107: Note 929: cast from pointer to pointer [MISRA C++ Rule 5-2-7]
* MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:207:118: Note 925: cast from pointer to pointer [MISRA C++ Rule 5-2-8], [MISRA C++ Rule 5-2-9]
*NOTE:* ThreadsDatabase should be converted to the Singleton design pattern.
h1. Unit test review
*Date of the review:* 29/07/2015 --/07/2015
*Person who did the review:* Ivan Herrero
*Result of coverage tests review:* PASS ---
*Result of functional tests review:* N/A ---
*Result of review:* FAIL ---
*List of non-conformities:*
ThreadsDatabase class has not specific unit tests, but it is actually tested through the unit tests of Threads class.
Some error paths have not been exercised on unit tests. --