Project

General

Profile

User story #162

Lint: ThreadsDatabase

Added by André Neto almost 10 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
Backlog
Start date:
28.06.2015
Due date:
% Done:

0%

Estimated time:
Git branch (link):
Git merge to develop (link):
SVN commit (link/?p=rev):

Description

Verify and implement coding standard using Flexelint.

Source code files modified

  • Source/Core/L0Portability/ThreadsDatabase.cpp
  • Source/Core/L0Portability/ThreadsDatabase.h

Architecture & design review

Date of the review: 29/07/2015

Person who did the review: Riccardo Vitelli

Version of architecture & design document: N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

Result of review: N/A

List of non-conformities: N/A

Code and documentation review

Date of the review: 29/07/2015

Person who did the review: Riccardo Vitelli

Result of review: PASS (MISRA non compliant)

List of non-conformities:

  • MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:92:85: Note 9025: More than two pointer indirection levels used for type 'ThreadInformation ***' [MISRA C++ Rule 5-0-19]
  • MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:92:85: Note 929: cast from pointer to pointer [MISRA C++ Rule 5-2-7]
  • MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:195:78: Note 925: cast from pointer to pointer [MISRA C++ Rule 5-2-8], [MISRA C++ Rule 5-2-9]
  • MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:207:107: Note 9025: More than two pointer indirection levels used for type 'ThreadInformation ***' [MISRA C++ Rule 5-0-19]
  • MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:207:107: Note 929: cast from pointer to pointer [MISRA C++ Rule 5-2-7]
  • MARTe2-dev/Source/Core/L0Portability/ThreadsDatabase.cpp:207:118: Note 925: cast from pointer to pointer [MISRA C++ Rule 5-2-8], [MISRA C++ Rule 5-2-9]

NOTE: ThreadsDatabase should be converted to the Singleton design pattern.

Unit test review

Date of the review: 29/07/2015

Person who did the review: Ivan Herrero

Result of coverage tests review: PASS

Result of functional tests review: N/A

Result of review: FAIL

List of non-conformities:

ThreadsDatabase class has not specific unit tests, but it is actually tested through the unit tests of Threads class.

Some error paths have not been exercised on unit tests.

Associated revisions

Revision 7fce86c3 (diff)
Added by André Neto over 9 years ago

Lint of Threads #160, #161 and #162 is ready for review.

Revision bd448fd6 (diff)
Added by André Neto over 9 years ago

Simplified priority setting interface (#160, #161 and #162).

Revision e97f6c93 (diff)
Added by Riccardo Vitelli over 9 years ago

#162 - Minor formatting corrections (following template rules), removed
unused includes.

History

#1 Updated by Riccardo Vitelli almost 10 years ago

  • Target version set to Backlog

#2 Updated by Riccardo Vitelli almost 10 years ago

  • Target version changed from Backlog to 0.2

#3 Updated by Riccardo Vitelli almost 10 years ago

  • Status changed from New to Code: Impl

#4 Updated by Riccardo Vitelli over 9 years ago

  • Status changed from Code: Impl to Code: Rev

#5 Updated by Ivan Herrero over 9 years ago

  • Assignee set to Riccardo Vitelli

#6 Updated by Riccardo Vitelli over 9 years ago

  • Description updated (diff)

Code review made on revision e97f6c9.

#7 Updated by Riccardo Vitelli over 9 years ago

  • Status changed from Code: Rev to Unit: Impl
  • Assignee deleted (Riccardo Vitelli)

#8 Updated by Riccardo Vitelli over 9 years ago

  • Status changed from Unit: Impl to Unit: Rev

#9 Updated by Ivan Herrero over 9 years ago

  • Description updated (diff)

Unit test review made on revision 6196fef.

#10 Updated by Ivan Herrero over 9 years ago

  • Target version changed from 0.2 to Backlog

#11 Updated by André Neto almost 7 years ago

  • Status changed from Unit: Rev to Closed

Done in another user-story. DEPRECATED.

Also available in: Atom PDF