User story #169
Updated by André Neto over 9 years ago
The windows branch will contain the modification needed to generate DLL's on Windows without using the "friends idiom".
Note: At 21/07/2015 this branch is not create, yet. It will be created and maintained by Giuseppe and Filippo.
Port the IOBuffer classes from the develop_svn branch.
The IOBuffer classes contain all the infrastructure that is common to all the streams.
h1. Source code files modified
Almost all files to add the export DLL_API macro
h1. Architecture & design review
*Date of the review:* 22/10/2015
*Person who did the review:* André Neto
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* PASS
h1. Code and documentation review
*Date of the review:* 22/10/2015
*Person who did the review:* André Neto
*Result of review:* PASS (Windows specific files not linted, i.e. linting performed in Linux).
*List of non-conformities:* N/A.
h1. Unit test review
*Date of the review:* 22/10/2015
*Person who did the review:* PASS
*Result of coverage tests review:* PASS (Checked in Linux)
*Result of functional tests review:* PASS (Some windows tests fail).
*Result of review:* PASS (Given that in Linux the tests are successful).
*List of non-conformities:*
The following tests fail in Windows
* LoadableLibrary.* (A test with a true DLL is missing)
* MutexSemGTest.TestIsRecursive (Recursive semaphores are not supported in Windows)
* MutexSemGTest.TestRecursiveOff (Recursive semaphores are not supported in Windows)
* StreamStringGTest.TestDestructor (To be investigated)
Note: At 21/07/2015 this branch is not create, yet. It will be created and maintained by Giuseppe and Filippo.
Port the IOBuffer classes from the develop_svn branch.
The IOBuffer classes contain all the infrastructure that is common to all the streams.
h1. Source code files modified
Almost all files to add the export DLL_API macro
h1. Architecture & design review
*Date of the review:* 22/10/2015
*Person who did the review:* André Neto
*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
*Result of review:* PASS
h1. Code and documentation review
*Date of the review:* 22/10/2015
*Person who did the review:* André Neto
*Result of review:* PASS (Windows specific files not linted, i.e. linting performed in Linux).
*List of non-conformities:* N/A.
h1. Unit test review
*Date of the review:* 22/10/2015
*Person who did the review:* PASS
*Result of coverage tests review:* PASS (Checked in Linux)
*Result of functional tests review:* PASS (Some windows tests fail).
*Result of review:* PASS (Given that in Linux the tests are successful).
*List of non-conformities:*
The following tests fail in Windows
* LoadableLibrary.* (A test with a true DLL is missing)
* MutexSemGTest.TestIsRecursive (Recursive semaphores are not supported in Windows)
* MutexSemGTest.TestRecursiveOff (Recursive semaphores are not supported in Windows)
* StreamStringGTest.TestDestructor (To be investigated)