MARTe2 » MARTe2-core

Implement the Linux TCP socket stream based on the previous MARTe implementation.

h1. Source code files modified

FileSystem/Environment/Linux/InternetAddressCore.h
FileSystem/Environment/Linux/InternetServiceCore.h
FileSystem/Environment/Linux/SocketSelectCore.h
FileSystem/Environment/Linux/SocketCore.h
FileSystem/InternetAddress.*
FileSystem/InternetService.*
FileSystem/BasicSocket.*
FileSystem/BasicTCPSocket.*
FileSystem/SocketSelect.*

h1. Architecture & design review

*Date of the review:* 23/10/2015

*Person who did the review:* André Neto

*Version of architecture & design document:* N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.

*Result of review:* N/A

*List of non-conformities:* N/A

h1. Code and documentation review

*Date of the review:* 09/11/2015 --/--/2015

*Person who did the review:* R. Vitelli

*Result of review:* PASS FAIL

*List of non-conformities:*



* In BasicTCPSocket::Read there is a Sleep::Msec that is not needed (not inside a polling loop). Remove.

h1. Unit test review

*Date of the review:* 09/11/2015 --/--/2015

*Person who did the review:* R. Vitelli -----

*Result of coverage tests review:* PASS [PASS/FAIL]

*Result of functional tests review:* PASS [PASS/FAIL]

*Result of review:* PASS [PASS/FAIL]

*List of non-conformities:*

The current implementation uses a temporary version of SocketSelect, which will be further developed in the following sprints. For this reason the low code coverage of SocketSelect is not considered an issue.