User story #245
Linux TCP socket
0%
Description
Implement the Linux TCP socket stream based on the previous MARTe implementation.
Source code files modified¶
FileSystem/Environment/Linux/InternetAddressCore.h
FileSystem/Environment/Linux/InternetServiceCore.h
FileSystem/Environment/Linux/SocketSelectCore.h
FileSystem/Environment/Linux/SocketCore.h
FileSystem/InternetAddress.*
FileSystem/InternetService.*
FileSystem/BasicSocket.*
FileSystem/BasicTCPSocket.*
FileSystem/SocketSelect.*
Architecture & design review¶
Date of the review: 23/10/2015
Person who did the review: André Neto
Version of architecture & design document: N/A. As per the original MARTe implementation, this is a support function and does not require formal design in UML.
Result of review: N/A
List of non-conformities: N/A
Code and documentation review¶
Date of the review: 09/11/2015
Person who did the review: R. Vitelli
Result of review: PASS
List of non-conformities: N/A
Unit test review¶
Date of the review: 09/11/2015
Person who did the review: R. Vitelli
Result of coverage tests review: PASS
Result of functional tests review: PASS
Result of review: PASS
List of non-conformities:
The current implementation uses a temporary version of SocketSelect, which will be further developed in the following sprints. For this reason the low code coverage of SocketSelect is not considered an issue.
Associated revisions
Merge remote-tracking branch 'origin/#249_BufferedStreamGenerator' into #245_Linux_TCP_Socket
#245_Linux_File
BasicFile.h and BasicFile.cpp created.
Make files modified to include the new files.
-Lint and documentation of SocketSelect.*
#245
Added error reporting.
#245
Added InternetAddress tests.
#245
Renamed InternetAddress to InternetHost
#245
Merged with local #245 to apply renaming from InternetAddress to
InternetHost
Removed copy constructor from TCP socket
#245
Changes in BasicSocket.h
- GetSource and GetDestination return by copy because the access to the
source and destination attributes is allowed now to the children.
- Removed GetConnectionSocket to avoid any access to the internal socket
handle which is not necessary.
- Put SocketSelect as a friend of BasicSocket because it needs the
access to the internal socket handle.
#245
#245 Fixed some lint warnings.
Merge remote-tracking branch 'origin/#247_Linux_UDP_Socket' into #245_Linux_TCP_Socket
Merge remote-tracking branch 'origin/#247_Linux_UDP_Socket' into
#245_Linux_TCP_Socket
Conflicts:
Source/Core/FileSystem/L1Portability/BasicSocket.h
Source/Core/FileSystem/L1Portability/Environment/Linux/BasicTCPSocket.cpp
#245 BasicTCPSocket tests done.
Merge branch '#245_Linux_TCP_Socket' of https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #245_Linux_TCP_Socket
#245 Documentation improved
#245 Fixed lint warnings
#245 Removed two useless lint exception comments.
Merge remote-tracking branch 'origin/#247_Linux_UDP_Socket' into
#245_Linux_TCP_Socket
Conflicts:
Source/Core/FileSystem/L1Portability/Environment/Linux/BasicTCPSocket.cpp
#245 Clean and improved tests
#245 Removed an unused header file
#245 Fixed test warnings
#245 Fixed an error in tests
#245 Fixed typos.
#245 Removed two header inclusions
Merge branch '#245_Linux_TCP_Socket' of https://vcis-gitlab.f4e.europa.eu/aneto/MARTe2.git into #245_Linux_TCP_Socket
#245 Improved error reporting
#245 Work in progress.
#245 Fixed the timeout
#245 Removed a test wich fails on other machines because of different
localhost
#245 Fixed tests and fixed makefile in order to avoid clean each time.
#245 Improved makefile.
History
#1 Updated by André Neto over 9 years ago
- Status changed from New to Code: Impl
#2 Updated by André Neto over 9 years ago
- Description updated (diff)
#3 Updated by André Neto over 9 years ago
- Target version set to 0.7
#4 Updated by Giuseppe Ferro over 9 years ago
- Assignee set to Giuseppe Ferro
#5 Updated by Giuseppe Ferro over 9 years ago
- Status changed from Code: Impl to Code: Rev
#6 Updated by Giuseppe Ferro over 9 years ago
- Description updated (diff)
- Assignee deleted (
Giuseppe Ferro)
code implementation done: 78a86d3
#7 Updated by Riccardo Vitelli over 9 years ago
- Assignee set to Riccardo Vitelli
#8 Updated by Riccardo Vitelli over 9 years ago
- Description updated (diff)
#9 Updated by Riccardo Vitelli over 9 years ago
- Status changed from Code: Rev to Unit: Impl
#10 Updated by Riccardo Vitelli over 9 years ago
- Assignee changed from Riccardo Vitelli to Giuseppe Ferro
#11 Updated by Riccardo Vitelli over 9 years ago
- Status changed from Unit: Impl to Unit: Rev
#12 Updated by Riccardo Vitelli over 9 years ago
- Assignee changed from Giuseppe Ferro to Riccardo Vitelli
#13 Updated by Riccardo Vitelli over 9 years ago
- Description updated (diff)
- Assignee deleted (
Riccardo Vitelli)
#14 Updated by Riccardo Vitelli over 9 years ago
- Status changed from Unit: Rev to Closed
#15 Updated by Ivan Herrero over 9 years ago
- Description updated (diff)
Fixed compile errors for TCPSocket.h
#245